| Message ID | 20221005174343.24240-2-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support | expand |
Il 05/10/22 19:43, Yassine Oudjana ha scritto: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Remove syscon compatible string from pin controller to follow > DT bindings and pass checks. Adding the syscon compatible to > the DT bindings documentation instead causes a different check > error due to the syscon document specifying a maximum of 1 item > in the reg property, while this has 9. Please change this part of the description... > Nothing is using the pin > controller as a syscon at the moment so it should be a safe > thing to do. ...to: This pin controller has never been, and will never be, used as a syscon, hence it is safe to drop this compatible. After which, you get my Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > arch/arm64/boot/dts/mediatek/mt6779.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi > index 9bdf5145966c..a6fa5212da4e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi > @@ -160,7 +160,7 @@ infracfg_ao: clock-controller@10001000 { > }; > > pio: pinctrl@10005000 { > - compatible = "mediatek,mt6779-pinctrl", "syscon"; > + compatible = "mediatek,mt6779-pinctrl"; > reg = <0 0x10005000 0 0x1000>, > <0 0x11c20000 0 0x1000>, > <0 0x11d10000 0 0x1000>,
On Wed, Oct 05, 2022 at 08:43:34PM +0300, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Remove syscon compatible string from pin controller to follow > DT bindings and pass checks. Adding the syscon compatible to > the DT bindings documentation instead causes a different check > error due to the syscon document specifying a maximum of 1 item > in the reg property, while this has 9. Nothing is using the pin > controller as a syscon at the moment so it should be a safe > thing to do. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > arch/arm64/boot/dts/mediatek/mt6779.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi index 9bdf5145966c..a6fa5212da4e 100644 --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi @@ -160,7 +160,7 @@ infracfg_ao: clock-controller@10001000 { }; pio: pinctrl@10005000 { - compatible = "mediatek,mt6779-pinctrl", "syscon"; + compatible = "mediatek,mt6779-pinctrl"; reg = <0 0x10005000 0 0x1000>, <0 0x11c20000 0 0x1000>, <0 0x11d10000 0 0x1000>,