diff mbox series

[1/2] ci(main): upgrade actions/checkout to v3

Message ID 2dbb779f7fde175a8acd8e9de7c81db32fdf3e81.1665388136.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series ci(main): upgrade actions/checkout to v3 | expand

Commit Message

Óscar Domínguez Celada Oct. 10, 2022, 7:48 a.m. UTC 
From: Oscar Dominguez <dominguez.celada@gmail.com>

to be up to date with actions/checkout opens the door to use the latest
features if necessary and get the latest security patches.

Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>
---
 .github/workflows/main.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Junio C Hamano Oct. 10, 2022, 8:55 p.m. UTC | #1 
"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Hmph.  When 0dc787a9 (ci: accelerate the checkout, 2021-07-04)
updated us from actions/checkout@v1 to actions/checkout@v2 it listed
a lot more concrete "what we gain by doing this change", than the
hand-wavy "opens the door" argument.

And it left container jobs at @v1 with an explanation that @v2
seemed to be incompatible.  If the issue has that been resolved in
@v3, it would be necessary to say that the issue has been resolved
and it is safe to use @v3 there in the proposed log message.

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 831f4df56c5..8dc9d938159 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> ...
> @@ -291,7 +291,7 @@ jobs:
>      runs-on: ubuntu-latest
>      container: ${{matrix.vector.image}}
>      steps:
> -    - uses: actions/checkout@v1
> +    - uses: actions/checkout@v3
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures
diff mbox series

Patch

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 831f4df56c5..8dc9d938159 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -83,7 +83,7 @@  jobs:
     if: needs.ci-config.outputs.enabled == 'yes'
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: build
       shell: bash
@@ -138,10 +138,10 @@  jobs:
       GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'"
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: initialize vcpkg
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'microsoft/vcpkg'
         path: 'compat/vcbuild/vcpkg'
@@ -258,7 +258,7 @@  jobs:
       runs_on_pool: ${{matrix.vector.pool}}
     runs-on: ${{matrix.vector.pool}}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures
@@ -291,7 +291,7 @@  jobs:
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v3
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures
@@ -311,7 +311,7 @@  jobs:
       jobname: StaticAnalysis
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-static-analysis.sh
     - run: ci/check-directional-formatting.bash
@@ -331,7 +331,7 @@  jobs:
         artifact: sparse-20.04
     - name: Install the current `sparse` package
       run: sudo dpkg -i sparse-20.04/sparse_*.deb
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Install other dependencies
       run: ci/install-dependencies.sh
     - run: make sparse
@@ -343,6 +343,6 @@  jobs:
       jobname: Documentation
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/test-documentation.sh