[v2,00/15] ASoC: Intel: avs: Fixes and new boards support

Message

Cezary Rojewski Oct. 10, 2022, 12:19 p.m. UTC

Two fixes are leading the way - one addresses the incorrect DMA mask
assignment (typo) at driver probe. The other, fixes a potential buffer
overflow when copying data received from firmware to kernel buffer.
However unlikely, the fix should still be there.

Then a range of patches providing the support for:
- AML with rt286 (machine board)
- KBL-R for rt298 (codec)
- KBL-R with rt298 (machine board)
- APL/KBL with da7219 (machine board)
- Addition of all the missing SKL-based PCI ids to core.c

Of the remaining changes, only one stands out - special case is provided
for "unsupported" IPCs. The driver supports a range of platforms,
however, on some generations given IPC may not be supported. Such call
shall not be treated as "invalid" - those are two different scenarios.

Everything else in the patchset is mostly a readability improvement:
spelling fixes and log messages issues, code simplification.


Changes in v2:
- no code changes, just added missing signed-off-by tags

Amadeusz Sławiński (4):
  ASoC: codecs: rt298: Add quirk for KBL-R RVP platform
  ASoC: Intel: avs: Add quirk for KBL-R RVP platform
  ASoC: Intel: avs: Support da7219 on both KBL and APL
  ASoC: Intel: avs: Add missing include to HDA board

Cezary Rojewski (11):
  ASoC: Intel: avs: Fix DMA mask assignment
  ASoC: Intel: avs: Fix potential RX buffer overflow
  ASoC: Intel: avs: Support AML with rt286 configuration
  ASoC: Intel: avs: Add missing SKL-based device IDs
  ASoC: Intel: avs: Simplify d0ix disabling routine
  ASoC: Intel: avs: Do not reuse msg between different IPC handlers
  ASoC: Intel: avs: Do not treat unsupported IPCs as invalid
  ASoC: Intel: avs: Do not print IPC error message twice
  ASoC: Intel: avs: Simplify ignore_fw_version description
  ASoC: Intel: avs: Simplify log control for SKL
  ASoC: codecs: hda: Fix spelling error in log message

 sound/soc/codecs/hda.c                |  2 +-
 sound/soc/codecs/rt298.c              |  7 +++++++
 sound/soc/intel/avs/apl.c             |  6 ++++--
 sound/soc/intel/avs/avs.h             |  4 +++-
 sound/soc/intel/avs/board_selection.c |  6 ++++++
 sound/soc/intel/avs/boards/da7219.c   |  6 +++++-
 sound/soc/intel/avs/boards/hdaudio.c  |  1 +
 sound/soc/intel/avs/boards/rt298.c    | 24 ++++++++++++++++++++++--
 sound/soc/intel/avs/core.c            |  6 +++++-
 sound/soc/intel/avs/ipc.c             |  5 +++--
 sound/soc/intel/avs/loader.c          |  2 +-
 sound/soc/intel/avs/messages.c        | 19 ++++---------------
 sound/soc/intel/avs/messages.h        |  2 ++
 sound/soc/intel/avs/skl.c             |  4 ++--
 14 files changed, 66 insertions(+), 28 deletions(-)

Comments

Mark Brown Oct. 18, 2022, 12:13 p.m. UTC | #1

On Mon, 10 Oct 2022 14:19:40 +0200, Cezary Rojewski wrote:
> Two fixes are leading the way - one addresses the incorrect DMA mask
> assignment (typo) at driver probe. The other, fixes a potential buffer
> overflow when copying data received from firmware to kernel buffer.
> However unlikely, the fix should still be there.
> 
> Then a range of patches providing the support for:
> - AML with rt286 (machine board)
> - KBL-R for rt298 (codec)
> - KBL-R with rt298 (machine board)
> - APL/KBL with da7219 (machine board)
> - Addition of all the missing SKL-based PCI ids to core.c
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/15] ASoC: Intel: avs: Fix DMA mask assignment
        commit: 83375566a7a7042cb34b24986d100f46bfa0c1e5
[02/15] ASoC: Intel: avs: Fix potential RX buffer overflow
        commit: 23ae34e033b2c0e5e88237af82b163b296fd6aa9
[03/15] ASoC: codecs: rt298: Add quirk for KBL-R RVP platform
        commit: 953dbd1cef18ce9ac0d69c1bd735b929fe52a17e
[04/15] ASoC: Intel: avs: Add quirk for KBL-R RVP platform
        commit: 9d0737fa0e7530313634c0ecd75f09a95ba8d44a
[05/15] ASoC: Intel: avs: Support AML with rt286 configuration
        commit: 8b2446eaa45a3be5bb5c6fb79cc745d228dac431
[06/15] ASoC: Intel: avs: Support da7219 on both KBL and APL
        commit: fecc00b448a9b89c858468318bfdddbc5bd9dc6d
[07/15] ASoC: Intel: avs: Add missing SKL-based device IDs
        commit: d1356811abf785b995dd74750fc75efffa3d7656
[08/15] ASoC: Intel: avs: Simplify d0ix disabling routine
        commit: e720e68b3fa25268e1df8a6d91d3bdb80f4fc38a
[09/15] ASoC: Intel: avs: Add missing include to HDA board
        commit: e331b534d3b1a5a36a7bc1e7a85e21d2561aa2e6
[10/15] ASoC: Intel: avs: Do not reuse msg between different IPC handlers
        commit: 18a787909ca6bac3a3a3235c08d68a4a9838fe7b
[11/15] ASoC: Intel: avs: Do not treat unsupported IPCs as invalid
        commit: 2d27a1caf8ef0c443486b18de2fada3120e3fbe1
[12/15] ASoC: Intel: avs: Do not print IPC error message twice
        commit: 65edda6015682a31d82111b7a417eaa8232547f8
[13/15] ASoC: Intel: avs: Simplify ignore_fw_version description
        commit: 263e3e2dfef7a9d39c91bbd2ff61bd0619c68e3b
[14/15] ASoC: Intel: avs: Simplify log control for SKL
        commit: bfced33e1eb868b1085c7cfadfb71e6e497059cb
[15/15] ASoC: codecs: hda: Fix spelling error in log message
        commit: 62d0cee4e6f592a8c6da9e969f404e907ae65d88

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark