| Message ID | ffbb92010f643307766c9307fd42f416e5b85fa0.1661266564.git.bristot@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] rv/dot2c: Make automaton definition static | expand |
On Tue, 23 Aug 2022 17:20:28 +0200 Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > Monitor's automata definition is only used locally, so make dot2c generate > a static definition. > > Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com > Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com > Somehow this fell through the cracks. Daniel, is there any reason I shouldn't pull this in now? -- Steve > Cc: Steven Rostedt <rostedt@goodmis.org> > Fixes: e3c9fc78f096 ("tools/rv: Add dot2c") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org> > --- > tools/verification/dot2/dot2c.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py > index fa73353f7e56..be8a364a469b 100644 > --- a/tools/verification/dot2/dot2c.py > +++ b/tools/verification/dot2/dot2c.py > @@ -111,7 +111,7 @@ class Dot2c(Automata): > > def format_aut_init_header(self): > buff = [] > - buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) > + buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) > return buff > > def __get_string_vector_per_line_content(self, buff):
On Tue, 18 Oct 2022 18:25:53 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > On Tue, 23 Aug 2022 17:20:28 +0200 > Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > > > Monitor's automata definition is only used locally, so make dot2c generate > > a static definition. > > > > Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com > > Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com > > > > Somehow this fell through the cracks. > > Daniel, is there any reason I shouldn't pull this in now? I think when I applied: https://patchwork.kernel.org/project/linux-trace-devel/patch/a50e27c3738d6ef809f4201857229fed64799234.1661266564.git.bristot@kernel.org/ I mistook that to be a new version of this patch. -- Steve
On 10/19/22 00:25, Steven Rostedt wrote: > On Tue, 23 Aug 2022 17:20:28 +0200 > Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > >> Monitor's automata definition is only used locally, so make dot2c generate >> a static definition. >> >> Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com >> Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com >> > Somehow this fell through the cracks. > > Daniel, is there any reason I shouldn't pull this in now? Oops... yes, it can be pulled. -- Daniel
On Wed, 19 Oct 2022 15:15:54 +0200 Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > On 10/19/22 00:25, Steven Rostedt wrote: > > On Tue, 23 Aug 2022 17:20:28 +0200 > > Daniel Bristot de Oliveira <bristot@kernel.org> wrote: > > > >> Monitor's automata definition is only used locally, so make dot2c generate > >> a static definition. > >> > >> Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com > >> Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com > >> > > Somehow this fell through the cracks. > > > > Daniel, is there any reason I shouldn't pull this in now? > > Oops... yes, it can be pulled. > OK, I'm going to push this up as tools/urgent and send a pull request to Linus. -- Steve
diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py index fa73353f7e56..be8a364a469b 100644 --- a/tools/verification/dot2/dot2c.py +++ b/tools/verification/dot2/dot2c.py @@ -111,7 +111,7 @@ class Dot2c(Automata): def format_aut_init_header(self): buff = [] - buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) + buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def)) return buff def __get_string_vector_per_line_content(self, buff):
Monitor's automata definition is only used locally, so make dot2c generate a static definition. Link: https://lore.kernel.org/all/202208210332.gtHXje45-lkp@intel.com Link: https://lore.kernel.org/all/202208210358.6HH3OrVs-lkp@intel.com Cc: Steven Rostedt <rostedt@goodmis.org> Fixes: e3c9fc78f096 ("tools/rv: Add dot2c") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org> --- tools/verification/dot2/dot2c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)