| Message ID | 20221019063115.3757510-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] drm/amd/display: make dcn32_mmhubbub_funcs static | expand |
On 2022-10-19 02:31, ruanjinjie wrote: > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28: > warning: symbol 'dcn32_mmhubbub_funcs' was > not declared. Should it be static? > > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > index 41b0baf8e183..c3b089ba511a 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb, > REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice); > } > > -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { > +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { > .warmup_mcif = mmhubbub32_warmup_mcif, > .enable_mcif = mmhubbub2_enable_mcif, > .disable_mcif = mmhubbub2_disable_mcif,
Applied. Thanks! Alex On Wed, Oct 19, 2022 at 9:27 AM Harry Wentland <harry.wentland@amd.com> wrote: > > > > On 2022-10-19 02:31, ruanjinjie wrote: > > The symbol is not used outside of the file, so mark it static. > > > > Fixes the following warning: > > > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28: > > warning: symbol 'dcn32_mmhubbub_funcs' was > > not declared. Should it be static? > > > > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > > index 41b0baf8e183..c3b089ba511a 100644 > > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c > > @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb, > > REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice); > > } > > > > -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { > > +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { > > .warmup_mcif = mmhubbub32_warmup_mcif, > > .enable_mcif = mmhubbub2_enable_mcif, > > .disable_mcif = mmhubbub2_disable_mcif, >
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c index 41b0baf8e183..c3b089ba511a 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb, REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice); } -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = { .warmup_mcif = mmhubbub32_warmup_mcif, .enable_mcif = mmhubbub2_enable_mcif, .disable_mcif = mmhubbub2_disable_mcif,
The symbol is not used outside of the file, so mark it static. Fixes the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28: warning: symbol 'dcn32_mmhubbub_funcs' was not declared. Should it be static? Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)