mbox series

[liburing,v2,0/3] Clean up clang `-Wshorten-64-to-32` warnings

Message ID 20221020131118.13828-1-ammar.faizi@intel.com (mailing list archive)
Headers show
Series Clean up clang `-Wshorten-64-to-32` warnings | expand

Message

Ammar Faizi Oct. 20, 2022, 1:14 p.m. UTC 
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Hi Jens,

This is a v2.

v2:
  - Fix Signed-off-by tag.
  - Make the cast in patch #1 consistent.

Please consider this small cleanup series before the release.

This series is a follow up of the clean up `-Wshorten-64-to-32`
warnings that I discussed with Dylan previously. It only addresses
the warnings in the src/ dir (main library). We ignore the tests
for now.

`-Wshorten-64-to-32` is a clang-specific flag, it currently doesn't
exist in GCC.

There are 3 patches in this series:

- Patch 1 is to clean up the warnings in the main library
  (this is based on a patch from Dylan).

  Taken from: https://github.com/DylanZA/liburing/commit/cdd6dfbb9019.patch

- Patch 2 is to introduce LIBURING_CFLAGS variable in the Makefile. We
  need this varaible to apply specific compiler flags to the main
  library only. Currently, this flag is only used by the GitHub bot.

- Patch 3 is to integrate `-Wshorten-64-to-32` flag to the GitHub bot.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---

Ammar Faizi (2):
  Makefile: Introduce `LIBURING_CFLAGS` variable
  github: Append `-Wshorten-64-to-32` flag for clang build

Dylan Yudaken (1):
  liburing: Clean up `-Wshorten-64-to-32` warnings from clang

 .github/workflows/build.yml |  4 ++++
 src/Makefile                |  5 ++++-
 src/arch/syscall-defs.h     |  4 ++--
 src/register.c              |  5 ++++-
 src/setup.c                 | 12 ++++++------
 src/syscall.h               |  4 ++--
 6 files changed, 22 insertions(+), 12 deletions(-)


base-commit: 3049530665ba6464f3c5f6f80b28e965719ca602

Comments

Jens Axboe Oct. 20, 2022, 2:11 p.m. UTC | #1 
On Thu, 20 Oct 2022 20:14:52 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> 
> Hi Jens,
> 
> This is a v2.
> 
> v2:
>   - Fix Signed-off-by tag.
>   - Make the cast in patch #1 consistent.
> 
> [...]

Applied, thanks!

[1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang
      commit: b9df4750ce9335437a34fd93c76863d871b70416
[2/3] Makefile: Introduce `LIBURING_CFLAGS` variable
      commit: 1755faf1737d0d84775aa46dd0a2b4b2e3474d28
[3/3] github: Append `-Wshorten-64-to-32` flag for clang build
      commit: 80817b7cd56b96a095c3cb4583a357d16fb867f1

Best regards,