| Message ID | 20221021181906.16647-1-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | [RESEND,1/2] thermal: qcom: tsens: init debugfs only with successful probe | expand |
On 21/10/2022 20:19, Christian Marangi wrote: > calibrate and tsens_register can fail or PROBE_DEFER. This will cause a > double or a wrong init of the debugfs information. Init debugfs only > with successful probe fixing warning about directory already present. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > Acked-by: Thara Gopinath <thara.gopinath@linaro.org> > --- > drivers/thermal/qcom/tsens.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index b1b10005fb28..cc2965b8d409 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -918,8 +918,6 @@ int __init init_common(struct tsens_priv *priv) > if (tsens_version(priv) >= VER_0_1) > tsens_enable_irq(priv); > > - tsens_debug_init(op); > - > err_put_device: > put_device(&op->dev); > return ret; > @@ -1153,7 +1151,12 @@ static int tsens_probe(struct platform_device *pdev) > } > } > > - return tsens_register(priv); > + ret = tsens_register(priv); > + extra line > + if (!ret) > + tsens_debug_init(pdev); > + > + return ret; > } > > static int tsens_remove(struct platform_device *pdev)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index b1b10005fb28..cc2965b8d409 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -918,8 +918,6 @@ int __init init_common(struct tsens_priv *priv) if (tsens_version(priv) >= VER_0_1) tsens_enable_irq(priv); - tsens_debug_init(op); - err_put_device: put_device(&op->dev); return ret; @@ -1153,7 +1151,12 @@ static int tsens_probe(struct platform_device *pdev) } } - return tsens_register(priv); + ret = tsens_register(priv); + + if (!ret) + tsens_debug_init(pdev); + + return ret; } static int tsens_remove(struct platform_device *pdev)