| Message ID | 20220930142018.890535-1-patrice.chotard@foss.st.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3f53c329b31d53b2a2e7992819242fc0d4f883e0 |
| Headers | show |
| Series | [v3] usb: dwc3: st: Rely on child's compatible instead of name | expand |
On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote: > From: Patrice Chotard <patrice.chotard@foss.st.com> > > To ensure that child node is found, don't rely on child's node name > which can take different value, but on child's compatible name. > > Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") > Cc: Jerome Audu <jerome.audu@st.com> > Reported-by: Felipe Balbi <felipe@balbi.sh> > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > v3: - rebase on correct branch > v2: - add missing reported-by > - add Fixes > --- > drivers/usb/dwc3/dwc3-st.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 6c14a79279f9..fea5290de83f 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) > /* Manage SoftReset */ > reset_control_deassert(dwc3_data->rstc_rst); > > - child = of_get_child_by_name(node, "usb"); > + child = of_get_compatible_child(node, "snps,dwc3"); > if (!child) { > dev_err(&pdev->dev, "failed to find dwc3 core node\n"); > ret = -ENODEV; > -- > 2.25.1 > Is this still needed for 6.1-final? thanks, greg k-h
On 10/22/22 12:26, Greg Kroah-Hartman wrote: > On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote: >> From: Patrice Chotard <patrice.chotard@foss.st.com> >> >> To ensure that child node is found, don't rely on child's node name >> which can take different value, but on child's compatible name. >> >> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") >> Cc: Jerome Audu <jerome.audu@st.com> >> Reported-by: Felipe Balbi <felipe@balbi.sh> >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> v3: - rebase on correct branch >> v2: - add missing reported-by >> - add Fixes >> --- >> drivers/usb/dwc3/dwc3-st.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c >> index 6c14a79279f9..fea5290de83f 100644 >> --- a/drivers/usb/dwc3/dwc3-st.c >> +++ b/drivers/usb/dwc3/dwc3-st.c >> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) >> /* Manage SoftReset */ >> reset_control_deassert(dwc3_data->rstc_rst); >> >> - child = of_get_child_by_name(node, "usb"); >> + child = of_get_compatible_child(node, "snps,dwc3"); >> if (!child) { >> dev_err(&pdev->dev, "failed to find dwc3 core node\n"); >> ret = -ENODEV; >> -- >> 2.25.1 >> > > Is this still needed for 6.1-final? Yes, still needed for v6.1. Thanks Patrice > > thanks, > > greg k-h
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c index 6c14a79279f9..fea5290de83f 100644 --- a/drivers/usb/dwc3/dwc3-st.c +++ b/drivers/usb/dwc3/dwc3-st.c @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) /* Manage SoftReset */ reset_control_deassert(dwc3_data->rstc_rst); - child = of_get_child_by_name(node, "usb"); + child = of_get_compatible_child(node, "snps,dwc3"); if (!child) { dev_err(&pdev->dev, "failed to find dwc3 core node\n"); ret = -ENODEV;