| Message ID | 20221024151201.2215380-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: cti: Remove unused variables in cti_{dis,en}able_hw() | expand |
Hi Nathan On 24/10/2022 16:12, Nathan Chancellor wrote: > Clean up the following warnings, as the variables are no longer used. > > drivers/hwtracing/coresight/coresight-cti-core.c:93:17: warning: unused variable 'dev' [-Wunused-variable] > struct device *dev = &drvdata->csdev->dev; > ^ > drivers/hwtracing/coresight/coresight-cti-core.c:154:17: warning: unused variable 'dev' [-Wunused-variable] > struct device *dev = &drvdata->csdev->dev; > ^ > 2 warnings generated. > > Fixes: 665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> Thanks for your patch, this is now reverted upstream. I have queued a patch locally to sqaush the changes and plan to push it once the revert lands upstream. Thanks Suzuki
diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c index 4a02ae23d3a0..c6e8c6542f24 100644 --- a/drivers/hwtracing/coresight/coresight-cti-core.c +++ b/drivers/hwtracing/coresight/coresight-cti-core.c @@ -90,7 +90,6 @@ void cti_write_all_hw_regs(struct cti_drvdata *drvdata) static int cti_enable_hw(struct cti_drvdata *drvdata) { struct cti_config *config = &drvdata->config; - struct device *dev = &drvdata->csdev->dev; unsigned long flags; int rc = 0; @@ -151,7 +150,6 @@ static void cti_cpuhp_enable_hw(struct cti_drvdata *drvdata) static int cti_disable_hw(struct cti_drvdata *drvdata) { struct cti_config *config = &drvdata->config; - struct device *dev = &drvdata->csdev->dev; struct coresight_device *csdev = drvdata->csdev; spin_lock(&drvdata->spinlock);
Clean up the following warnings, as the variables are no longer used. drivers/hwtracing/coresight/coresight-cti-core.c:93:17: warning: unused variable 'dev' [-Wunused-variable] struct device *dev = &drvdata->csdev->dev; ^ drivers/hwtracing/coresight/coresight-cti-core.c:154:17: warning: unused variable 'dev' [-Wunused-variable] struct device *dev = &drvdata->csdev->dev; ^ 2 warnings generated. Fixes: 665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/hwtracing/coresight/coresight-cti-core.c | 2 -- 1 file changed, 2 deletions(-) base-commit: 665c157e0204176023860b51a46528ba0ba62c33