| Message ID | 20221024122828.9692-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | bcma: Use the proper include | expand |
On 10/24/2022 2:28 PM, Linus Walleij wrote: > The <linux/bcma/bcma_driver_chipcommon.h> is including the legacy > header <linux/gpio.h> to obtain struct gpio_chip. Instead, include > <linux/gpio/driver.h> where this struct is defined. Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > include/linux/bcma/bcma_driver_chipcommon.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On Mon, Oct 24, 2022 at 2:28 PM Linus Walleij <linus.walleij@linaro.org> wrote: > The <linux/bcma/bcma_driver_chipcommon.h> is including the legacy > header <linux/gpio.h> to obtain struct gpio_chip. Instead, include > <linux/gpio/driver.h> where this struct is defined. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> I'm squashing this with the other patch and resending due to the co-dependence found by the kernel test robot. Yours, Linus Walleij
diff --git a/include/linux/bcma/bcma_driver_chipcommon.h b/include/linux/bcma/bcma_driver_chipcommon.h index 2d94c30ed439..0cb6638b55e5 100644 --- a/include/linux/bcma/bcma_driver_chipcommon.h +++ b/include/linux/bcma/bcma_driver_chipcommon.h @@ -4,7 +4,7 @@ #include <linux/platform_device.h> #include <linux/platform_data/brcmnand.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h> /** ChipCommon core registers. **/ #define BCMA_CC_ID 0x0000
The <linux/bcma/bcma_driver_chipcommon.h> is including the legacy header <linux/gpio.h> to obtain struct gpio_chip. Instead, include <linux/gpio/driver.h> where this struct is defined. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- include/linux/bcma/bcma_driver_chipcommon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)