diff mbox series

arm64: dts: meson: nanopi-k2: readd PHY reset properties

Message ID 20221025143205.14470-1-christianshewitt@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: meson: nanopi-k2: readd PHY reset properties | expand

Commit Message

Christian Hewitt Oct. 25, 2022, 2:32 p.m. UTC
The sync of device-tree/bindings in 11a48a5a18c6 ("Linux 5.6-rc2") causes
Ethernet to break on some GXBB boards; the PHY seems to need proper reset
timing to function in u-boot and Linux. Re-add the old PHY reset binding
for dwmac until we support new bindings in the PHY node. This borrows the
same fix applied to the Odroid C2 board [0].

[0] https://lists.denx.de/pipermail/u-boot/2021-April/446658.html

Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2")
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
 arch/arm/dts/meson-gxbb-nanopi-k2-u-boot.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Neil Armstrong Oct. 25, 2022, 3:16 p.m. UTC | #1
Hi,

On Tue, 25 Oct 2022 14:32:05 +0000, Christian Hewitt wrote:
> The sync of device-tree/bindings in 11a48a5a18c6 ("Linux 5.6-rc2") causes
> Ethernet to break on some GXBB boards; the PHY seems to need proper reset
> timing to function in u-boot and Linux. Re-add the old PHY reset binding
> for dwmac until we support new bindings in the PHY node. This borrows the
> same fix applied to the Odroid C2 board [0].
> 
> [0] https://lists.denx.de/pipermail/u-boot/2021-April/446658.html
> 
> [...]

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-amlogic (u-boot-amlogic-test)

[1/1] arm64: dts: meson: nanopi-k2: readd PHY reset properties
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/7b70f68977578360d9c47bb25d6d1937075153b4
diff mbox series

Patch

diff --git a/arch/arm/dts/meson-gxbb-nanopi-k2-u-boot.dtsi b/arch/arm/dts/meson-gxbb-nanopi-k2-u-boot.dtsi
index c35158d7e9..2a245bbe7f 100644
--- a/arch/arm/dts/meson-gxbb-nanopi-k2-u-boot.dtsi
+++ b/arch/arm/dts/meson-gxbb-nanopi-k2-u-boot.dtsi
@@ -5,3 +5,10 @@ 
  */
 
 #include "meson-gx-u-boot.dtsi"
+
+&ethmac {
+	snps,reset-gpio = <&gpio GPIOZ_14 0>;
+	snps,reset-delays-us = <0 10000 1000000>;
+	snps,reset-active-low;
+};
+