| Message ID | TYXPR01MB18543A8B371E885CC9AA497CD9309@TYXPR01MB1854.jpnprd01.prod.outlook.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] nfs: Move ACL xattr definitions to linux/xattr.h | expand |
> On Oct 26, 2022, at 4:48 AM, Ondrej Valousek <ondrej.valousek.xm@renesas.com> wrote: > > Hi kernel maintainers, > > Please help to submit the following patch into kernel > --- > Signed-off-by: Ondrej Valousek <ondrej.valousek.xm@renesas.com> > Short description: > > The XATTR_NAME_NFSV4_ACL definition is also useful for userspace (i.e. nfs4_acl_tools/libacl/coreutils) so makes a sense to move the definition to the linux/xattr.h Hey Ondrej! Let's start by copying the correct maintainers for these files so the patch gets proper review: $ scripts/get_maintainer.pl include/uapi/linux/xattr.h linux-kernel@vger.kernel.org (open list) $ scripts/get_maintainer.pl fs/nfs/nfs4proc.c Trond Myklebust <trond.myklebust@hammerspace.com> (maintainer:NFS, SUNRPC, AND LOCKD CLIENTS) Anna Schumaker <anna@kernel.org> (maintainer:NFS, SUNRPC, AND LOCKD CLIENTS) linux-nfs@vger.kernel.org (open list:NFS, SUNRPC, AND LOCKD CLIENTS) linux-kernel@vger.kernel.org (open list) $ Can you update the To/Cc and repost? > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c > index e2efcd26336c..07c3d8572912 100644 > --- a/fs/nfs/nfs4proc.c > +++ b/fs/nfs/nfs4proc.c > @@ -7680,8 +7680,6 @@ nfs4_release_lockowner(struct nfs_server *server, struct nfs4_lock_state *lsp) > rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_ops, data); > } > > -#define XATTR_NAME_NFSV4_ACL "system.nfs4_acl" > - > static int nfs4_xattr_set_nfs4_acl(const struct xattr_handler *handler, > struct user_namespace *mnt_userns, > struct dentry *unused, struct inode *inode, > diff --git a/include/uapi/linux/xattr.h b/include/uapi/linux/xattr.h > index 9463db2dfa9d..77eb8c885861 100644 > --- a/include/uapi/linux/xattr.h > +++ b/include/uapi/linux/xattr.h > @@ -81,5 +81,7 @@ > #define XATTR_POSIX_ACL_DEFAULT "posix_acl_default" > #define XATTR_NAME_POSIX_ACL_DEFAULT XATTR_SYSTEM_PREFIX XATTR_POSIX_ACL_DEFAULT > > +#define XATTR_NFSV4_ACL "nfs4_acl" > +#define XATTR_NAME_NFSV4_ACL XATTR_SYSTEM_PREFIX XATTR_NFSV4_ACL > > #endif /* _UAPI_LINUX_XATTR_H */ -- Chuck Lever
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index e2efcd26336c..07c3d8572912 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -7680,8 +7680,6 @@ nfs4_release_lockowner(struct nfs_server *server, struct nfs4_lock_state *lsp) rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_ops, data); } -#define XATTR_NAME_NFSV4_ACL "system.nfs4_acl" - static int nfs4_xattr_set_nfs4_acl(const struct xattr_handler *handler, struct user_namespace *mnt_userns, struct dentry *unused, struct inode *inode, diff --git a/include/uapi/linux/xattr.h b/include/uapi/linux/xattr.h index 9463db2dfa9d..77eb8c885861 100644 --- a/include/uapi/linux/xattr.h +++ b/include/uapi/linux/xattr.h @@ -81,5 +81,7 @@ #define XATTR_POSIX_ACL_DEFAULT "posix_acl_default" #define XATTR_NAME_POSIX_ACL_DEFAULT XATTR_SYSTEM_PREFIX XATTR_POSIX_ACL_DEFAULT +#define XATTR_NFSV4_ACL "nfs4_acl" +#define XATTR_NAME_NFSV4_ACL XATTR_SYSTEM_PREFIX XATTR_NFSV4_ACL #endif /* _UAPI_LINUX_XATTR_H */
Hi kernel maintainers, Please help to submit the following patch into kernel --- Signed-off-by: Ondrej Valousek <ondrej.valousek.xm@renesas.com> Short description: The XATTR_NAME_NFSV4_ACL definition is also useful for userspace (i.e. nfs4_acl_tools/libacl/coreutils) so makes a sense to move the definition to the linux/xattr.h