| Message ID | 20221024230658.1772907-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai | expand |
On Mon, 24 Oct 2022 19:06:57 -0400, Nícolas F. R. A. Prado wrote: > sound-dai is a standard property whose type is already set to > phandle-array by sound-dai.yaml, so there's no need to set it (and > wrongly so for headset-codec) in this binding. What should be set > however is the maximum number of items, which for headset-codec should > be 1. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > .../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Mon, 24 Oct 2022 19:06:57 -0400, Nícolas F. R. A. Prado wrote: > sound-dai is a standard property whose type is already set to > phandle-array by sound-dai.yaml, so there's no need to set it (and > wrongly so for headset-codec) in this binding. What should be set > however is the maximum number of items, which for headset-codec should > be 1. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: mt8192-mt6359: Set maxItems, not type, for sound-dai commit: 555e6f573a0a08b66b9543a0e098c5d6adf8e8af All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml index 478be7e3fa29..c6e614c1c30b 100644 --- a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml @@ -34,7 +34,7 @@ properties: properties: sound-dai: - $ref: /schemas/types.yaml#/definitions/phandle + maxItems: 1 required: - sound-dai @@ -48,7 +48,6 @@ properties: maxItems: 2 items: maxItems: 1 - $ref: /schemas/types.yaml#/definitions/phandle-array required: - sound-dai
sound-dai is a standard property whose type is already set to phandle-array by sound-dai.yaml, so there's no need to set it (and wrongly so for headset-codec) in this binding. What should be set however is the maximum number of items, which for headset-codec should be 1. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- .../devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)