[RESEND,v3,1/3] dt-bindings: watchdog: Add compatible for MediaTek MT8188

Commit Message

Runyang Chen Oct. 26, 2022, 6:33 a.m. UTC

From: Runyang Chen <[e-mail]>

Add dt-binding documentation of watchdog for MediaTek MT8188 Soc

Signed-off-by: Runyang Chen <[e-mail]>
Acked-by: Krzysztof Kozlowski <[e-mail]>
Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>
---
 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Oct. 26, 2022, 3:26 p.m. UTC | #1

On Wed, Oct 26, 2022 at 02:33:25PM +0800, Runyang Chen wrote:
> From: Runyang Chen <[e-mail]>
> 
> Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
> 
> Signed-off-by: Runyang Chen <[e-mail]>
> Acked-by: Krzysztof Kozlowski <[e-mail]>
> Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>

This conflicts with the ongoing yaml conversion of this file
which is still not accepted.

https://patchwork.kernel.org/project/linux-watchdog/patch/[e-mail]/

Nevertheless, I'll apply this series to my watchdog-next branch
and assume that it will be included in the next version of the
yaml conversion patch.

For my and Wim's reference:

Reviewed-by: Guenter Roeck <[e-mail]>

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> index 762c62e428ef..b900c85d4560 100644
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> @@ -17,6 +17,7 @@ Required properties:
>  	"mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
>  	"mediatek,mt8183-wdt": for MT8183
>  	"mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> +	"mediatek,mt8188-wdt", "mediatek,mt6589-wdt": for MT8188
>  	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>  	"mediatek,mt8192-wdt": for MT8192
>  	"mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195

AngeloGioacchino Del Regno Oct. 27, 2022, 7:54 a.m. UTC | #2

Il 26/10/22 17:26, Guenter Roeck ha scritto:
> On Wed, Oct 26, 2022 at 02:33:25PM +0800, Runyang Chen wrote:
>> From: Runyang Chen <[e-mail]>
>>
>> Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
>>
>> Signed-off-by: Runyang Chen <[e-mail]>
>> Acked-by: Krzysztof Kozlowski <[e-mail]>
>> Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>
> 
> This conflicts with the ongoing yaml conversion of this file
> which is still not accepted.
> 
> https://patchwork.kernel.org/project/linux-watchdog/patch/[e-mail]/
> 
> Nevertheless, I'll apply this series to my watchdog-next branch
> and assume that it will be included in the next version of the
> yaml conversion patch.
> 
> For my and Wim's reference:
> 
> Reviewed-by: Guenter Roeck <[e-mail]>
> 
> Thanks,
> Guenter
> 
Adding Allen to the Cc's to make him aware of that, as he took over the
mtk-wdt yaml conversion.

Allen-KH Cheng Oct. 27, 2022, 8:56 a.m. UTC | #3

On Thu, 2022-10-27 at 09:54 +0200, AngeloGioacchino Del Regno wrote:
> Il 26/10/22 17:26, Guenter Roeck ha scritto:
> > On Wed, Oct 26, 2022 at 02:33:25PM +0800, Runyang Chen wrote:
> > > From: Runyang Chen <[e-mail]>
> > > 
> > > Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
> > > 
> > > Signed-off-by: Runyang Chen <[e-mail]>
> > > Acked-by: Krzysztof Kozlowski <[e-mail]>
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > [e-mail]>
> > 
> > This conflicts with the ongoing yaml conversion of this file
> > which is still not accepted.
> > 
> > 
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-watchdog/patch/[e-mail]/__;!!CTRNKA9wMg0ARbw!zT39OehD4gnyDKPYwMbLdeyGI_oNOfvWa4HIrcooL3Ax8O7-N-BjXBZAolsCOuLb39fJ7Q$
> >  
> > 
> > Nevertheless, I'll apply this series to my watchdog-next branch
> > and assume that it will be included in the next version of the
> > yaml conversion patch.
> > 
> > For my and Wim's reference:
> > 
> > Reviewed-by: Guenter Roeck <[e-mail]>
> > 
> > Thanks,
> > Guenter
> > 
> 
> Adding Allen to the Cc's to make him aware of that, as he took over
> the
> mtk-wdt yaml conversion.

Hi Guenter,

I can send the following version of yaml conversion[1] for conflicts 
after you apply this series. Thanks.

[1]

https://patchwork.kernel.org/project/linux-mediatek/patch/[e-mail]/

BRs,
Allen

Guenter Roeck Oct. 27, 2022, 1:42 p.m. UTC | #4

On 10/27/22 01:56, Allen-KH Cheng (程冠勳) wrote:
> On Thu, 2022-10-27 at 09:54 +0200, AngeloGioacchino Del Regno wrote:
>> Il 26/10/22 17:26, Guenter Roeck ha scritto:
>> > On Wed, Oct 26, 2022 at 02:33:25PM +0800, Runyang Chen wrote:
>> > > From: Runyang Chen <[e-mail]>
>> > > 
>> > > Add dt-binding documentation of watchdog for MediaTek MT8188 Soc
>> > > 
>> > > Signed-off-by: Runyang Chen <[e-mail]>
>> > > Acked-by: Krzysztof Kozlowski <[e-mail]>
>> > > Reviewed-by: AngeloGioacchino Del Regno <
>> > > [e-mail]>
>> > 
>> > This conflicts with the ongoing yaml conversion of this file
>> > which is still not accepted.
>> > 
>> > 
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-watchdog/patch/[e-mail]/__;!!CTRNKA9wMg0ARbw!zT39OehD4gnyDKPYwMbLdeyGI_oNOfvWa4HIrcooL3Ax8O7-N-BjXBZAolsCOuLb39fJ7Q$
>> >  
>> > 
>> > Nevertheless, I'll apply this series to my watchdog-next branch
>> > and assume that it will be included in the next version of the
>> > yaml conversion patch.
>> > 
>> > For my and Wim's reference:
>> > 
>> > Reviewed-by: Guenter Roeck <[e-mail]>
>> > 
>> > Thanks,
>> > Guenter
>> > 
>> 
>> Adding Allen to the Cc's to make him aware of that, as he took over
>> the
>> mtk-wdt yaml conversion.
> 
> Hi Guenter,
> 
> I can send the following version of yaml conversion[1] for conflicts
> after you apply this series. Thanks.
> 
> [1]
> 
> https://patchwork.kernel.org/project/linux-mediatek/patch/[e-mail]/
>

You did not copy the watchdog mailing list with this patch, causing it to get lost
from my queue (even though I had a look at it). If there were other watchdog related
patches in this version of the series, they got lost as well.

Guenter

Allen-KH Cheng Oct. 27, 2022, 1:54 p.m. UTC | #5

On Thu, 2022-10-27 at 06:42 -0700, Guenter Roeck wrote:
> On 10/27/22 01:56, Allen-KH Cheng (程冠勳) wrote:
> > On Thu, 2022-10-27 at 09:54 +0200, AngeloGioacchino Del Regno
> > wrote:
> > > Il 26/10/22 17:26, Guenter Roeck ha scritto:
> > > > On Wed, Oct 26, 2022 at 02:33:25PM +0800, Runyang Chen wrote:
> > > > > From: Runyang Chen <[e-mail]>
> > > > > 
> > > > > Add dt-binding documentation of watchdog for MediaTek MT8188
> > > > > Soc
> > > > > 
> > > > > Signed-off-by: Runyang Chen <[e-mail]>
> > > > > Acked-by: Krzysztof Kozlowski <[e-mail]
> > > > > >
> > > > > Reviewed-by: AngeloGioacchino Del Regno <
> > > > > [e-mail]>
> > > > 
> > > > This conflicts with the ongoing yaml conversion of this file
> > > > which is still not accepted.
> > > > 
> > > > 
> > 
> > 
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-watchdog/patch/[e-mail]/__;!!CTRNKA9wMg0ARbw!zT39OehD4gnyDKPYwMbLdeyGI_oNOfvWa4HIrcooL3Ax8O7-N-BjXBZAolsCOuLb39fJ7Q$
> > > >  
> > > > 
> > > > Nevertheless, I'll apply this series to my watchdog-next branch
> > > > and assume that it will be included in the next version of the
> > > > yaml conversion patch.
> > > > 
> > > > For my and Wim's reference:
> > > > 
> > > > Reviewed-by: Guenter Roeck <[e-mail]>
> > > > 
> > > > Thanks,
> > > > Guenter
> > > > 
> > > 
> > > Adding Allen to the Cc's to make him aware of that, as he took
> > > over
> > > the
> > > mtk-wdt yaml conversion.
> > 
> > Hi Guenter,
> > 
> > I can send the following version of yaml conversion[1] for
> > conflicts
> > after you apply this series. Thanks.
> > 
> > [1]
> > 
> > 
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/[e-mail]/__;!!CTRNKA9wMg0ARbw!x4FHF5pdLxzPJgGcQt0ynL6wlmvETMGvJUCO9n1hlI8-beeKNYEnONwnl5-WI4kvCV-45w$
> >  
> > 
> 
> You did not copy the watchdog mailing list with this patch, causing
> it to get lost
> from my queue (even though I had a look at it). If there were other
> watchdog related
> patches in this version of the series, they got lost as well.
> 
> Guenter
> 

I apologize for missing this and will pay attention next time (v3).

BRs,
Allen

Krzysztof Kozlowski Oct. 27, 2022, 2:52 p.m. UTC | #6

On 27/10/2022 09:54, Allen-KH Cheng (程冠勳) wrote:
>> You did not copy the watchdog mailing list with this patch, causing
>> it to get lost
>> from my queue (even though I had a look at it). If there were other
>> watchdog related
>> patches in this version of the series, they got lost as well.
>>
>> Guenter
>>
> 
> I apologize for missing this and will pay attention next time (v3).
> 

Just use get_maintainers.pl and automate your task... Automation removes
(most) mistakes.

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
index 762c62e428ef..b900c85d4560 100644
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
@@ -17,6 +17,7 @@  Required properties:
 	"mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
 	"mediatek,mt8183-wdt": for MT8183
 	"mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
+	"mediatek,mt8188-wdt", "mediatek,mt6589-wdt": for MT8188
 	"mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
 	"mediatek,mt8192-wdt": for MT8192
 	"mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195