[00/11] x86: clean up ACPI PCI code part 2

Message ID	20221017102146.2254096-1-imammedo@redhat.com (mailing list archive)
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Igor Mammedov <imammedo@redhat.com> To: qemu-devel@nongnu.org Cc: mst@redhat.com, ani@anisinha.ca Subject: [PATCH 00/11] x86: clean up ACPI PCI code part 2 Date: Mon, 17 Oct 2022 12:21:35 +0200 Message-Id: <20221017102146.2254096-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>
Series	x86: clean up ACPI PCI code part 2 \| expand [00/11] x86: clean up ACPI PCI code part 2 [01/11] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors [02/11] tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML automatically [03/11] acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML [04/11] tests: acpi: update expected DSDT after ISA bridge is moved directly under PCI host bridge [05/11] tests: acpi: whitelist DSDT before generating ICH9_SMB AML automatically [06/11] acpi: add get_dev_aml_func() helper [07/11] acpi: enumerate SMB bridge automatically along with other PCI devices [08/11] tests: acpi: update expected blobs [09/11] tests: acpi: pc/q35 whitelist DSDT before \_GPE cleanup [10/11] acpi: pc/35: sanitize _GPE declaration order [11/11] tests: acpi: update expected blobs

Message ID

20221017102146.2254096-1-imammedo@redhat.com (mailing list archive)

Headers

From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com,
	ani@anisinha.ca
Subject: [PATCH 00/11] x86: clean up ACPI PCI code part 2
Date: Mon, 17 Oct 2022 12:21:35 +0200
Message-Id: <20221017102146.2254096-1-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=170.10.133.124;
 envelope-from=imammedo@redhat.com;
 helo=us-smtp-delivery-124.mimecast.com
X-Spam_score_int: -23
X-Spam_score: -2.4
X-Spam_bar: --
X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Sender: "Qemu-devel"
 <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>

Series

x86: clean up ACPI PCI code part 2 | expand

Message

Igor Mammedov Oct. 17, 2022, 10:21 a.m. UTC

Series continues refactoring started at recently merged [1].
It replaces special cases/quirks for ISA/SMB bridges and PCI
attached VGA devices with generic AcpiDevAmlIf interface,
which allows device to provide its own AML description
without need for adhoc plumbing in generic DSDT or PCI
enumeration code.

PS:
at the end, \_GPE clean up patches which are not part of
AcpiDevAmlIf refactoring but iti's still related to PCI,
so I've included them there as well.

 1)
  https://patchwork.ozlabs.org/project/qemu-devel/list/?series=303856

Igor Mammedov (11):
  acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device
    descriptors
  tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML
    automatically
  acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus
    ennumeration generate AML
  tests: acpi: update expected DSDT after ISA bridge is moved directly
    under PCI host bridge
  tests: acpi: whitelist DSDT before generating ICH9_SMB AML
    automatically
  acpi: add get_dev_aml_func() helper
  acpi: enumerate SMB bridge automatically along with other PCI devices
  tests: acpi: update expected blobs
  tests: acpi: pc/q35 whitelist DSDT before \_GPE cleanup
  acpi: pc/35: sanitize _GPE declaration order
  tests: acpi: update expected blobs

 hw/display/vga_int.h                  |   2 +
 include/hw/acpi/acpi_aml_interface.h  |  13 +-
 hw/display/acpi-vga-stub.c            |   7 ++
 hw/display/acpi-vga.c                 |  26 ++++
 hw/display/meson.build                |  17 +++
 hw/display/vga-pci.c                  |   4 +
 hw/i386/acpi-build.c                  | 175 +++++---------------------
 hw/isa/lpc_ich9.c                     |  23 ++++
 hw/isa/piix3.c                        |  17 ++-
 tests/data/acpi/pc/DSDT               | Bin 6422 -> 6501 bytes
 tests/data/acpi/pc/DSDT.acpierst      | Bin 6382 -> 6461 bytes
 tests/data/acpi/pc/DSDT.acpihmat      | Bin 7747 -> 7826 bytes
 tests/data/acpi/pc/DSDT.bridge        | Bin 9496 -> 9575 bytes
 tests/data/acpi/pc/DSDT.cphp          | Bin 6886 -> 6965 bytes
 tests/data/acpi/pc/DSDT.dimmpxm       | Bin 8076 -> 8155 bytes
 tests/data/acpi/pc/DSDT.hpbridge      | Bin 6382 -> 6461 bytes
 tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3107 bytes
 tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6494 -> 6573 bytes
 tests/data/acpi/pc/DSDT.memhp         | Bin 7781 -> 7860 bytes
 tests/data/acpi/pc/DSDT.nohpet        | Bin 6280 -> 6359 bytes
 tests/data/acpi/pc/DSDT.numamem       | Bin 6428 -> 6507 bytes
 tests/data/acpi/pc/DSDT.roothp        | Bin 6656 -> 6699 bytes
 tests/data/acpi/q35/DSDT              | Bin 8320 -> 8412 bytes
 tests/data/acpi/q35/DSDT.acpierst     | Bin 8337 -> 8429 bytes
 tests/data/acpi/q35/DSDT.acpihmat     | Bin 9645 -> 9737 bytes
 tests/data/acpi/q35/DSDT.applesmc     | Bin 8366 -> 8458 bytes
 tests/data/acpi/q35/DSDT.bridge       | Bin 11449 -> 11541 bytes
 tests/data/acpi/q35/DSDT.cphp         | Bin 8784 -> 8876 bytes
 tests/data/acpi/q35/DSDT.cxl          | Bin 9646 -> 9738 bytes
 tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9974 -> 10066 bytes
 tests/data/acpi/q35/DSDT.ipmibt       | Bin 8395 -> 8487 bytes
 tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8409 -> 8500 bytes
 tests/data/acpi/q35/DSDT.ivrs         | Bin 8337 -> 8429 bytes
 tests/data/acpi/q35/DSDT.memhp        | Bin 9679 -> 9771 bytes
 tests/data/acpi/q35/DSDT.mmio64       | Bin 9450 -> 9542 bytes
 tests/data/acpi/q35/DSDT.multi-bridge | Bin 8640 -> 8732 bytes
 tests/data/acpi/q35/DSDT.nohpet       | Bin 8178 -> 8270 bytes
 tests/data/acpi/q35/DSDT.numamem      | Bin 8326 -> 8418 bytes
 tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8421 -> 8513 bytes
 tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8926 -> 9018 bytes
 tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8952 -> 9044 bytes
 tests/data/acpi/q35/DSDT.viot         | Bin 9429 -> 9521 bytes
 tests/data/acpi/q35/DSDT.xapic        | Bin 35683 -> 35775 bytes
 43 files changed, 135 insertions(+), 149 deletions(-)
 create mode 100644 hw/display/acpi-vga-stub.c
 create mode 100644 hw/display/acpi-vga.c

Comments

Igor Mammedov Oct. 27, 2022, 12:06 p.m. UTC | #1

On Mon, 17 Oct 2022 12:21:35 +0200
Igor Mammedov <imammedo@redhat.com> wrote:

> Series continues refactoring started at recently merged [1].
> It replaces special cases/quirks for ISA/SMB bridges and PCI
> attached VGA devices with generic AcpiDevAmlIf interface,
> which allows device to provide its own AML description
> without need for adhoc plumbing in generic DSDT or PCI
> enumeration code.
> 
> PS:
> at the end, \_GPE clean up patches which are not part of
> AcpiDevAmlIf refactoring but iti's still related to PCI,
> so I've included them there as well.


ping

> 
>  1)
>   https://patchwork.ozlabs.org/project/qemu-devel/list/?series=303856
> 
> Igor Mammedov (11):
>   acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device
>     descriptors
>   tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML
>     automatically
>   acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus
>     ennumeration generate AML
>   tests: acpi: update expected DSDT after ISA bridge is moved directly
>     under PCI host bridge
>   tests: acpi: whitelist DSDT before generating ICH9_SMB AML
>     automatically
>   acpi: add get_dev_aml_func() helper
>   acpi: enumerate SMB bridge automatically along with other PCI devices
>   tests: acpi: update expected blobs
>   tests: acpi: pc/q35 whitelist DSDT before \_GPE cleanup
>   acpi: pc/35: sanitize _GPE declaration order
>   tests: acpi: update expected blobs
> 
>  hw/display/vga_int.h                  |   2 +
>  include/hw/acpi/acpi_aml_interface.h  |  13 +-
>  hw/display/acpi-vga-stub.c            |   7 ++
>  hw/display/acpi-vga.c                 |  26 ++++
>  hw/display/meson.build                |  17 +++
>  hw/display/vga-pci.c                  |   4 +
>  hw/i386/acpi-build.c                  | 175 +++++---------------------
>  hw/isa/lpc_ich9.c                     |  23 ++++
>  hw/isa/piix3.c                        |  17 ++-
>  tests/data/acpi/pc/DSDT               | Bin 6422 -> 6501 bytes
>  tests/data/acpi/pc/DSDT.acpierst      | Bin 6382 -> 6461 bytes
>  tests/data/acpi/pc/DSDT.acpihmat      | Bin 7747 -> 7826 bytes
>  tests/data/acpi/pc/DSDT.bridge        | Bin 9496 -> 9575 bytes
>  tests/data/acpi/pc/DSDT.cphp          | Bin 6886 -> 6965 bytes
>  tests/data/acpi/pc/DSDT.dimmpxm       | Bin 8076 -> 8155 bytes
>  tests/data/acpi/pc/DSDT.hpbridge      | Bin 6382 -> 6461 bytes
>  tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3107 bytes
>  tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6494 -> 6573 bytes
>  tests/data/acpi/pc/DSDT.memhp         | Bin 7781 -> 7860 bytes
>  tests/data/acpi/pc/DSDT.nohpet        | Bin 6280 -> 6359 bytes
>  tests/data/acpi/pc/DSDT.numamem       | Bin 6428 -> 6507 bytes
>  tests/data/acpi/pc/DSDT.roothp        | Bin 6656 -> 6699 bytes
>  tests/data/acpi/q35/DSDT              | Bin 8320 -> 8412 bytes
>  tests/data/acpi/q35/DSDT.acpierst     | Bin 8337 -> 8429 bytes
>  tests/data/acpi/q35/DSDT.acpihmat     | Bin 9645 -> 9737 bytes
>  tests/data/acpi/q35/DSDT.applesmc     | Bin 8366 -> 8458 bytes
>  tests/data/acpi/q35/DSDT.bridge       | Bin 11449 -> 11541 bytes
>  tests/data/acpi/q35/DSDT.cphp         | Bin 8784 -> 8876 bytes
>  tests/data/acpi/q35/DSDT.cxl          | Bin 9646 -> 9738 bytes
>  tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9974 -> 10066 bytes
>  tests/data/acpi/q35/DSDT.ipmibt       | Bin 8395 -> 8487 bytes
>  tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8409 -> 8500 bytes
>  tests/data/acpi/q35/DSDT.ivrs         | Bin 8337 -> 8429 bytes
>  tests/data/acpi/q35/DSDT.memhp        | Bin 9679 -> 9771 bytes
>  tests/data/acpi/q35/DSDT.mmio64       | Bin 9450 -> 9542 bytes
>  tests/data/acpi/q35/DSDT.multi-bridge | Bin 8640 -> 8732 bytes
>  tests/data/acpi/q35/DSDT.nohpet       | Bin 8178 -> 8270 bytes
>  tests/data/acpi/q35/DSDT.numamem      | Bin 8326 -> 8418 bytes
>  tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8421 -> 8513 bytes
>  tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8926 -> 9018 bytes
>  tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8952 -> 9044 bytes
>  tests/data/acpi/q35/DSDT.viot         | Bin 9429 -> 9521 bytes
>  tests/data/acpi/q35/DSDT.xapic        | Bin 35683 -> 35775 bytes
>  43 files changed, 135 insertions(+), 149 deletions(-)
>  create mode 100644 hw/display/acpi-vga-stub.c
>  create mode 100644 hw/display/acpi-vga.c
>

Michael S. Tsirkin Oct. 27, 2022, 2:18 p.m. UTC | #2

On Thu, Oct 27, 2022 at 02:06:40PM +0200, Igor Mammedov wrote:
> On Mon, 17 Oct 2022 12:21:35 +0200
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > Series continues refactoring started at recently merged [1].
> > It replaces special cases/quirks for ISA/SMB bridges and PCI
> > attached VGA devices with generic AcpiDevAmlIf interface,
> > which allows device to provide its own AML description
> > without need for adhoc plumbing in generic DSDT or PCI
> > enumeration code.
> > 
> > PS:
> > at the end, \_GPE clean up patches which are not part of
> > AcpiDevAmlIf refactoring but iti's still related to PCI,
> > so I've included them there as well.
> 
> 
> ping

it's in my tree, testing found some issues (looks like they are
unrelated to this patchset), debugging.

> > 
> >  1)
> >   https://patchwork.ozlabs.org/project/qemu-devel/list/?series=303856
> > 
> > Igor Mammedov (11):
> >   acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device
> >     descriptors
> >   tests: acpi: whitelist DSDT before generating PCI-ISA bridge AML
> >     automatically
> >   acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus
> >     ennumeration generate AML
> >   tests: acpi: update expected DSDT after ISA bridge is moved directly
> >     under PCI host bridge
> >   tests: acpi: whitelist DSDT before generating ICH9_SMB AML
> >     automatically
> >   acpi: add get_dev_aml_func() helper
> >   acpi: enumerate SMB bridge automatically along with other PCI devices
> >   tests: acpi: update expected blobs
> >   tests: acpi: pc/q35 whitelist DSDT before \_GPE cleanup
> >   acpi: pc/35: sanitize _GPE declaration order
> >   tests: acpi: update expected blobs
> > 
> >  hw/display/vga_int.h                  |   2 +
> >  include/hw/acpi/acpi_aml_interface.h  |  13 +-
> >  hw/display/acpi-vga-stub.c            |   7 ++
> >  hw/display/acpi-vga.c                 |  26 ++++
> >  hw/display/meson.build                |  17 +++
> >  hw/display/vga-pci.c                  |   4 +
> >  hw/i386/acpi-build.c                  | 175 +++++---------------------
> >  hw/isa/lpc_ich9.c                     |  23 ++++
> >  hw/isa/piix3.c                        |  17 ++-
> >  tests/data/acpi/pc/DSDT               | Bin 6422 -> 6501 bytes
> >  tests/data/acpi/pc/DSDT.acpierst      | Bin 6382 -> 6461 bytes
> >  tests/data/acpi/pc/DSDT.acpihmat      | Bin 7747 -> 7826 bytes
> >  tests/data/acpi/pc/DSDT.bridge        | Bin 9496 -> 9575 bytes
> >  tests/data/acpi/pc/DSDT.cphp          | Bin 6886 -> 6965 bytes
> >  tests/data/acpi/pc/DSDT.dimmpxm       | Bin 8076 -> 8155 bytes
> >  tests/data/acpi/pc/DSDT.hpbridge      | Bin 6382 -> 6461 bytes
> >  tests/data/acpi/pc/DSDT.hpbrroot      | Bin 3069 -> 3107 bytes
> >  tests/data/acpi/pc/DSDT.ipmikcs       | Bin 6494 -> 6573 bytes
> >  tests/data/acpi/pc/DSDT.memhp         | Bin 7781 -> 7860 bytes
> >  tests/data/acpi/pc/DSDT.nohpet        | Bin 6280 -> 6359 bytes
> >  tests/data/acpi/pc/DSDT.numamem       | Bin 6428 -> 6507 bytes
> >  tests/data/acpi/pc/DSDT.roothp        | Bin 6656 -> 6699 bytes
> >  tests/data/acpi/q35/DSDT              | Bin 8320 -> 8412 bytes
> >  tests/data/acpi/q35/DSDT.acpierst     | Bin 8337 -> 8429 bytes
> >  tests/data/acpi/q35/DSDT.acpihmat     | Bin 9645 -> 9737 bytes
> >  tests/data/acpi/q35/DSDT.applesmc     | Bin 8366 -> 8458 bytes
> >  tests/data/acpi/q35/DSDT.bridge       | Bin 11449 -> 11541 bytes
> >  tests/data/acpi/q35/DSDT.cphp         | Bin 8784 -> 8876 bytes
> >  tests/data/acpi/q35/DSDT.cxl          | Bin 9646 -> 9738 bytes
> >  tests/data/acpi/q35/DSDT.dimmpxm      | Bin 9974 -> 10066 bytes
> >  tests/data/acpi/q35/DSDT.ipmibt       | Bin 8395 -> 8487 bytes
> >  tests/data/acpi/q35/DSDT.ipmismbus    | Bin 8409 -> 8500 bytes
> >  tests/data/acpi/q35/DSDT.ivrs         | Bin 8337 -> 8429 bytes
> >  tests/data/acpi/q35/DSDT.memhp        | Bin 9679 -> 9771 bytes
> >  tests/data/acpi/q35/DSDT.mmio64       | Bin 9450 -> 9542 bytes
> >  tests/data/acpi/q35/DSDT.multi-bridge | Bin 8640 -> 8732 bytes
> >  tests/data/acpi/q35/DSDT.nohpet       | Bin 8178 -> 8270 bytes
> >  tests/data/acpi/q35/DSDT.numamem      | Bin 8326 -> 8418 bytes
> >  tests/data/acpi/q35/DSDT.pvpanic-isa  | Bin 8421 -> 8513 bytes
> >  tests/data/acpi/q35/DSDT.tis.tpm12    | Bin 8926 -> 9018 bytes
> >  tests/data/acpi/q35/DSDT.tis.tpm2     | Bin 8952 -> 9044 bytes
> >  tests/data/acpi/q35/DSDT.viot         | Bin 9429 -> 9521 bytes
> >  tests/data/acpi/q35/DSDT.xapic        | Bin 35683 -> 35775 bytes
> >  43 files changed, 135 insertions(+), 149 deletions(-)
> >  create mode 100644 hw/display/acpi-vga-stub.c
> >  create mode 100644 hw/display/acpi-vga.c
> >