| Message ID | 1666855893-145-1-git-send-email-yangx.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | RDMA/rxe: Remove the duplicate assignment of mr->map_shift | expand |
On 27/10/2022 15:31, Xiao Yang wrote: > mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init() > and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init(). > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c > index d4f10c2d1aa7..279fac4c21d0 100644 > --- a/drivers/infiniband/sw/rxe/rxe_mr.c > +++ b/drivers/infiniband/sw/rxe/rxe_mr.c > @@ -62,7 +62,6 @@ static void rxe_mr_init(int access, struct rxe_mr *mr) > mr->rkey = mr->ibmr.rkey = rkey; > > mr->state = RXE_MR_STATE_INVALID; > - mr->map_shift = ilog2(RXE_BUF_PER_MAP); Good catch. Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> > } > > static int rxe_mr_alloc(struct rxe_mr *mr, int num_buf)
On Thu, Oct 27, 2022 at 07:31:33AM +0000, Xiao Yang wrote: > mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init() > and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init(). > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 1 - > 1 file changed, 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c index d4f10c2d1aa7..279fac4c21d0 100644 --- a/drivers/infiniband/sw/rxe/rxe_mr.c +++ b/drivers/infiniband/sw/rxe/rxe_mr.c @@ -62,7 +62,6 @@ static void rxe_mr_init(int access, struct rxe_mr *mr) mr->rkey = mr->ibmr.rkey = rkey; mr->state = RXE_MR_STATE_INVALID; - mr->map_shift = ilog2(RXE_BUF_PER_MAP); } static int rxe_mr_alloc(struct rxe_mr *mr, int num_buf)
mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init() and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init(). Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- drivers/infiniband/sw/rxe/rxe_mr.c | 1 - 1 file changed, 1 deletion(-)