mbox series

[net,v4,0/1] net: ethernet: adi: adin1110: Fix notifiers

Message ID 20221027095655.89890-1-alexandru.tachici@analog.com (mailing list archive)
Headers show
Series net: ethernet: adi: adin1110: Fix notifiers | expand

Message

Alexandru Tachici Oct. 27, 2022, 9:56 a.m. UTC 
ADIN1110 was registering netdev_notifiers on each device probe.
This leads to warnings/probe failures because of double registration
of the same notifier when to adin1110/2111 devices are connected to
the same system.

Move the registration of netdev_notifiers in module init call,
in this way multiple driver instances can use the same notifiers.

Alexandru Tachici (1):
  net: ethernet: adi: adin1110: Fix notifiers

Changelog v3 -> v4:
- unregister notifiers in case of spi_register_driver() failure

 drivers/net/ethernet/adi/adin1110.c | 38 ++++++++++++++++++++++-------
 1 file changed, 29 insertions(+), 9 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 29, 2022, 5 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 27 Oct 2022 12:56:54 +0300 you wrote:
> ADIN1110 was registering netdev_notifiers on each device probe.
> This leads to warnings/probe failures because of double registration
> of the same notifier when to adin1110/2111 devices are connected to
> the same system.
> 
> Move the registration of netdev_notifiers in module init call,
> in this way multiple driver instances can use the same notifiers.
> 
> [...]

Here is the summary with links:
  - [net,v4,1/1] net: ethernet: adi: adin1110: Fix notifiers
    https://git.kernel.org/netdev/net/c/21ce2c121fa0

You are awesome, thank you!