| Message ID | 20220816210440.14260-1-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | adc-joystick: add poll-interval | expand |
On Tue, 16 Aug 2022 16:04:37 -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support to the existing adc-joystick driver to support polling > rather than relying on triggered buffers. This is useful for devices > that do not offer triggered buffers in hardware. Code adapted from > changes made by Maya Matuszczyk <maccraft123mc@gmail.com>. > > [...] Applied, thanks! [3/3] arm64: dts: rockchip: Update joystick to polled for OG2 commit: ec3fd1adfda96f42e70dd5f0f69451d642d3598b Best regards,
From: Chris Morgan <macromorgan@hotmail.com> Add support to the existing adc-joystick driver to support polling rather than relying on triggered buffers. This is useful for devices that do not offer triggered buffers in hardware. Code adapted from changes made by Maya Matuszczyk <maccraft123mc@gmail.com>. Changes from V12: - Refactor for 6.0 kernel. This required changing the return routine slightly for the probe function as the input device registration has moved. - Modified error handling for checking the "poll-interval" property. Changes from V11: - Remove additional unnecessary line breaks. Changes from V10: - Removed two unnecessary line breaks. Changes from V9: - Simplified skipping of channel checking logic. - Simplified return logic for driver probe. Changes from V8: - Changed logic for checking channels to skip checking of storagebits. - Changed comment format to comply with Linux style rules. Changes from V7: - Dropped acks from adc-joystick.c changes, as it has been altered somewhat since v7. - Improved checking value of poll-interval to ensure explicit error handling in the event of malformed values. - Adjusted logic to not check for storagebits if polling is in use, which allows adc-joystick to work in polling mode for devices that utilize a mux (such as the Odroid Go Super and the Anbernic RG353). - Changed error message and channel size comparison logic slightly to ensure code can fit within 80 character column width. Changes from V6: - Reverted back to "poll-interval" after mailing list discussion. - Referenced input.yaml for definition of poll-interval in adc-joystick documentation. Changes from V5: - Corrected an error found by yamllint in the documentation. Changes from V4: - Added unit property to devicetree attribute making it now "poll-interval-ms". - Simplified logic for setting polled value and made variable names more clear. Changes from V3: - After lengthy discussion decided to support with existing attribute of "poll-interval". If present, the driver will use polling and if not present, it will use triggered buffers (as the driver does today). - Corrected some lines to honor the 80 character line-limit. - Check return value from polling method and return early if there is an error reading the data. Changes from V2: - Changed parameter from "adc-joystick,polled" to "adc-joystick,no-hardware-trigger" as it is more representative of what the driver and hardware are doing. Changes from V1: - Removed driver compatible string of "adc-joystick-polled". - Added new optional boolean value of "adc-joystick,polled". - Cleaned up if statements regarding polling behavior. Chris Morgan (3): dt-bindings: adc-joystick: add poll-interval input: adc-joystick - Add polled input device support arm64: dts: rockchip: Update joystick to polled for OG2 .../bindings/input/adc-joystick.yaml | 5 ++ .../boot/dts/rockchip/rk3326-odroid-go2.dts | 1 + drivers/input/joystick/adc-joystick.c | 48 +++++++++++++++++-- 3 files changed, 51 insertions(+), 3 deletions(-)