bpf: Remove the obsolte u64_stats_fetch_*_irq() users.

Commit Message

Sebastian Sewior Oct. 26, 2022, 12:31 p.m. UTC

From: Thomas Gleixner <[e-mail]>

Now that the 32bit UP oddity is gone and 32bit uses always a sequence
count, there is no need for the fetch_irq() variants anymore.

Convert to the regular interface.

Cc: Alexei Starovoitov <[e-mail]>
Cc: Andrii Nakryiko <[e-mail]>
Cc: Daniel Borkmann <[e-mail]>
Cc: Hao Luo <[e-mail]>
Cc: Jiri Olsa <[e-mail]>
Cc: John Fastabend <[e-mail]>
Cc: KP Singh <[e-mail]>
Cc: Martin KaFai Lau <[e-mail]>
Cc: Song Liu <[e-mail]>
Cc: Stanislav Fomichev <[e-mail]>
Cc: Yonghong Song <[e-mail]>
Cc: [e-mail]
Signed-off-by: Thomas Gleixner <[e-mail]>
Signed-off-by: Sebastian Andrzej Siewior <[e-mail]>
Acked-by: Peter Zijlstra (Intel) <[e-mail]>
---
 kernel/bpf/syscall.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

[e-mail] Oct. 31, 2022, 10:50 p.m. UTC | #1

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[e-mail]>:

On Wed, 26 Oct 2022 14:31:10 +0200 you wrote:
> From: Thomas Gleixner <[e-mail]>
> 
> Now that the 32bit UP oddity is gone and 32bit uses always a sequence
> count, there is no need for the fetch_irq() variants anymore.
> 
> Convert to the regular interface.
> 
> [...]

Here is the summary with links:
  - bpf: Remove the obsolte u64_stats_fetch_*_irq() users.
    https://git.kernel.org/bpf/bpf-next/c/97c4090badca

You are awesome, thank you!

Patch

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 7b373a5e861f4..71d8eb131928d 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -2117,11 +2117,11 @@  static void bpf_prog_get_stats(const struct bpf_prog *prog,
 
 		st = per_cpu_ptr(prog->stats, cpu);
 		do {
-			start = u64_stats_fetch_begin_irq(&st->syncp);
+			start = u64_stats_fetch_begin(&st->syncp);
 			tnsecs = u64_stats_read(&st->nsecs);
 			tcnt = u64_stats_read(&st->cnt);
 			tmisses = u64_stats_read(&st->misses);
-		} while (u64_stats_fetch_retry_irq(&st->syncp, start));
+		} while (u64_stats_fetch_retry(&st->syncp, start));
 		nsecs += tnsecs;
 		cnt += tcnt;
 		misses += tmisses;