| Message ID | 20221028231309.565451-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: mfd: Expect specific type for monitored-battery | expand |
On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > Core schema does not define type of monitored-battery, so the schemas > are expected to reference proper type. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) Applied, thanks.
On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > Core schema does not define type of monitored-battery, so the schemas > > are expected to reference proper type. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > 2 files changed, 4 insertions(+), 1 deletion(-) > > Applied, thanks. NAK. Please drop or revert. Rob
On Mon, 31 Oct 2022, Rob Herring wrote: > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > Core schema does not define type of monitored-battery, so the schemas > > > are expected to reference proper type. > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > Applied, thanks. > > NAK. Please drop or revert. Dropping is not a problem. Would you mind providing some context?
On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote: > > On Mon, 31 Oct 2022, Rob Herring wrote: > > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > > > Core schema does not define type of monitored-battery, so the schemas > > > > are expected to reference proper type. > > > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > NAK. Please drop or revert. > > Dropping is not a problem. > > Would you mind providing some context? I did elsewhere in the series, but simply we don't want to define a type for a property multiple times. It should be defined once somewhere common. Rob
On Tue, 01 Nov 2022, Rob Herring wrote: > On Tue, Nov 1, 2022 at 5:25 AM Lee Jones <lee@kernel.org> wrote: > > > > On Mon, 31 Oct 2022, Rob Herring wrote: > > > > > On Mon, Oct 31, 2022 at 08:49:56AM +0000, Lee Jones wrote: > > > > On Fri, 28 Oct 2022, Krzysztof Kozlowski wrote: > > > > > > > > > Core schema does not define type of monitored-battery, so the schemas > > > > > are expected to reference proper type. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > --- > > > > > Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- > > > > > Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + > > > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > > > Applied, thanks. > > > > > > NAK. Please drop or revert. > > > > Dropping is not a problem. > > > > Would you mind providing some context? > > I did elsewhere in the series, but simply we don't want to define a > type for a property multiple times. It should be defined once > somewhere common. ACK, thanks. Dropped.
diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml index 06ed9ec8f4bb..b4c6f9529ce1 100644 --- a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml @@ -22,7 +22,9 @@ properties: reg: maxItems: 1 - monitored-battery: true + monitored-battery: + $ref: /schemas/types.yaml#/definitions/phandle + power-supplies: true system-power-controller: true diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml index 935e17099213..d136a05c7758 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml @@ -126,6 +126,7 @@ properties: type: object properties: monitored-battery: + $ref: /schemas/types.yaml#/definitions/phandle description: | A phandle to a monitored battery node that contains a valid value for:
Core schema does not define type of monitored-battery, so the schemas are expected to reference proper type. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/mfd/ene-kb930.yaml | 4 +++- Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)