| Message ID | 1663133102-10671-1-git-send-email-quic_deesin@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rpmsg signaling/flowcontrol patches | expand |
Hi Deepak, On 9/14/22 07:24, Deepak Kumar Singh wrote: > [Changes from V2]: > Trivial review comment fixes. > Avoid TIOCM_DTR etc signals in glink layer, use native signal macros only. > Glink layer to provide only flowcontrol on/off interface, no specific signal passing/receiving to client. Please, could you have a look to my series that implements your proposed interface for the virtio rpmsg [1]? It would be nice that your API takes into account update to support of the rpmsg virtio implementation proposed in [08/10] rpmsg: Add the destination address in rpmsg_set_flow_control[2] Thanks, Arnaud [1] https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/ [2]https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/#m7340a8e70fb0d8935869c4cef96863abda555c96 > > Deepak Kumar Singh (3): > rpmsg: core: Add signal API support > rpmsg: glink: Add support to handle signals command > rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support > > drivers/rpmsg/qcom_glink_native.c | 63 +++++++++++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_char.c | 60 ++++++++++++++++++++++++++++++++----- > drivers/rpmsg/rpmsg_core.c | 20 +++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 2 ++ > include/linux/rpmsg.h | 15 ++++++++++ > 5 files changed, 152 insertions(+), 8 deletions(-) >
On Wed, Sep 14, 2022 at 09:50:48AM +0200, Arnaud POULIQUEN wrote: > Hi Deepak, > > On 9/14/22 07:24, Deepak Kumar Singh wrote: > > [Changes from V2]: > > Trivial review comment fixes. > > Avoid TIOCM_DTR etc signals in glink layer, use native signal macros only. > > Glink layer to provide only flowcontrol on/off interface, no specific signal passing/receiving to client. > > > Please, could you have a look to my series that implements > your proposed interface for the virtio rpmsg [1]? > It would be nice that your API takes into account update to > support of the rpmsg virtio implementation proposed in [08/10] rpmsg: Add the > destination address in rpmsg_set_flow_control[2] I agree with Arnaud - I would like to see more convergence on this topic. I will not move forward with this patchset until comments have been provided for [1]. > > Thanks, > Arnaud > > [1] https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/ > [2]https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/#m7340a8e70fb0d8935869c4cef96863abda555c96 > > > > > Deepak Kumar Singh (3): > > rpmsg: core: Add signal API support > > rpmsg: glink: Add support to handle signals command > > rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support > > > > drivers/rpmsg/qcom_glink_native.c | 63 +++++++++++++++++++++++++++++++++++++++ > > drivers/rpmsg/rpmsg_char.c | 60 ++++++++++++++++++++++++++++++++----- > > drivers/rpmsg/rpmsg_core.c | 20 +++++++++++++ > > drivers/rpmsg/rpmsg_internal.h | 2 ++ > > include/linux/rpmsg.h | 15 ++++++++++ > > 5 files changed, 152 insertions(+), 8 deletions(-) > >
On Wed, Sep 14, 2022 at 09:50:48AM +0200, Arnaud POULIQUEN wrote: > Hi Deepak, > > On 9/14/22 07:24, Deepak Kumar Singh wrote: > > [Changes from V2]: > > Trivial review comment fixes. > > Avoid TIOCM_DTR etc signals in glink layer, use native signal macros only. > > Glink layer to provide only flowcontrol on/off interface, no specific signal passing/receiving to client. > > > Please, could you have a look to my series that implements > your proposed interface for the virtio rpmsg [1]? > It would be nice that your API takes into account update to > support of the rpmsg virtio implementation proposed in [08/10] rpmsg: Add the > destination address in rpmsg_set_flow_control[2] > Your proposal seems reasonable Arnaud, for virtio it makes sense to provide the destination address in the API as well. It's a kernel-internal API so we could change it, but let's try to avoid that by adding the address from the start. Regards, Bjorn > Thanks, > Arnaud > > [1] https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/ > [2]https://lore.kernel.org/lkml/e54bcfcb-8e37-9caa-b330-a7411820b7ce@foss.st.com/T/#m7340a8e70fb0d8935869c4cef96863abda555c96 > > > > > Deepak Kumar Singh (3): > > rpmsg: core: Add signal API support > > rpmsg: glink: Add support to handle signals command > > rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support > > > > drivers/rpmsg/qcom_glink_native.c | 63 +++++++++++++++++++++++++++++++++++++++ > > drivers/rpmsg/rpmsg_char.c | 60 ++++++++++++++++++++++++++++++++----- > > drivers/rpmsg/rpmsg_core.c | 20 +++++++++++++ > > drivers/rpmsg/rpmsg_internal.h | 2 ++ > > include/linux/rpmsg.h | 15 ++++++++++ > > 5 files changed, 152 insertions(+), 8 deletions(-) > >