| Message ID | 20221102054115.1849736-1-saproj@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cbd784424577a6df7a7592e9904a22b5c5d599b7 |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [ethtool] fix a warning when compiling for 32-bit | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to ethtool/ethtool.git (master) by Michal Kubecek <mkubecek@suse.cz>: On Wed, 2 Nov 2022 08:41:15 +0300 you wrote: > Since BNXT_PCIE_STATS_LEN is size_t: > > ../../ethtool/bnxt.c:66:68: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=] > 66 | fprintf(stdout, "Length is too short, expected 0x%lx\n", > | ~~^ > | | > | long unsigned int > | %x > > [...] Here is the summary with links: - [ethtool] fix a warning when compiling for 32-bit https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=cbd784424577 You are awesome, thank you!
diff --git a/bnxt.c b/bnxt.c index b46db726d1c5..2b0ac7646b2b 100644 --- a/bnxt.c +++ b/bnxt.c @@ -63,7 +63,7 @@ int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r return 0; if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) { - fprintf(stdout, "Length is too short, expected 0x%lx\n", + fprintf(stdout, "Length is too short, expected 0x%zx\n", BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN); return -1; }
Since BNXT_PCIE_STATS_LEN is size_t: ../../ethtool/bnxt.c:66:68: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=] 66 | fprintf(stdout, "Length is too short, expected 0x%lx\n", | ~~^ | | | long unsigned int | %x Signed-off-by: Sergei Antonov <saproj@gmail.com> --- bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)