mbox series

[v2,0/5] Add PWM for MStar SoCs

Message ID 20220907131241.31941-1-romain.perier@gmail.com (mailing list archive)
Headers show
Series Add PWM for MStar SoCs | expand

Message

Romain Perier Sept. 7, 2022, 1:12 p.m. UTC
This patches series adds a new driver for the PWM found in the Mstar
MSC313e SoCs and newer. It adds a basic pwm driver, the corresponding
devicetree bindings and its documentation.

Changes since v1:
- Fixed commit message for the dt-bindings doc
- Removed "OneOf" from the dt-bindings doc
- Re-ordered alphabetically in Kconfig and remove
  unseless empty lines
- Explain and adds comment in _writecounter() (hw
  constrainst)
- Reworked the msc313e_pwm_config() function
- Fixed clk handling
- Removed extra callbacks, only keep .apply and .get_state
- Implement .get_state completly, this fixes the driver with PWM_DEBUG
  (the whole driver has been tested with PWM_DEBUG).
- Dropped useless lines in _probe
- I have kept regmap_field() because it is more clean and helpful, it
  avoids to do too much of offset and mask and shift all over the place.

Daniel Palmer (1):
  pwm: Add support for the MSTAR MSC313 PWM

Romain Perier (4):
  dt-bindings: pwm: Add Mstar MSC313e PWM devicetree bindings
    documentation
  ARM: dts: mstar: Add pwm device node to infinity
  ARM: dts: mstar: Add pwm device node to infinity3
  ARM: dts: mstar: Add pwm device node to infinity2m

 .../bindings/pwm/mstar,msc313e-pwm.yaml       |  46 +++
 MAINTAINERS                                   |   1 +
 arch/arm/boot/dts/mstar-infinity.dtsi         |  10 +
 arch/arm/boot/dts/mstar-infinity2m.dtsi       |   8 +
 arch/arm/boot/dts/mstar-infinity3.dtsi        |  10 +
 drivers/pwm/Kconfig                           |  10 +
 drivers/pwm/Makefile                          |   1 +
 drivers/pwm/pwm-msc313e.c                     | 269 ++++++++++++++++++
 8 files changed, 355 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml
 create mode 100644 drivers/pwm/pwm-msc313e.c

Comments

Romain Perier Sept. 27, 2022, 6:41 a.m. UTC | #1
ping ;)

Regards,

Le mer. 7 sept. 2022 à 15:12, Romain Perier <romain.perier@gmail.com> a écrit :
>
> This patches series adds a new driver for the PWM found in the Mstar
> MSC313e SoCs and newer. It adds a basic pwm driver, the corresponding
> devicetree bindings and its documentation.
>
> Changes since v1:
> - Fixed commit message for the dt-bindings doc
> - Removed "OneOf" from the dt-bindings doc
> - Re-ordered alphabetically in Kconfig and remove
>   unseless empty lines
> - Explain and adds comment in _writecounter() (hw
>   constrainst)
> - Reworked the msc313e_pwm_config() function
> - Fixed clk handling
> - Removed extra callbacks, only keep .apply and .get_state
> - Implement .get_state completly, this fixes the driver with PWM_DEBUG
>   (the whole driver has been tested with PWM_DEBUG).
> - Dropped useless lines in _probe
> - I have kept regmap_field() because it is more clean and helpful, it
>   avoids to do too much of offset and mask and shift all over the place.
>
> Daniel Palmer (1):
>   pwm: Add support for the MSTAR MSC313 PWM
>
> Romain Perier (4):
>   dt-bindings: pwm: Add Mstar MSC313e PWM devicetree bindings
>     documentation
>   ARM: dts: mstar: Add pwm device node to infinity
>   ARM: dts: mstar: Add pwm device node to infinity3
>   ARM: dts: mstar: Add pwm device node to infinity2m
>
>  .../bindings/pwm/mstar,msc313e-pwm.yaml       |  46 +++
>  MAINTAINERS                                   |   1 +
>  arch/arm/boot/dts/mstar-infinity.dtsi         |  10 +
>  arch/arm/boot/dts/mstar-infinity2m.dtsi       |   8 +
>  arch/arm/boot/dts/mstar-infinity3.dtsi        |  10 +
>  drivers/pwm/Kconfig                           |  10 +
>  drivers/pwm/Makefile                          |   1 +
>  drivers/pwm/pwm-msc313e.c                     | 269 ++++++++++++++++++
>  8 files changed, 355 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/mstar,msc313e-pwm.yaml
>  create mode 100644 drivers/pwm/pwm-msc313e.c
>
> --
> 2.35.1
>
Krzysztof Kozlowski Oct. 28, 2022, 11:32 p.m. UTC | #2
On 27/09/2022 02:41, Romain Perier wrote:
> ping ;)
> 

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

Best regards,
Krzysztof
Krzysztof Kozlowski Nov. 2, 2022, 2:06 p.m. UTC | #3
On 29/10/2022 03:48, Romain Perier wrote:
> Hi
> 
> This is what I already do and what I do for every patch series, usually ^^
> And I send To: the maintainers and everyone else in Cc: , as the process or
> other maintainers suggest.
> 
> The command was run on 6.0 for the first v1 I think .
> 
> I have forgot something ?

You forgot to Cc at least me. I did not check other missing entries.

Best regards,
Krzysztof