| Message ID | 20220718122328.251602-1-jpanis@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | AM62x watchdog support | expand |
Hi Julien! On July 18, 2022 thus sayeth Julien Panis: > This patch series adds support for AM62x watchdog. > > Changes since v0: > - Mark MCU & WKUP watchdogs as reserved > > Julien Panis (2): > arm64: dts: ti: k3-am62: add watchdog nodes > arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved > > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++ > 4 files changed, 73 insertions(+) > These patches look great to me! Reviewed-by: Bryan Brattlof <bb@ti.com> ~Bryan
On 14:23-20220718, Julien Panis wrote: > This patch series adds support for AM62x watchdog. > > Changes since v0: > - Mark MCU & WKUP watchdogs as reserved > > Julien Panis (2): > arm64: dts: ti: k3-am62: add watchdog nodes > arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved > > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 45 ++++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 9 +++++ > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 9 +++++ > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 +++++ > 4 files changed, 73 insertions(+) > Could you rebase the series to the latest next? Also, cosmetics: a) Patches are of the order [PATCH] indicating v1, [PATCH V2] indicating v2 etc.. Also when sending subsequent versions, it is a good practise to keep links (typically lore or patchworks) to the previous versions of the patches along with change log. See comments such as [1]. Change logs and lore links help new reviewers quickly catchup on the discussions so far. b) please keep lkml in CC. [1] https://lore.kernel.org/all/Y1+q2Usm9ecicXqp@google.com/