| Message ID | 20221102164005.2516646-3-dlatypov@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 101e32a025da386ba6f6efbfe3e75b6ec5a358aa |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | [1/3] kunit: tool: make TestCounts a dataclass | expand |
On Thu, Nov 3, 2022 at 12:40 AM Daniel Latypov <dlatypov@google.com> wrote: > > We're using a `with` block above, so the file object is already closed. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> > --- Nice catch. Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > tools/testing/kunit/kunit_tool_test.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py > index 0063773c0fc4..c41567eaf3c3 100755 > --- a/tools/testing/kunit/kunit_tool_test.py > +++ b/tools/testing/kunit/kunit_tool_test.py > @@ -239,8 +239,6 @@ class KUnitParserTest(unittest.TestCase): > self.assertEqual( > "example", > result.subtests[1].name) > - file.close() > - > > def test_ignores_prefix_printk_time(self): > prefix_log = test_data_path('test_config_printk_time.log') > -- > 2.38.1.273.g43a17bfeac-goog >
diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index 0063773c0fc4..c41567eaf3c3 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -239,8 +239,6 @@ class KUnitParserTest(unittest.TestCase): self.assertEqual( "example", result.subtests[1].name) - file.close() - def test_ignores_prefix_printk_time(self): prefix_log = test_data_path('test_config_printk_time.log')
We're using a `with` block above, so the file object is already closed. Signed-off-by: Daniel Latypov <dlatypov@google.com> --- tools/testing/kunit/kunit_tool_test.py | 2 -- 1 file changed, 2 deletions(-)