| Message ID | 20221104135036.225628-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | iwlegacy: remove redundant variable len | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Colin Ian King <colin.i.king@gmail.com> writes: > Variable len is being assigned and modified but it is never > used. The variable is redundant and can be removed. > > Cleans up clang scan build warning: > warning: variable 'len' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> For future wireless patches please add "wifi: " to the subject. I can edit the subject during commit so no need to resend.
On 04/11/2022 17:32, Kalle Valo wrote: > Colin Ian King <colin.i.king@gmail.com> writes: > >> Variable len is being assigned and modified but it is never >> used. The variable is redundant and can be removed. >> >> Cleans up clang scan build warning: >> warning: variable 'len' set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > For future wireless patches please add "wifi: " to the subject. I can > edit the subject during commit so no need to resend. > OK, will try to remember to do that. Thanks for handling the $SUBJECT Colin
On Fri, Nov 04, 2022 at 01:50:36PM +0000, Colin Ian King wrote: > Variable len is being assigned and modified but it is never > used. The variable is redundant and can be removed. > > Cleans up clang scan build warning: > warning: variable 'len' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Colin Ian King <colin.i.king@gmail.com> wrote: > Variable len is being assigned and modified but it is never > used. The variable is redundant and can be removed. > > Cleans up clang scan build warning: > warning: variable 'len' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > Acked-by: Stanislaw Gruszka <stf_xl@wp.pl> Patch applied to wireless-next.git, thanks. 9db485ce098f wifi: iwlegacy: remove redundant variable len
diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c index 7352d5b2095f..429952871976 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c @@ -1202,8 +1202,6 @@ il3945_rx_handle(struct il_priv *il) D_RX("r = %d, i = %d\n", r, i); while (i != r) { - int len; - rxb = rxq->queue[i]; /* If an RXB doesn't have a Rx queue slot associated with it, @@ -1217,10 +1215,6 @@ il3945_rx_handle(struct il_priv *il) PAGE_SIZE << il->hw_params.rx_page_order, DMA_FROM_DEVICE); pkt = rxb_addr(rxb); - - len = le32_to_cpu(pkt->len_n_flags) & IL_RX_FRAME_SIZE_MSK; - len += sizeof(u32); /* account for status word */ - reclaim = il_need_reclaim(il, pkt); /* Based on type of command response or notification,
Variable len is being assigned and modified but it is never used. The variable is redundant and can be removed. Cleans up clang scan build warning: warning: variable 'len' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 6 ------ 1 file changed, 6 deletions(-)