| Message ID | 20221104045204.746124-4-colin.foster@in-advantage.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-binding preparation for ocelot switches | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 19 of 19 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Thu, Nov 03, 2022 at 09:52:01PM -0700, Colin Foster wrote: > dsa.yaml contains a reference to dsa-port.yaml, so a duplicate reference to > the binding isn't necessary. Remove this unnecessary reference. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > > v1 -> v2 > * Add Reviewed-by > > --- > Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index f2e9ff3f580b..81f291105660 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -159,8 +159,6 @@ patternProperties: > type: object > description: Ethernet switch ports > > - unevaluatedProperties: false > - You just allowed this node to have any property. > properties: > reg: > description: > @@ -168,7 +166,6 @@ patternProperties: > for user ports. > > allOf: > - - $ref: dsa-port.yaml# > - if: > required: [ ethernet ] > then: > -- > 2.25.1 > >
Hi Rob, On Fri, Nov 04, 2022 at 01:53:43PM -0500, Rob Herring wrote: > On Thu, Nov 03, 2022 at 09:52:01PM -0700, Colin Foster wrote: > > dsa.yaml contains a reference to dsa-port.yaml, so a duplicate reference to > > the binding isn't necessary. Remove this unnecessary reference. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > Suggested-by: Vladimir Oltean <olteanv@gmail.com> > > Reviewed-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > --- > > > > v1 -> v2 > > * Add Reviewed-by > > > > --- > > Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > index f2e9ff3f580b..81f291105660 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > @@ -159,8 +159,6 @@ patternProperties: > > type: object > > description: Ethernet switch ports > > > > - unevaluatedProperties: false > > - > > You just allowed this node to have any property. I appreciate your time and help. Thank you. In this case, I think I need "unevaluatedProperties: true" so that the ^(ethernet-)?port node can get the properties it needs from nodes in dsa... ? But then I'm not sure how this node worked in the first place. I might have misunderstood, but I thought you suggested that if this node had unevaluatedProperties: false, it wouldn't be able to look into dsa-port. On the other hand, you did include a lot more information in your response to 0/6 of this set, which I have yet to fully absorb. > > > properties: > > reg: > > description: > > @@ -168,7 +166,6 @@ patternProperties: > > for user ports. > > > > allOf: > > - - $ref: dsa-port.yaml# > > - if: > > required: [ ethernet ] > > then: > > -- > > 2.25.1 > > > >
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index f2e9ff3f580b..81f291105660 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -159,8 +159,6 @@ patternProperties: type: object description: Ethernet switch ports - unevaluatedProperties: false - properties: reg: description: @@ -168,7 +166,6 @@ patternProperties: for user ports. allOf: - - $ref: dsa-port.yaml# - if: required: [ ethernet ] then: