diff mbox series

dt-bindings: thermal: cooling-devices: Add missing cache related properties

Message ID 20221104162450.1982114-1-robh@kernel.org (mailing list archive)
State New, archived
Delegated to: Daniel Lezcano
Headers show
Series dt-bindings: thermal: cooling-devices: Add missing cache related properties | expand

Commit Message

Rob Herring (Arm) Nov. 4, 2022, 4:24 p.m. UTC
The examples' cache nodes are incomplete as 'cache-unified' and
'cache-level' are required cache properties.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski Nov. 6, 2022, 10:32 a.m. UTC | #1
On 04/11/2022 17:24, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Amit Kucheria Nov. 6, 2022, 5:53 p.m. UTC | #2
On Fri, Nov 4, 2022 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
>
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Amit Kucheria <amitk@kernel.org>

> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> index 850a9841b110..7bb9327caa13 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -76,9 +76,13 @@ examples:
>                      next-level-cache = <&L2_0>;
>                      L2_0: l2-cache {
>                              compatible = "cache";
> +                            cache-unified;
> +                            cache-level = <2>;
>                              next-level-cache = <&L3_0>;
>                              L3_0: l3-cache {
>                                      compatible = "cache";
> +                                    cache-unified;
> +                                    cache-level = <3>;
>                              };
>                      };
>            };
> --
> 2.35.1
>
Rob Herring (Arm) Dec. 6, 2022, 1:34 a.m. UTC | #3
On Fri, 04 Nov 2022 11:24:50 -0500, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Applied, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
index 850a9841b110..7bb9327caa13 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
@@ -76,9 +76,13 @@  examples:
                     next-level-cache = <&L2_0>;
                     L2_0: l2-cache {
                             compatible = "cache";
+                            cache-unified;
+                            cache-level = <2>;
                             next-level-cache = <&L3_0>;
                             L3_0: l3-cache {
                                     compatible = "cache";
+                                    cache-unified;
+                                    cache-level = <3>;
                             };
                     };
           };