| Message ID | 20221103090905.284567-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 85cbaf032d3cd9f595152625eda5d4ecb1d6d78d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] hamradio: fix issue of dev reference count leakage in bpq_device_event() | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 3 Nov 2022 17:09:05 +0800 you wrote: > When following tests are performed, it will cause dev reference counting > leakage. > a)ip link add bond2 type bond mode balance-rr > b)ip link set bond2 up > c)ifenslave -f bond2 rose1 > d)ip link del bond2 > > [...] Here is the summary with links: - [net] hamradio: fix issue of dev reference count leakage in bpq_device_event() https://git.kernel.org/netdev/net/c/85cbaf032d3c You are awesome, thank you!
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c index 30af0081e2be..83a16d10eedb 100644 --- a/drivers/net/hamradio/bpqether.c +++ b/drivers/net/hamradio/bpqether.c @@ -533,7 +533,7 @@ static int bpq_device_event(struct notifier_block *this, if (!net_eq(dev_net(dev), &init_net)) return NOTIFY_DONE; - if (!dev_is_ethdev(dev)) + if (!dev_is_ethdev(dev) && !bpq_get_ax25_dev(dev)) return NOTIFY_DONE; switch (event) {
When following tests are performed, it will cause dev reference counting leakage. a)ip link add bond2 type bond mode balance-rr b)ip link set bond2 up c)ifenslave -f bond2 rose1 d)ip link del bond2 When new bond device is created, the default type of the bond device is ether. And the bond device is up, bpq_device_event() receives the message and creates a new bpq device. In this case, the reference count value of dev is hold once. But after "ifenslave -f bond2 rose1" command is executed, the type of the bond device is changed to rose. When the bond device is unregistered, bpq_device_event() will not put the dev reference count. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- drivers/net/hamradio/bpqether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)