| Message ID | 20220919-v3-6-a803f2660127@baylibre.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add MT8195 HDMI support | expand |
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: > Add a flag to indicate support for frame colorimetry. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++++++++++ > drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > index 3635ca66817b..933c51b5f6d7 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > @@ -120,6 +120,17 @@ int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz > return err; > } > > + if (hdmi->conf->has_frame_colorimetry) { > + frame.colorimetry = hdmi->colorimtery; Typo: s/colorimtery/colorimetry/g ...also, I don't see this being really used? In hdmi-v2 you're setting this param to HDMI_COLORIMETRY_NONE and quantization ranges to always the same default value. I wonder if this is really needed at this point. Regards, Angelo
On Mon, 07 Nov 2022 12:09, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: >Il 04/11/22 15:09, Guillaume Ranquet ha scritto: >> Add a flag to indicate support for frame colorimetry. >> >> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >> --- >> drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++++++++++ >> drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + >> 2 files changed, 12 insertions(+) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> index 3635ca66817b..933c51b5f6d7 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> @@ -120,6 +120,17 @@ int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz >> return err; >> } >> >> + if (hdmi->conf->has_frame_colorimetry) { >> + frame.colorimetry = hdmi->colorimtery; > >Typo: s/colorimtery/colorimetry/g > >...also, I don't see this being really used? In hdmi-v2 you're setting this param >to HDMI_COLORIMETRY_NONE and quantization ranges to always the same default value. > >I wonder if this is really needed at this point. > >Regards, >Angelo I'll see if I can make something work without this boolean. Thx, Guillaume.
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c index 3635ca66817b..933c51b5f6d7 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c @@ -120,6 +120,17 @@ int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz return err; } + if (hdmi->conf->has_frame_colorimetry) { + frame.colorimetry = hdmi->colorimtery; + if (frame.colorimetry == HDMI_COLORIMETRY_EXTENDED) + frame.extended_colorimetry = hdmi->extended_colorimetry; + + /* quantiation range:limited or full */ + if (frame.colorspace == HDMI_COLORSPACE_RGB) + frame.quantization_range = hdmi->quantization_range; + else + frame.ycc_quantization_range = hdmi->ycc_quantization_range; + } err = hdmi_avi_infoframe_pack(&frame, buffer, bufsz); if (err < 0) { diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.h b/drivers/gpu/drm/mediatek/mtk_hdmi_common.h index 921bde150e11..2e8e5feec377 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.h +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.h @@ -32,6 +32,7 @@ struct mtk_hdmi_conf { bool tz_disabled; bool cea_modes_only; bool has_cec; + bool has_frame_colorimetry; unsigned long max_mode_clock; const struct drm_bridge_funcs *bridge_funcs; void (*mtk_hdmi_output_init)(struct mtk_hdmi *hdmi);
Add a flag to indicate support for frame colorimetry. Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> --- drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++++++++++ drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + 2 files changed, 12 insertions(+)