[v3,0/6] Add Auxiliary driver support

Message

Ajit Khaparde Nov. 4, 2022, 4:27 p.m. UTC

Add auxiliary device driver for Broadcom devices.
The bnxt_en driver will register and initialize an aux device
if RDMA is enabled in the underlying device.
The bnxt_re driver will then probe and initialize the
RoCE interfaces with the infiniband stack.

v1->v2:
- Incorporated review comments including usage of ulp_id &
  complex function indirections.
- Used function calls provided by the auxiliary bus interface
  instead of proprietary calls.
- Refactor code to remove ROCE driver's access to bnxt structure.

v2->v3:
- Addressed review comments including cleanup of some unnecessary wrappers
- Fixed warnings seen during cross compilation

Please apply. Thanks.

Ajit Khaparde (5):
  bnxt_en: Add auxiliary driver support
  RDMA/bnxt_re: Use auxiliary driver interface
  bnxt_en: Remove usage of ulp_id
  bnxt_en: Use direct API instead of indirection
  bnxt_en: Use auxiliary bus calls over proprietary calls

Hongguang Gao (1):
  bnxt_en: Remove struct bnxt access from RoCE driver

 drivers/infiniband/hw/bnxt_re/bnxt_re.h       |   9 +-
 drivers/infiniband/hw/bnxt_re/main.c          | 578 +++++++-----------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  10 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |   8 +
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 399 ++++++------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |  49 +-
 6 files changed, 480 insertions(+), 573 deletions(-)

Comments

Leon Romanovsky Nov. 7, 2022, 6:37 a.m. UTC | #1

On Fri, Nov 04, 2022 at 09:27:27AM -0700, Ajit Khaparde wrote:
> Add auxiliary device driver for Broadcom devices.
> The bnxt_en driver will register and initialize an aux device
> if RDMA is enabled in the underlying device.
> The bnxt_re driver will then probe and initialize the
> RoCE interfaces with the infiniband stack.
> 
> v1->v2:
> - Incorporated review comments including usage of ulp_id &
>   complex function indirections.
> - Used function calls provided by the auxiliary bus interface
>   instead of proprietary calls.
> - Refactor code to remove ROCE driver's access to bnxt structure.
> 
> v2->v3:
> - Addressed review comments including cleanup of some unnecessary wrappers
> - Fixed warnings seen during cross compilation
> 
> Please apply. Thanks.

Please send this series as standalone one and not as a reply
to previous discussion. Reply-to messes review flow, especially
for series.

Jakub, I'll review it once Ajit will send it properly.

Thanks

Jakub Kicinski Nov. 7, 2022, 4:06 p.m. UTC | #2

On Mon, 7 Nov 2022 08:37:13 +0200 Leon Romanovsky wrote:
> Please send this series as standalone one and not as a reply
> to previous discussion. Reply-to messes review flow, especially
> for series.
> 
> Jakub, I'll review it once Ajit will send it properly.

IIUC we wait for you or Jason to review any of the RoCE bifurcation
patches before considering them for inclusion.

Leon Romanovsky Nov. 7, 2022, 5:26 p.m. UTC | #3

On Mon, Nov 07, 2022 at 08:06:05AM -0800, Jakub Kicinski wrote:
> On Mon, 7 Nov 2022 08:37:13 +0200 Leon Romanovsky wrote:
> > Please send this series as standalone one and not as a reply
> > to previous discussion. Reply-to messes review flow, especially
> > for series.
> > 
> > Jakub, I'll review it once Ajit will send it properly.
> 
> IIUC we wait for you or Jason to review any of the RoCE bifurcation
> patches before considering them for inclusion.

Thanks

Ajit Khaparde Nov. 7, 2022, 6:21 p.m. UTC | #4

On Sun, Nov 6, 2022 at 10:37 PM Leon Romanovsky <[e-mail]> wrote:
>
> On Fri, Nov 04, 2022 at 09:27:27AM -0700, Ajit Khaparde wrote:
> > Add auxiliary device driver for Broadcom devices.
> > The bnxt_en driver will register and initialize an aux device
> > if RDMA is enabled in the underlying device.
> > The bnxt_re driver will then probe and initialize the
> > RoCE interfaces with the infiniband stack.
> >
> > v1->v2:
> > - Incorporated review comments including usage of ulp_id &
> >   complex function indirections.
> > - Used function calls provided by the auxiliary bus interface
> >   instead of proprietary calls.
> > - Refactor code to remove ROCE driver's access to bnxt structure.
> >
> > v2->v3:
> > - Addressed review comments including cleanup of some unnecessary wrappers
> > - Fixed warnings seen during cross compilation
> >
> > Please apply. Thanks.
>
> Please send this series as standalone one and not as a reply
> to previous discussion. Reply-to messes review flow, especially
> for series.
ACK.

>
> Jakub, I'll review it once Ajit will send it properly.
>
> Thanks