diff mbox series

[RFC,v1,1/3] liburing: add api to set napi busy poll timeout

Message ID 20221103204017.670757-2-shr@devkernel.io (mailing list archive)
State New
Headers show
Series liburing: add api for napi busy poll timeout | expand

Commit Message

Stefan Roesch Nov. 3, 2022, 8:40 p.m. UTC
This adds the two functions to register and unregister the napi busy
poll timeout:
- io_uring_register_busy_poll_timeout
- io_uring_unregister_busy_poll_timeout

Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
 src/include/liburing.h          |  3 +++
 src/include/liburing/io_uring.h |  4 ++++
 src/register.c                  | 12 ++++++++++++
 3 files changed, 19 insertions(+)

Comments

Ammar Faizi Nov. 3, 2022, 9:55 p.m. UTC | #1
On 11/4/22 3:40 AM, Stefan Roesch wrote:
> This adds the two functions to register and unregister the napi busy
> poll timeout:
> - io_uring_register_busy_poll_timeout
> - io_uring_unregister_busy_poll_timeout
> 
> Signed-off-by: Stefan Roesch <shr@devkernel.io>
> ---
>   src/include/liburing.h          |  3 +++
>   src/include/liburing/io_uring.h |  4 ++++
>   src/register.c                  | 12 ++++++++++++
>   3 files changed, 19 insertions(+)
> 
> diff --git a/src/include/liburing.h b/src/include/liburing.h
> index 12a703f..ef2510e 100644
> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -235,6 +235,9 @@ int io_uring_register_sync_cancel(struct io_uring *ring,
>   int io_uring_register_file_alloc_range(struct io_uring *ring,
>   					unsigned off, unsigned len);
>   
> +int io_uring_register_busy_poll_timeout(struct io_uring *ring, unsigned int to);
> +int io_uring_unregister_busy_poll_timeout(struct io_uring *ring);
> +

If you export a non inline function, you should also update the liburing.map
file.
Ammar Faizi Nov. 3, 2022, 10:09 p.m. UTC | #2
On 11/4/22 3:40 AM, Stefan Roesch wrote:
> This adds the two functions to register and unregister the napi busy
> poll timeout:
> - io_uring_register_busy_poll_timeout
> - io_uring_unregister_busy_poll_timeout
> 
> Signed-off-by: Stefan Roesch <shr@devkernel.io>

Also, please update the CHANGELOG file if you add a new feature.
Create a new entry for liburing-2.4 release.

Ref: https://github.com/axboe/liburing/discussions/696#discussioncomment-3962770
Stefan Roesch Nov. 7, 2022, 5:54 p.m. UTC | #3
Ammar Faizi <ammarfaizi2@gnuweeb.org> writes:

> On 11/4/22 3:40 AM, Stefan Roesch wrote:
>> This adds the two functions to register and unregister the napi busy
>> poll timeout:
>> - io_uring_register_busy_poll_timeout
>> - io_uring_unregister_busy_poll_timeout
>> Signed-off-by: Stefan Roesch <shr@devkernel.io>
>> ---
>>   src/include/liburing.h          |  3 +++
>>   src/include/liburing/io_uring.h |  4 ++++
>>   src/register.c                  | 12 ++++++++++++
>>   3 files changed, 19 insertions(+)
>> diff --git a/src/include/liburing.h b/src/include/liburing.h
>> index 12a703f..ef2510e 100644
>> --- a/src/include/liburing.h
>> +++ b/src/include/liburing.h
>> @@ -235,6 +235,9 @@ int io_uring_register_sync_cancel(struct io_uring *ring,
>>   int io_uring_register_file_alloc_range(struct io_uring *ring,
>>   					unsigned off, unsigned len);
>>   +int io_uring_register_busy_poll_timeout(struct io_uring *ring, unsigned int
>> to);
>> +int io_uring_unregister_busy_poll_timeout(struct io_uring *ring);
>> +
>
> If you export a non inline function, you should also update the liburing.map
> file.

In version 2 of the patch, the file liburing.map is updated.
Stefan Roesch Nov. 7, 2022, 5:56 p.m. UTC | #4
Ammar Faizi <ammarfaizi2@gnuweeb.org> writes:

> On 11/4/22 3:40 AM, Stefan Roesch wrote:
>> This adds the two functions to register and unregister the napi busy
>> poll timeout:
>> - io_uring_register_busy_poll_timeout
>> - io_uring_unregister_busy_poll_timeout
>> Signed-off-by: Stefan Roesch <shr@devkernel.io>
>
> Also, please update the CHANGELOG file if you add a new feature.
> Create a new entry for liburing-2.4 release.
>
In version 2 of the patch, the CHANGELOG file has been updated.

> Ref: https://github.com/axboe/liburing/discussions/696#discussioncomment-3962770
diff mbox series

Patch

diff --git a/src/include/liburing.h b/src/include/liburing.h
index 12a703f..ef2510e 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -235,6 +235,9 @@  int io_uring_register_sync_cancel(struct io_uring *ring,
 int io_uring_register_file_alloc_range(struct io_uring *ring,
 					unsigned off, unsigned len);
 
+int io_uring_register_busy_poll_timeout(struct io_uring *ring, unsigned int to);
+int io_uring_unregister_busy_poll_timeout(struct io_uring *ring);
+
 int io_uring_get_events(struct io_uring *ring);
 int io_uring_submit_and_get_events(struct io_uring *ring);
 
diff --git a/src/include/liburing/io_uring.h b/src/include/liburing/io_uring.h
index a3e0920..0919d9e 100644
--- a/src/include/liburing/io_uring.h
+++ b/src/include/liburing/io_uring.h
@@ -499,6 +499,10 @@  enum {
 	/* register a range of fixed file slots for automatic slot allocation */
 	IORING_REGISTER_FILE_ALLOC_RANGE	= 25,
 
+	/* set/clear busy poll timeout */
+	IORING_REGISTER_NAPI_BUSY_POLL_TIMEOUT	= 26,
+	IORING_UNREGISTER_NAPI_BUSY_POLL_TIMEOUT= 27,
+
 	/* this goes last */
 	IORING_REGISTER_LAST
 };
diff --git a/src/register.c b/src/register.c
index e849825..c18e072 100644
--- a/src/register.c
+++ b/src/register.c
@@ -367,3 +367,15 @@  int io_uring_register_file_alloc_range(struct io_uring *ring,
 				       IORING_REGISTER_FILE_ALLOC_RANGE, &range,
 				       0);
 }
+
+int io_uring_register_busy_poll_timeout(struct io_uring *ring, unsigned int to)
+{
+	return __sys_io_uring_register(ring->ring_fd,
+				IORING_REGISTER_NAPI_BUSY_POLL_TIMEOUT, NULL, to);
+}
+
+int io_uring_unregister_busy_poll_timeout(struct io_uring *ring)
+{
+	return __sys_io_uring_register(ring->ring_fd,
+				IORING_UNREGISTER_NAPI_BUSY_POLL_TIMEOUT, NULL, 0);
+}