| Message ID | 20221108004157.1112-5-longpeng2@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add generic vDPA device support | expand |
On Tue, Nov 8, 2022 at 8:42 AM Longpeng(Mike) <longpeng2@huawei.com> wrote: > > From: Longpeng <longpeng2@huawei.com> > > The generic vDPA device doesn't support migration currently, so > mark it as unmigratable temporarily. > > Signed-off-by: Longpeng <longpeng2@huawei.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > hw/virtio/vdpa-dev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c > index 2885d06cbe..62d83d3423 100644 > --- a/hw/virtio/vdpa-dev.c > +++ b/hw/virtio/vdpa-dev.c > @@ -327,6 +327,7 @@ static Property vhost_vdpa_device_properties[] = { > > static const VMStateDescription vmstate_vhost_vdpa_device = { > .name = "vhost-vdpa-device", > + .unmigratable = 1, > .minimum_version_id = 1, > .version_id = 1, > .fields = (VMStateField[]) { > -- > 2.23.0 >
On Tue, Nov 08, 2022 at 08:41:56AM +0800, Longpeng(Mike) wrote: >From: Longpeng <longpeng2@huawei.com> > >The generic vDPA device doesn't support migration currently, so >mark it as unmigratable temporarily. > >Signed-off-by: Longpeng <longpeng2@huawei.com> >--- > hw/virtio/vdpa-dev.c | 1 + > 1 file changed, 1 insertion(+) Is there a particular reason why we don't squash this change in the second patch of this series where we add the hw/virtio/vdpa-dev.c file? Anyway, this change LGTM: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > >diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c >index 2885d06cbe..62d83d3423 100644 >--- a/hw/virtio/vdpa-dev.c >+++ b/hw/virtio/vdpa-dev.c >@@ -327,6 +327,7 @@ static Property vhost_vdpa_device_properties[] = { > > static const VMStateDescription vmstate_vhost_vdpa_device = { > .name = "vhost-vdpa-device", >+ .unmigratable = 1, > .minimum_version_id = 1, > .version_id = 1, > .fields = (VMStateField[]) { >-- >2.23.0 >
在 2022/11/8 16:46, Stefano Garzarella 写道: > On Tue, Nov 08, 2022 at 08:41:56AM +0800, Longpeng(Mike) wrote: >> From: Longpeng <longpeng2@huawei.com> >> >> The generic vDPA device doesn't support migration currently, so >> mark it as unmigratable temporarily. >> >> Signed-off-by: Longpeng <longpeng2@huawei.com> >> --- >> hw/virtio/vdpa-dev.c | 1 + >> 1 file changed, 1 insertion(+) > > Is there a particular reason why we don't squash this change in the > second patch of this series where we add the hw/virtio/vdpa-dev.c file? > No, just want to make it noticeable. > Anyway, this change LGTM: > > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> > Thanks. >> >> diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c >> index 2885d06cbe..62d83d3423 100644 >> --- a/hw/virtio/vdpa-dev.c >> +++ b/hw/virtio/vdpa-dev.c >> @@ -327,6 +327,7 @@ static Property vhost_vdpa_device_properties[] = { >> >> static const VMStateDescription vmstate_vhost_vdpa_device = { >> .name = "vhost-vdpa-device", >> + .unmigratable = 1, >> .minimum_version_id = 1, >> .version_id = 1, >> .fields = (VMStateField[]) { >> -- >> 2.23.0 >> > > .
diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c index 2885d06cbe..62d83d3423 100644 --- a/hw/virtio/vdpa-dev.c +++ b/hw/virtio/vdpa-dev.c @@ -327,6 +327,7 @@ static Property vhost_vdpa_device_properties[] = { static const VMStateDescription vmstate_vhost_vdpa_device = { .name = "vhost-vdpa-device", + .unmigratable = 1, .minimum_version_id = 1, .version_id = 1, .fields = (VMStateField[]) {