| Message ID | 20221108082330.2086671-8-lukma@denx.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: Add support for mv88e6020 and mv88e6071 | expand |
On Tue, Nov 08, 2022 at 09:23:28AM +0100, Lukasz Majewski wrote: > Accroding to the documentation - the mv88e6071 can support > frame size up to 2048 bytes. Since the mv88e6020 is in the same family, it probably is the same? And what about the mv88e66220? Andrew
Hi Andrew, > On Tue, Nov 08, 2022 at 09:23:28AM +0100, Lukasz Majewski wrote: > > Accroding to the documentation - the mv88e6071 can support > > frame size up to 2048 bytes. > > Since the mv88e6020 is in the same family, it probably is the same? Yes it is 2048 B > And what about the mv88e66220? You mean mv88e6220 ? IIRC they are from the same family of ICs, so my guess :-) is that they also have the same value. > > Andrew Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Thu, Nov 10, 2022 at 04:42:36PM +0100, Lukasz Majewski wrote: > Hi Andrew, > > > On Tue, Nov 08, 2022 at 09:23:28AM +0100, Lukasz Majewski wrote: > > > Accroding to the documentation - the mv88e6071 can support > > > frame size up to 2048 bytes. > > > > Since the mv88e6020 is in the same family, it probably is the same? > > Yes it is 2048 B > > > And what about the mv88e66220? > > You mean mv88e6220 ? Upps, sorry, yes. > > IIRC they are from the same family of ICs, so my guess :-) is that they > also have the same value. My point being, you created a new _ops structure when i don't think it is needed. Andrew
Hi Andrew, > On Thu, Nov 10, 2022 at 04:42:36PM +0100, Lukasz Majewski wrote: > > Hi Andrew, > > > > > On Tue, Nov 08, 2022 at 09:23:28AM +0100, Lukasz Majewski wrote: > > > > Accroding to the documentation - the mv88e6071 can support > > > > frame size up to 2048 bytes. > > > > > > Since the mv88e6020 is in the same family, it probably is the > > > same? > > > > Yes it is 2048 B > > > > > And what about the mv88e66220? > > > > You mean mv88e6220 ? > > Upps, sorry, yes. > > > > > IIRC they are from the same family of ICs, so my guess :-) is that > > they also have the same value. > > My point being, you created a new _ops structure when i don't think it > is needed. This was mostly my precaution to not introduce regression for other supported ICs. However, this shall not be the problem as long as the max supported frame size is set for each of it. Then calling set_max_frame_size() callback will always provide correct value. > > Andrew Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index d90835b4c606..e0224fc92ddf 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -5563,6 +5563,7 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = { .num_ports = 7, .num_internal_phys = 5, .max_vid = 4095, + .max_frame_size = 2048, .port_base_addr = 0x08, .phy_base_addr = 0x00, .global1_addr = 0x0f,
Accroding to the documentation - the mv88e6071 can support frame size up to 2048 bytes. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+)