[v3,net-next,0/3] net: axienet: Use a DT property to configure frequency of the MDIO bus

Message

Andy Chiu Nov. 4, 2022, 6:03 a.m. UTC

Some FPGA platforms have to set frequency of the MDIO bus lower than 2.5
MHz. Thus, we use a DT property, which is "clock-frequency", to work
with it at boot time. The default 2.5 MHz would be set if the property
is not pressent. Also, factor out mdio enable/disable functions due to
the api change since 253761a0e61b7.

Changelog:
--- v3 ---
1. Fix coding style, and make probing of the driver fail if MDC overflow
--- v2 ---
1. Use clock-frequency, as defined in mdio.yaml, to configure MDIO
   clock.
2. Only print out frequency if it is set to a non-standard value.
3. Reduce the scope of axienet_mdio_enable and remove
   axienet_mdio_disable because no one really uses it anymore.

Andy Chiu (3):
  net: axienet: Unexport and remove unused mdio functions
  net: axienet: set mdio clock according to bus-frequency
  dt-bindings: describe the support of "clock-frequency" in mdio

 .../bindings/net/xilinx_axienet.txt           |  2 +
 drivers/net/ethernet/xilinx/xilinx_axienet.h  |  2 -
 .../net/ethernet/xilinx/xilinx_axienet_mdio.c | 57 +++++++++++--------
 3 files changed, 34 insertions(+), 27 deletions(-)

Comments

Jakub Kicinski Nov. 9, 2022, 1:02 a.m. UTC | #1

On Fri,  4 Nov 2022 14:03:02 +0800 Andy Chiu wrote:
> Some FPGA platforms have to set frequency of the MDIO bus lower than 2.5
> MHz. Thus, we use a DT property, which is "clock-frequency", to work
> with it at boot time. The default 2.5 MHz would be set if the property
> is not pressent. Also, factor out mdio enable/disable functions due to
> the api change since 253761a0e61b7.

FWIW this patch set was set to Changes Requested in the patchwork
but I don't recall what the reason was. If you're not aware of anyone
requesting changes either - could you just repost to the list again,
the same exact code?

Andy Chiu Nov. 14, 2022, 2:44 p.m. UTC | #2

On Wed, Nov 9, 2022 at 9:03 AM Jakub Kicinski <[e-mail]> wrote:
> FWIW this patch set was set to Changes Requested in the patchwork
> but I don't recall what the reason was. If you're not aware of anyone
> requesting changes either - could you just repost to the list again,
> the same exact code?

Hi, I am not aware of any requested changes on the v3 patch either. I
just resent the patch again, please check the following link, thanks!!
https://lore.kernel.org/all/[e-mail]/