| Message ID | 20221107101443.120205-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b06334919c7a068d54ba5b219c05e919d89943f7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: nixge: disable napi when enable interrupts failed in nixge_open() | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 7 Nov 2022 18:14:43 +0800 you wrote: > When failed to enable interrupts in nixge_open() for opening device, > napi isn't disabled. When open nixge device next time, it will reports > a invalid opcode issue. Fix it. Only be compiled, not be tested. > > Fixes: 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev") > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > > [...] Here is the summary with links: - [net] net: nixge: disable napi when enable interrupts failed in nixge_open() https://git.kernel.org/netdev/net/c/b06334919c7a You are awesome, thank you!
diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c index 3db4a2431741..19d043b593cc 100644 --- a/drivers/net/ethernet/ni/nixge.c +++ b/drivers/net/ethernet/ni/nixge.c @@ -900,6 +900,7 @@ static int nixge_open(struct net_device *ndev) err_rx_irq: free_irq(priv->tx_irq, ndev); err_tx_irq: + napi_disable(&priv->napi); phy_stop(phy); phy_disconnect(phy); tasklet_kill(&priv->dma_err_tasklet);
When failed to enable interrupts in nixge_open() for opening device, napi isn't disabled. When open nixge device next time, it will reports a invalid opcode issue. Fix it. Only be compiled, not be tested. Fixes: 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- drivers/net/ethernet/ni/nixge.c | 1 + 1 file changed, 1 insertion(+)