Message ID | 20221104215516.2874922-4-m.grzeschik@pengutronix.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ARM: at91: USB Device Port fixes | expand |
On 04.11.2022 23:55, Michael Grzeschik wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Referring to the datasheet the index 2 is the MCKUDP. When enabled, it > "Enables the automatic disable of the Master Clock of the USB Device > Port when a suspend condition occurs". We fix the index to the real UDP > id which "Enables the 48 MHz clock of the USB Device Port". > > Cc: nicolas.ferre@microchip.com > Cc: ludovic.desroches@microchip.com > Cc: alexandre.belloni@bootlin.com > Cc: linux-arm-kernel@lists.infradead.orga > Cc: kernel@pengutronix.de > Fixes: 0e0e528d8260 (ARM: dts: at91: rm9200: switch to new clock bindings) Same here. > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > --- > v1 -> v2: - removed ; from patch description > - added fixes tag > > arch/arm/boot/dts/at91rm9200.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi > index 7a113325abb9ed..6f9004ebf42456 100644 > --- a/arch/arm/boot/dts/at91rm9200.dtsi > +++ b/arch/arm/boot/dts/at91rm9200.dtsi > @@ -666,7 +666,7 @@ usb1: gadget@fffb0000 { > compatible = "atmel,at91rm9200-udc"; > reg = <0xfffb0000 0x4000>; > interrupts = <11 IRQ_TYPE_LEVEL_HIGH 2>; > - clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 2>; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 1>; > clock-names = "pclk", "hclk"; > status = "disabled"; > }; > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi index 7a113325abb9ed..6f9004ebf42456 100644 --- a/arch/arm/boot/dts/at91rm9200.dtsi +++ b/arch/arm/boot/dts/at91rm9200.dtsi @@ -666,7 +666,7 @@ usb1: gadget@fffb0000 { compatible = "atmel,at91rm9200-udc"; reg = <0xfffb0000 0x4000>; interrupts = <11 IRQ_TYPE_LEVEL_HIGH 2>; - clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 2>; + clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 1>; clock-names = "pclk", "hclk"; status = "disabled"; };
Referring to the datasheet the index 2 is the MCKUDP. When enabled, it "Enables the automatic disable of the Master Clock of the USB Device Port when a suspend condition occurs". We fix the index to the real UDP id which "Enables the 48 MHz clock of the USB Device Port". Cc: nicolas.ferre@microchip.com Cc: ludovic.desroches@microchip.com Cc: alexandre.belloni@bootlin.com Cc: linux-arm-kernel@lists.infradead.orga Cc: kernel@pengutronix.de Fixes: 0e0e528d8260 (ARM: dts: at91: rm9200: switch to new clock bindings) Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- v1 -> v2: - removed ; from patch description - added fixes tag arch/arm/boot/dts/at91rm9200.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)