| Message ID | 15a32dd06c492216cbf27cd3ddcbe1e9afb8d8f5.1668009030.git.mrezanin@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Removal of several unused variables causing | expand |
On 09/11/2022 16.57, mrezanin@redhat.com wrote: > From: Miroslav Rezanina <mrezanin@redhat.com> > > Variable send_count used in rtl8139_cplus_transmit_one function is only > incremented but never read. This causes 'Unused but set variable' warning > on Clang 15.0.1 compiler. > > Removing the variable to prevent the warning. > > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> > --- > hw/net/rtl8139.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > index 6b65823b4b..e6643e3c9d 100644 > --- a/hw/net/rtl8139.c > +++ b/hw/net/rtl8139.c > @@ -2156,7 +2156,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > ip_data_len, saved_size - ETH_HLEN, large_send_mss); > > int tcp_send_offset = 0; > - int send_count = 0; > > /* maximum IP header length is 60 bytes */ > uint8_t saved_ip_header[60]; > @@ -2261,7 +2260,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > /* add transferred count to TCP sequence number */ > stl_be_p(&p_tcp_hdr->th_seq, > chunk_size + ldl_be_p(&p_tcp_hdr->th_seq)); > - ++send_count; > } > > /* Stop sending this frame */ Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 6b65823b4b..e6643e3c9d 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -2156,7 +2156,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) ip_data_len, saved_size - ETH_HLEN, large_send_mss); int tcp_send_offset = 0; - int send_count = 0; /* maximum IP header length is 60 bytes */ uint8_t saved_ip_header[60]; @@ -2261,7 +2260,6 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) /* add transferred count to TCP sequence number */ stl_be_p(&p_tcp_hdr->th_seq, chunk_size + ldl_be_p(&p_tcp_hdr->th_seq)); - ++send_count; } /* Stop sending this frame */