| Message ID | 20221109095010.141189-3-christian.koenig@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm/amd/amdgpu revert "implement tdr advanced mode" | expand |
On Wed, Nov 9, 2022 at 4:50 AM Christian König <ckoenig.leichtzumerken@gmail.com> wrote: > > As far as I can see this is not really recoverable since a PCI reset > clears VRAM. Might be more clear to say the state of VRAM is unreliable due to a PCI event like an AER event or a link reset or DPC event. The reset itself may not clear VRAM directly (e.g., mode2 reset or APUs). Alex > > Signed-off-by: Christian König <christian.koenig@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 3a51c4c61833..8564d4a8e3e8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -5747,8 +5747,6 @@ void amdgpu_pci_resume(struct pci_dev *pdev) > if (!ring || !ring->sched.thread) > continue; > > - > - drm_sched_resubmit_jobs(&ring->sched); > drm_sched_start(&ring->sched, true); > } > > -- > 2.34.1 >
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 3a51c4c61833..8564d4a8e3e8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -5747,8 +5747,6 @@ void amdgpu_pci_resume(struct pci_dev *pdev) if (!ring || !ring->sched.thread) continue; - - drm_sched_resubmit_jobs(&ring->sched); drm_sched_start(&ring->sched, true); }
As far as I can see this is not really recoverable since a PCI reset clears VRAM. Signed-off-by: Christian König <christian.koenig@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 -- 1 file changed, 2 deletions(-)