| Message ID | 20221107133027.38740-1-matthew.auld@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/ttm: never purge busy objects | expand |
On 07/11/2022 17:57, Patchwork wrote: > *Patch Details* > *Series:* drm/i915/ttm: never purge busy objects > *URL:* https://patchwork.freedesktop.org/series/110601/ > <https://patchwork.freedesktop.org/series/110601/> > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.html > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.html> > > > CI Bug Log - changes from CI_DRM_12351 -> Patchwork_110601v1 > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_110601v1 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_110601v1, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.html > > > Participating hosts (42 -> 30) > > Additional (2): fi-kbl-soraka fi-cml-u2 > Missing (14): fi-ilk-m540 fi-bdw-samus fi-tgl-dsi fi-hsw-4200u bat-dg2-9 > bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-adln-1 bat-rplp-1 bat-rpls-1 > bat-rpls-2 bat-dg2-11 bat-jsl-1 > > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_110601v1: > > > IGT changes > > > Possible regressions > > * igt@i915_suspend@basic-s3-without-i915: > o fi-cml-u2: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@i915_suspend@basic-s3-without-i915.html> Unrelated. Patch only affects discrete platforms. > > > Known issues > > Here are the changes found in Patchwork_110601v1 that come from known > issues: > > > IGT changes > > > Issues hit > > * > > igt@gem_exec_fence@basic-busy@bcs0: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html> (i915#1208 <https://gitlab.freedesktop.org/drm/intel/issues/1208>) +1 similar issue > * > > igt@gem_exec_gttfill@basic: > > o > > fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +8 similar issues > > o > > fi-pnv-d510: PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-pnv-d510/igt@gem_exec_gttfill@basic.html> -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html> (i915#7229 <https://gitlab.freedesktop.org/drm/intel/issues/7229>) > > * > > igt@gem_huc_copy@huc-copy: > > o > > fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@gem_huc_copy@huc-copy.html> (i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > o > > fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > * > > igt@gem_lmem_swapping@basic: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > * > > igt@gem_lmem_swapping@verify-random: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@gem_lmem_swapping@verify-random.html> (i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > * > > igt@i915_selftest@live@gem_contexts: > > o fi-kbl-soraka: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html> (i915#7099 <https://gitlab.freedesktop.org/drm/intel/issues/7099>) > * > > igt@i915_selftest@live@gt_pm: > > o fi-kbl-soraka: NOTRUN -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>) > * > > igt@kms_chamelium@common-hpd-after-suspend: > > o > > fi-ivb-3770: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-ivb-3770/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > o > > fi-hsw-4770: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > * > > igt@kms_chamelium@hdmi-hpd-fast: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 similar issues > * > > igt@kms_chamelium@vga-hpd-fast: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_chamelium@vga-hpd-fast.html> (fdo#109284 <https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 similar issues > * > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html> (i915#4213 <https://gitlab.freedesktop.org/drm/intel/issues/4213>) > * > > igt@kms_force_connector_basic@force-load-detect: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>) > * > > igt@kms_frontbuffer_tracking@basic: > > o fi-cml-u2: NOTRUN -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html> (i915#402 <https://gitlab.freedesktop.org/drm/intel/issues/402>) > * > > igt@kms_setmode@basic-clone-single-crtc: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > * > > igt@prime_vgem@basic-userptr: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@prime_vgem@basic-userptr.html> (fdo#109295 <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3301 <https://gitlab.freedesktop.org/drm/intel/issues/3301>) > > > Possible fixes > > * > > igt@i915_selftest@live@hangcheck: > > o > > fi-hsw-4770: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> (i915#4785 <https://gitlab.freedesktop.org/drm/intel/issues/4785>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> > > o > > fi-ivb-3770: INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html> (i915#3303 <https://gitlab.freedesktop.org/drm/intel/issues/3303> / i915#7122 <https://gitlab.freedesktop.org/drm/intel/issues/7122>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html> > > * > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: > > o fi-bsw-kefka: FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html> (i915#6298 <https://gitlab.freedesktop.org/drm/intel/issues/6298>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html> > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > > Build changes > > * Linux: CI_DRM_12351 -> Patchwork_110601v1 > > CI-20190529: 20190529 > CI_DRM_12351: 74d8166a994863d1f83e842c1822506a8f6aa806 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7046: c58d96d0fe237474b074e3472ce09c57c830d5de @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_110601v1: 74d8166a994863d1f83e842c1822506a8f6aa806 @ > git://anongit.freedesktop.org/gfx-ci/linux > > > Linux commits > > 5e25556f8ee0 drm/i915/ttm: never purge busy objects >
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/7379 Lakshmi. -----Original Message----- From: Auld, Matthew <matthew.auld@intel.com> Sent: Tuesday, November 8, 2022 5:49 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com> Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/ttm: never purge busy objects On 07/11/2022 17:57, Patchwork wrote: > *Patch Details* > *Series:* drm/i915/ttm: never purge busy objects > *URL:* https://patchwork.freedesktop.org/series/110601/ > <https://patchwork.freedesktop.org/series/110601/> > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.html > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.htm > l> > > > CI Bug Log - changes from CI_DRM_12351 -> Patchwork_110601v1 > > > Summary > > *FAILURE* > > Serious unknown changes coming with Patchwork_110601v1 absolutely need > to be verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_110601v1, please notify your bug team to allow > them to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/index.html > > > Participating hosts (42 -> 30) > > Additional (2): fi-kbl-soraka fi-cml-u2 Missing (14): fi-ilk-m540 > fi-bdw-samus fi-tgl-dsi fi-hsw-4200u bat-dg2-9 > bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-adln-1 bat-rplp-1 bat-rpls-1 > bat-rpls-2 bat-dg2-11 bat-jsl-1 > > > Possible new issues > > Here are the unknown changes that may have been introduced in > Patchwork_110601v1: > > > IGT changes > > > Possible regressions > > * igt@i915_suspend@basic-s3-without-i915: > o fi-cml-u2: NOTRUN -> INCOMPLETE > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2 > /igt@i915_suspend@basic-s3-without-i915.html> Unrelated. Patch only affects discrete platforms. > > > Known issues > > Here are the changes found in Patchwork_110601v1 that come from known > issues: > > > IGT changes > > > Issues hit > > * > > igt@gem_exec_fence@basic-busy@bcs0: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@gem_exec_fence@basic-busy@bcs0.html> (i915#1208 <https://gitlab.freedesktop.org/drm/intel/issues/1208>) +1 similar issue > * > > igt@gem_exec_gttfill@basic: > > o > > fi-kbl-soraka: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-so > raka/igt@gem_exec_gttfill@basic.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +8 similar > issues > > o > > fi-pnv-d510: PASS > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-pnv-d510/igt > @gem_exec_gttfill@basic.html> -> FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-pnv-d5 > 10/igt@gem_exec_gttfill@basic.html> (i915#7229 > <https://gitlab.freedesktop.org/drm/intel/issues/7229>) > > * > > igt@gem_huc_copy@huc-copy: > > o > > fi-cml-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2 > /igt@gem_huc_copy@huc-copy.html> (i915#2190 > <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > o > > fi-kbl-soraka: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-so > raka/igt@gem_huc_copy@huc-copy.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190 > <https://gitlab.freedesktop.org/drm/intel/issues/2190>) > > * > > igt@gem_lmem_swapping@basic: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > * > > igt@gem_lmem_swapping@verify-random: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@gem_lmem_swapping@verify-random.html> (i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues > * > > igt@i915_selftest@live@gem_contexts: > > o fi-kbl-soraka: NOTRUN -> INCOMPLETE > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html> (i915#7099 <https://gitlab.freedesktop.org/drm/intel/issues/7099>) > * > > igt@i915_selftest@live@gt_pm: > > o fi-kbl-soraka: NOTRUN -> DMESG-FAIL > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>) > * > > igt@kms_chamelium@common-hpd-after-suspend: > > o > > fi-ivb-3770: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-ivb-37 > 70/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > o > > fi-hsw-4770: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-hsw-47 > 70/igt@kms_chamelium@common-hpd-after-suspend.html> (fdo#109271 > <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 > <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) > > * > > igt@kms_chamelium@hdmi-hpd-fast: > > o fi-kbl-soraka: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 similar issues > * > > igt@kms_chamelium@vga-hpd-fast: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_chamelium@vga-hpd-fast.html> (fdo#109284 <https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7 similar issues > * > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html> (i915#4213 <https://gitlab.freedesktop.org/drm/intel/issues/4213>) > * > > igt@kms_force_connector_basic@force-load-detect: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>) > * > > igt@kms_frontbuffer_tracking@basic: > > o fi-cml-u2: NOTRUN -> DMESG-WARN > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html> (i915#402 <https://gitlab.freedesktop.org/drm/intel/issues/402>) > * > > igt@kms_setmode@basic-clone-single-crtc: > > o fi-cml-u2: NOTRUN -> SKIP > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>) > * > > igt@prime_vgem@basic-userptr: > > o fi-cml-u2: NOTRUN -> SKIP > > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-cml-u2 > /igt@prime_vgem@basic-userptr.html> (fdo#109295 > <https://bugs.freedesktop.org/show_bug.cgi?id=109295> / i915#3301 > <https://gitlab.freedesktop.org/drm/intel/issues/3301>) > > > Possible fixes > > * > > igt@i915_selftest@live@hangcheck: > > o > > fi-hsw-4770: INCOMPLETE > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-hsw-4770/igt > @i915_selftest@live@hangcheck.html> (i915#4785 > <https://gitlab.freedesktop.org/drm/intel/issues/4785>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-hsw-47 > 70/igt@i915_selftest@live@hangcheck.html> > > o > > fi-ivb-3770: INCOMPLETE > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-ivb-3770/igt > @i915_selftest@live@hangcheck.html> (i915#3303 > <https://gitlab.freedesktop.org/drm/intel/issues/3303> / i915#7122 > <https://gitlab.freedesktop.org/drm/intel/issues/7122>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-ivb-37 > 70/igt@i915_selftest@live@hangcheck.html> > > * > > igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: > > o fi-bsw-kefka: FAIL > > <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12351/fi-bsw-kefka/ig > t@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-v > arying-size.html> (i915#6298 > <https://gitlab.freedesktop.org/drm/intel/issues/6298>) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_110601v1/fi-bsw-ke > fka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transit > ions-varying-size.html> > > {name}: This element is suppressed. This means it is ignored when > computing the status of the difference (SUCCESS, WARNING, or FAILURE). > > > Build changes > > * Linux: CI_DRM_12351 -> Patchwork_110601v1 > > CI-20190529: 20190529 > CI_DRM_12351: 74d8166a994863d1f83e842c1822506a8f6aa806 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7046: c58d96d0fe237474b074e3472ce09c57c830d5de @ > https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_110601v1: 74d8166a994863d1f83e842c1822506a8f6aa806 @ > git://anongit.freedesktop.org/gfx-ci/linux > > > Linux commits > > 5e25556f8ee0 drm/i915/ttm: never purge busy objects >
On Mon, Nov 07, 2022 at 01:30:27PM +0000, Matthew Auld wrote: >In i915_gem_madvise_ioctl() we immediately purge the object is not >currently used, like when the mm.pages are NULL. With shmem the pages >might still be hanging around or are perhaps swapped out. Similarly with >ttm we might still have the pages hanging around on the ttm resource, >like with lmem or shmem, but here we need to be extra careful since >async unbinds are possible as well as in-progress kernel moves. In >i915_ttm_purge() we expect the pipeline-gutting to nuke the ttm resource >for us, however if it's busy the memory is only moved to a ghost object, >which then leads to broken behaviour when for example clearing the >i915_tt->filp, since the actual ttm_tt is still alive and populated, >even though it's been moved to the ghost object. When we later destroy >the ghost object we hit the following, since the filp is now NULL: > >[ +0.006982] #PF: supervisor read access in kernel mode >[ +0.005149] #PF: error_code(0x0000) - not-present page >[ +0.005147] PGD 11631d067 P4D 11631d067 PUD 115972067 PMD 0 >[ +0.005676] Oops: 0000 [#1] PREEMPT SMP NOPTI >[ +0.012962] Workqueue: events ttm_device_delayed_workqueue [ttm] >[ +0.006022] RIP: 0010:i915_ttm_tt_unpopulate+0x3a/0x70 [i915] >[ +0.005879] Code: 89 fb 48 85 f6 74 11 8b 55 4c 48 8b 7d 30 45 31 c0 31 c9 e8 18 6a e5 e0 80 7d 60 00 74 20 48 8b 45 68 >8b 55 08 4c 89 e7 5b 5d <48> 8b 40 20 83 e2 01 41 5c 89 d1 48 8b 70 > 30 e9 42 b2 ff ff 4c 89 >[ +0.018782] RSP: 0000:ffffc9000bf6fd70 EFLAGS: 00010202 >[ +0.005244] RAX: 0000000000000000 RBX: ffff8883e12ae380 RCX: 0000000000000000 >[ +0.007150] RDX: 000000008000000e RSI: ffffffff823559b4 RDI: ffff8883e12ae3c0 >[ +0.007142] RBP: ffff888103b65d48 R08: 0000000000000001 R09: 0000000000000001 >[ +0.007144] R10: 0000000000000001 R11: ffff88829c2c8040 R12: ffff8883e12ae3c0 >[ +0.007148] R13: 0000000000000001 R14: ffff888115184140 R15: ffff888115184248 >[ +0.007154] FS: 0000000000000000(0000) GS:ffff88844db00000(0000) knlGS:0000000000000000 >[ +0.008108] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >[ +0.005763] CR2: 0000000000000020 CR3: 000000013fdb4004 CR4: 00000000003706e0 >[ +0.007152] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >[ +0.007145] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >[ +0.007154] Call Trace: >[ +0.002459] <TASK> >[ +0.002126] ttm_tt_unpopulate.part.0+0x17/0x70 [ttm] >[ +0.005068] ttm_bo_tt_destroy+0x1c/0x50 [ttm] >[ +0.004464] ttm_bo_cleanup_memtype_use+0x25/0x40 [ttm] >[ +0.005244] ttm_bo_cleanup_refs+0x90/0x2c0 [ttm] >[ +0.004721] ttm_bo_delayed_delete+0x235/0x250 [ttm] >[ +0.004981] ttm_device_delayed_workqueue+0x13/0x40 [ttm] >[ +0.005422] process_one_work+0x248/0x560 >[ +0.004028] worker_thread+0x4b/0x390 >[ +0.003682] ? process_one_work+0x560/0x560 >[ +0.004199] kthread+0xeb/0x120 >[ +0.003163] ? kthread_complete_and_exit+0x20/0x20 >[ +0.004815] ret_from_fork+0x1f/0x30 > >Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") >Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> >Signed-off-by: Matthew Auld <matthew.auld@intel.com> >Cc: Andrzej Hajda <andrzej.hajda@intel.com> >Cc: Nirmoy Das <nirmoy.das@intel.com> >Cc: <stable@vger.kernel.org> # v5.15+ >--- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > >diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >index 25129af70f70..fb452a388b5e 100644 >--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c >@@ -599,10 +599,18 @@ i915_ttm_resource_get_st(struct drm_i915_gem_object *obj, > static int i915_ttm_truncate(struct drm_i915_gem_object *obj) > { > struct ttm_buffer_object *bo = i915_gem_to_ttm(obj); >+ struct ttm_operation_ctx ctx = { >+ .interruptible = true, >+ .no_wait_gpu = false, >+ }; > int err; > > WARN_ON_ONCE(obj->mm.madv == I915_MADV_WILLNEED); > >+ err = ttm_bo_wait_ctx(bo, &ctx); >+ if (err) >+ return err; >+ We probably can call ttm_bo_wait() directly without the ctx? Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> > err = i915_ttm_move_notify(bo); > if (err) > return err; >-- >2.38.1 >
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 25129af70f70..fb452a388b5e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -599,10 +599,18 @@ i915_ttm_resource_get_st(struct drm_i915_gem_object *obj, static int i915_ttm_truncate(struct drm_i915_gem_object *obj) { struct ttm_buffer_object *bo = i915_gem_to_ttm(obj); + struct ttm_operation_ctx ctx = { + .interruptible = true, + .no_wait_gpu = false, + }; int err; WARN_ON_ONCE(obj->mm.madv == I915_MADV_WILLNEED); + err = ttm_bo_wait_ctx(bo, &ctx); + if (err) + return err; + err = i915_ttm_move_notify(bo); if (err) return err;
In i915_gem_madvise_ioctl() we immediately purge the object is not currently used, like when the mm.pages are NULL. With shmem the pages might still be hanging around or are perhaps swapped out. Similarly with ttm we might still have the pages hanging around on the ttm resource, like with lmem or shmem, but here we need to be extra careful since async unbinds are possible as well as in-progress kernel moves. In i915_ttm_purge() we expect the pipeline-gutting to nuke the ttm resource for us, however if it's busy the memory is only moved to a ghost object, which then leads to broken behaviour when for example clearing the i915_tt->filp, since the actual ttm_tt is still alive and populated, even though it's been moved to the ghost object. When we later destroy the ghost object we hit the following, since the filp is now NULL: [ +0.006982] #PF: supervisor read access in kernel mode [ +0.005149] #PF: error_code(0x0000) - not-present page [ +0.005147] PGD 11631d067 P4D 11631d067 PUD 115972067 PMD 0 [ +0.005676] Oops: 0000 [#1] PREEMPT SMP NOPTI [ +0.012962] Workqueue: events ttm_device_delayed_workqueue [ttm] [ +0.006022] RIP: 0010:i915_ttm_tt_unpopulate+0x3a/0x70 [i915] [ +0.005879] Code: 89 fb 48 85 f6 74 11 8b 55 4c 48 8b 7d 30 45 31 c0 31 c9 e8 18 6a e5 e0 80 7d 60 00 74 20 48 8b 45 68 8b 55 08 4c 89 e7 5b 5d <48> 8b 40 20 83 e2 01 41 5c 89 d1 48 8b 70 30 e9 42 b2 ff ff 4c 89 [ +0.018782] RSP: 0000:ffffc9000bf6fd70 EFLAGS: 00010202 [ +0.005244] RAX: 0000000000000000 RBX: ffff8883e12ae380 RCX: 0000000000000000 [ +0.007150] RDX: 000000008000000e RSI: ffffffff823559b4 RDI: ffff8883e12ae3c0 [ +0.007142] RBP: ffff888103b65d48 R08: 0000000000000001 R09: 0000000000000001 [ +0.007144] R10: 0000000000000001 R11: ffff88829c2c8040 R12: ffff8883e12ae3c0 [ +0.007148] R13: 0000000000000001 R14: ffff888115184140 R15: ffff888115184248 [ +0.007154] FS: 0000000000000000(0000) GS:ffff88844db00000(0000) knlGS:0000000000000000 [ +0.008108] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ +0.005763] CR2: 0000000000000020 CR3: 000000013fdb4004 CR4: 00000000003706e0 [ +0.007152] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ +0.007145] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ +0.007154] Call Trace: [ +0.002459] <TASK> [ +0.002126] ttm_tt_unpopulate.part.0+0x17/0x70 [ttm] [ +0.005068] ttm_bo_tt_destroy+0x1c/0x50 [ttm] [ +0.004464] ttm_bo_cleanup_memtype_use+0x25/0x40 [ttm] [ +0.005244] ttm_bo_cleanup_refs+0x90/0x2c0 [ttm] [ +0.004721] ttm_bo_delayed_delete+0x235/0x250 [ttm] [ +0.004981] ttm_device_delayed_workqueue+0x13/0x40 [ttm] [ +0.005422] process_one_work+0x248/0x560 [ +0.004028] worker_thread+0x4b/0x390 [ +0.003682] ? process_one_work+0x560/0x560 [ +0.004199] kthread+0xeb/0x120 [ +0.003163] ? kthread_complete_and_exit+0x20/0x20 [ +0.004815] ret_from_fork+0x1f/0x30 Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend") Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Nirmoy Das <nirmoy.das@intel.com> Cc: <stable@vger.kernel.org> # v5.15+ --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 ++++++++ 1 file changed, 8 insertions(+)