| Message ID | 20221110174056.393697-1-jose.exposito89@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk | expand |
Hi José, On 11/10/22 9:40 AM, José Expósito wrote: > Hi everyone, > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > his XP-Pen Star G640 [1]. > > His patch changes the IS_INPUT_APPLICATION() macro to accept > HID_DG_DIGITIZER. However, it looks like it is not being merged because > of the possible side effects that changing that macro could generate. > > This patch aims to fix the same issue but using a more conservative > approach hoping that the bug can be fixed. > > Torge, Alexander, could you test it and confirm that it fixes your > issues, please? I tested the patch on commit 4bbf3422df78 and it fixes the issue. Thank you, Alexander Zhang > Thanks a lot in advance, > José Expósito > > [1] https://lore.kernel.org/linux-input/20220804151832.30373-1-openglfreak@googlemail.com/ > > José Expósito (1): > HID: uclogic: Add HID_QUIRK_HIDINPUT_FORCE quirk > > drivers/hid/hid-uclogic-core.c | 1 + > 1 file changed, 1 insertion(+) >
On Thu, 10 Nov 2022, Alexander Zhang wrote: > Hi José, > > On 11/10/22 9:40 AM, José Expósito wrote: > > Hi everyone, > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > > his XP-Pen Star G640 [1]. > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept > > HID_DG_DIGITIZER. However, it looks like it is not being merged because > > of the possible side effects that changing that macro could generate. > > > > This patch aims to fix the same issue but using a more conservative > > approach hoping that the bug can be fixed. > > > > Torge, Alexander, could you test it and confirm that it fixes your > > issues, please? > > I tested the patch on commit 4bbf3422df78 and it fixes the issue. I will add Tested-by: Alexander Zhang <alex@alexyzhang.dev> to the commit; please speak up if you disagree. Thanks,
On 11/14/22 6:10 AM, Jiri Kosina wrote: > On Thu, 10 Nov 2022, Alexander Zhang wrote: > >> Hi José, >> >> On 11/10/22 9:40 AM, José Expósito wrote: >>> Hi everyone, >>> >>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>> his XP-Pen Star G640 [1]. >>> >>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>> of the possible side effects that changing that macro could generate. >>> >>> This patch aims to fix the same issue but using a more conservative >>> approach hoping that the bug can be fixed. >>> >>> Torge, Alexander, could you test it and confirm that it fixes your >>> issues, please? >> >> I tested the patch on commit 4bbf3422df78 and it fixes the issue. > > I will add > > Tested-by: Alexander Zhang <alex@alexyzhang.dev> > > to the commit; please speak up if you disagree. I'm not sure if you're still waiting for a response from me but I'm fine with that. Thanks, Alexander Zhang
Hello, On 11/19/22 11:01 PM, Alexander Zhang wrote: > On 11/14/22 6:10 AM, Jiri Kosina wrote: >> On Thu, 10 Nov 2022, Alexander Zhang wrote: >> >>> Hi José, >>> >>> On 11/10/22 9:40 AM, José Expósito wrote: >>>> Hi everyone, >>>> >>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>>> his XP-Pen Star G640 [1]. >>>> >>>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>>> of the possible side effects that changing that macro could generate. >>>> >>>> This patch aims to fix the same issue but using a more conservative >>>> approach hoping that the bug can be fixed. >>>> >>>> Torge, Alexander, could you test it and confirm that it fixes your >>>> issues, please? >>> >>> I tested the patch on commit 4bbf3422df78 and it fixes the issue. >> >> I will add >> >> Tested-by: Alexander Zhang <alex@alexyzhang.dev> >> >> to the commit; please speak up if you disagree. > > I'm not sure if you're still waiting for a response from me but I'm fine > with that. Is there something preventing this patch from being merged? I'm not very familiar with the kernel development process. Best, Alexander Zhang
Hi Alexander, On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote: > Hello, > > On 11/19/22 11:01 PM, Alexander Zhang wrote: > > On 11/14/22 6:10 AM, Jiri Kosina wrote: > > > On Thu, 10 Nov 2022, Alexander Zhang wrote: > > > > > > > Hi José, > > > > > > > > On 11/10/22 9:40 AM, José Expósito wrote: > > > > > Hi everyone, > > > > > > > > > > About 3 months ago, Torge Matthies sent a patch fixing an issue with > > > > > his XP-Pen Star G640 [1]. > > > > > > > > > > His patch changes the IS_INPUT_APPLICATION() macro to accept > > > > > HID_DG_DIGITIZER. However, it looks like it is not being merged because > > > > > of the possible side effects that changing that macro could generate. > > > > > > > > > > This patch aims to fix the same issue but using a more conservative > > > > > approach hoping that the bug can be fixed. > > > > > > > > > > Torge, Alexander, could you test it and confirm that it fixes your > > > > > issues, please? > > > > > > > > I tested the patch on commit 4bbf3422df78 and it fixes the issue. > > > > > > I will add > > > > > > Tested-by: Alexander Zhang <alex@alexyzhang.dev> > > > > > > to the commit; please speak up if you disagree. > > > > I'm not sure if you're still waiting for a response from me but I'm fine > > with that. > > Is there something preventing this patch from being merged? I'm not very > familiar with the kernel development process. The patch is already applied in the for-next branch, you can find it here: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8 Jose > Best, > Alexander Zhang
On 12/7/22 3:09 AM, José Expósito wrote: > Hi Alexander, > > On Mon, Dec 05, 2022 at 04:49:10PM -0800, Alexander Zhang wrote: >> Hello, >> >> On 11/19/22 11:01 PM, Alexander Zhang wrote: >>> On 11/14/22 6:10 AM, Jiri Kosina wrote: >>>> On Thu, 10 Nov 2022, Alexander Zhang wrote: >>>> >>>>> Hi José, >>>>> >>>>> On 11/10/22 9:40 AM, José Expósito wrote: >>>>>> Hi everyone, >>>>>> >>>>>> About 3 months ago, Torge Matthies sent a patch fixing an issue with >>>>>> his XP-Pen Star G640 [1]. >>>>>> >>>>>> His patch changes the IS_INPUT_APPLICATION() macro to accept >>>>>> HID_DG_DIGITIZER. However, it looks like it is not being merged because >>>>>> of the possible side effects that changing that macro could generate. >>>>>> >>>>>> This patch aims to fix the same issue but using a more conservative >>>>>> approach hoping that the bug can be fixed. >>>>>> >>>>>> Torge, Alexander, could you test it and confirm that it fixes your >>>>>> issues, please? >>>>> >>>>> I tested the patch on commit 4bbf3422df78 and it fixes the issue. >>>> >>>> I will add >>>> >>>> Tested-by: Alexander Zhang <alex@alexyzhang.dev> >>>> >>>> to the commit; please speak up if you disagree. >>> >>> I'm not sure if you're still waiting for a response from me but I'm fine >>> with that. >> >> Is there something preventing this patch from being merged? I'm not very >> familiar with the kernel development process. > > The patch is already applied in the for-next branch, you can find it here: > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3405a4beaaa8 I see, thank you very much! Best, Alexander Zhang