| Message ID | 20221020210219.45131-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 6df849caeb49e8975e815a6f906528b2da795fbd |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | [V2] hid: intel-ish-hid: ishtp: remove variable rb_count | expand |
On Thu, 2022-10-20 at 22:02 +0100, Colin Ian King wrote: > The variable rb_count is being incremented but it > is never referenced, it is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > V2: Fix commit message. > --- > drivers/hid/intel-ish-hid/ishtp/client.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c > b/drivers/hid/intel-ish-hid/ishtp/client.c > index df0a825694f5..2d92fc129ce4 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/client.c > +++ b/drivers/hid/intel-ish-hid/ishtp/client.c > @@ -841,7 +841,6 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, > unsigned char *buffer = NULL; > struct ishtp_cl_rb *complete_rb = NULL; > unsigned long flags; > - int rb_count; > > if (ishtp_hdr->reserved) { > dev_err(dev->devc, "corrupted message header.\n"); > @@ -855,9 +854,7 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, > } > > spin_lock_irqsave(&dev->read_list_spinlock, flags); > - rb_count = -1; > list_for_each_entry(rb, &dev->read_list.list, list) { > - ++rb_count; > cl = rb->cl; > if (!cl || !(cl->host_client_id == ishtp_hdr- > >host_addr && > cl->fw_client_id == ishtp_hdr- > >fw_addr) ||
On Thu, 20 Oct 2022, Colin Ian King wrote: > The variable rb_count is being incremented but it > is never referenced, it is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > V2: Fix commit message. > --- > drivers/hid/intel-ish-hid/ishtp/client.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c > index df0a825694f5..2d92fc129ce4 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/client.c > +++ b/drivers/hid/intel-ish-hid/ishtp/client.c > @@ -841,7 +841,6 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, > unsigned char *buffer = NULL; > struct ishtp_cl_rb *complete_rb = NULL; > unsigned long flags; > - int rb_count; > > if (ishtp_hdr->reserved) { > dev_err(dev->devc, "corrupted message header.\n"); > @@ -855,9 +854,7 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, > } > > spin_lock_irqsave(&dev->read_list_spinlock, flags); > - rb_count = -1; > list_for_each_entry(rb, &dev->read_list.list, list) { > - ++rb_count; > cl = rb->cl; > if (!cl || !(cl->host_client_id == ishtp_hdr->host_addr && > cl->fw_client_id == ishtp_hdr->fw_addr) || Applied, thanks.
diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c index df0a825694f5..2d92fc129ce4 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.c +++ b/drivers/hid/intel-ish-hid/ishtp/client.c @@ -841,7 +841,6 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, unsigned char *buffer = NULL; struct ishtp_cl_rb *complete_rb = NULL; unsigned long flags; - int rb_count; if (ishtp_hdr->reserved) { dev_err(dev->devc, "corrupted message header.\n"); @@ -855,9 +854,7 @@ void recv_ishtp_cl_msg(struct ishtp_device *dev, } spin_lock_irqsave(&dev->read_list_spinlock, flags); - rb_count = -1; list_for_each_entry(rb, &dev->read_list.list, list) { - ++rb_count; cl = rb->cl; if (!cl || !(cl->host_client_id == ishtp_hdr->host_addr && cl->fw_client_id == ishtp_hdr->fw_addr) ||
The variable rb_count is being incremented but it is never referenced, it is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- V2: Fix commit message. --- drivers/hid/intel-ish-hid/ishtp/client.c | 3 --- 1 file changed, 3 deletions(-)