[net-next,0/2] net: hns3: Cleanup for static warnings.

Message

Hao Lan Nov. 12, 2022, 8:17 a.m. UTC

Most static warnings are mainly about:
Patch #1: fix hns3 driver header file not self-contained issue.
Patch #2: add complete parentheses for some macros.

Hao Chen (1):
  net: hns3: fix hns3 driver header file not self-contained issue

Jiantao Xiao (1):
  net: hns3: add complete parentheses for some macros

 drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h              | 4 +++-
 .../hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.h        | 2 ++
 drivers/net/ethernet/hisilicon/hns3/hns3_enet.h              | 5 ++++-
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_ptp.h       | 5 ++++-
 4 files changed, 13 insertions(+), 3 deletions(-)

Comments

Jakub Kicinski Nov. 15, 2022, 2:59 a.m. UTC | #1

On Sat, 12 Nov 2022 16:17:47 +0800 Hao Lan wrote:
> Most static warnings are mainly about:
> Patch #1: fix hns3 driver header file not self-contained issue.
> Patch #2: add complete parentheses for some macros.

You need to say what static checker was used.
I think it's documented in the "researcher guidelines" doc.
In case patch 2 was based on a warning from checkpatch please
drop it from the series, we don't take checkpatch-based cleanups.

Hao Lan Nov. 15, 2022, 1:29 p.m. UTC | #2

Thanks, we will send another patch.

On 2022/11/15 10:59, Jakub Kicinski wrote:
> On Sat, 12 Nov 2022 16:17:47 +0800 Hao Lan wrote:
>> Most static warnings are mainly about:
>> Patch #1: fix hns3 driver header file not self-contained issue.
>> Patch #2: add complete parentheses for some macros.
> 
> You need to say what static checker was used.
> I think it's documented in the "researcher guidelines" doc.
> In case patch 2 was based on a warning from checkpatch please
> drop it from the series, we don't take checkpatch-based cleanups.
> .
>