| Message ID | 20221102112854.49020-4-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fixing some licences issue in public headers | expand |
On 02/11/2022 11:28, Anthony PERARD wrote: > This header have been created by moving code from other part of the > project and miss a licence header. The original source code was some > version of GPL or LGPL but we intend to have the public header to be > MIT so they can be included easily in other projects. > > Part of device_tree_defs.h were moved from libxl_arm.c which is > LGPL-2.1-only. And part were moved from device_tree.h that is > GPL-2.0-only. > > Part of the original code were added by Julien Grall @ Citrix with a > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with > commit 0c64527e7fc9. > > Resolves: xen-project/xen#35 > Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") > Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> I've checked with relevant people. Citrix is happy for this to be relicensed as proposed. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Hi, On 02/11/2022 11:28, Anthony PERARD wrote: > This header have been created by moving code from other part of the > project and miss a licence header. The original source code was some > version of GPL or LGPL but we intend to have the public header to be > MIT so they can be included easily in other projects. > > Part of device_tree_defs.h were moved from libxl_arm.c which is > LGPL-2.1-only. And part were moved from device_tree.h that is > GPL-2.0-only. > > Part of the original code were added by Julien Grall @ Citrix with a > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > 886f34045bf0. From this comment it is not entirely who you think the copyright owner is. IIRC, part of the agreement was that all code written with my Linaro "hat" would be copyrighted by Linaro rather than Citrix. So I think we would need Linaro's agreement for the relicensing. Cheers,
On Wed, Nov 02, 2022 at 01:16:04PM +0000, Julien Grall wrote: > Hi, > > On 02/11/2022 11:28, Anthony PERARD wrote: > > This header have been created by moving code from other part of the > > project and miss a licence header. The original source code was some > > version of GPL or LGPL but we intend to have the public header to be > > MIT so they can be included easily in other projects. > > > > Part of device_tree_defs.h were moved from libxl_arm.c which is > > LGPL-2.1-only. And part were moved from device_tree.h that is > > GPL-2.0-only. > > > > Part of the original code were added by Julien Grall @ Citrix with a > > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > > 886f34045bf0. > > From this comment it is not entirely who you think the copyright owner is. That's because I'm not sure. > IIRC, part of the agreement was that all code written with my Linaro "hat" > would be copyrighted by Linaro rather than Citrix. > > So I think we would need Linaro's agreement for the relicensing. Sounds good to me. Cheers,
Hi, +Grant Likely from Linaro. In the following change, we need to change the license to MIT (from GPL) of one of Xen public headers which has a Linaro copyright. @Grant Likely: could you confirm that Linaro is agreeing for Xen Project to do such a change ? Kind regards Bertrand Marquis > On 2 Nov 2022, at 11:28, Anthony PERARD <anthony.perard@citrix.com> wrote: > > This header have been created by moving code from other part of the > project and miss a licence header. The original source code was some > version of GPL or LGPL but we intend to have the public header to be > MIT so they can be included easily in other projects. > > Part of device_tree_defs.h were moved from libxl_arm.c which is > LGPL-2.1-only. And part were moved from device_tree.h that is > GPL-2.0-only. > > Part of the original code were added by Julien Grall @ Citrix with a > Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and > 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with > commit 0c64527e7fc9. > > Resolves: xen-project/xen#35 > Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") > Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > --- > > Notes: > Julian was working @citrix until 2015. > > xen/include/public/device_tree_defs.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h > index 228daafe81..9e80d0499d 100644 > --- a/xen/include/public/device_tree_defs.h > +++ b/xen/include/public/device_tree_defs.h > @@ -1,3 +1,9 @@ > +/* SPDX-License-Identifier: MIT */ > +/* > + * Copyright (c) 2013 Linaro Limited > + * Copyright (c) 2015 Citrix Systems, Inc > + */ > + > #ifndef __XEN_DEVICE_TREE_DEFS_H__ > #define __XEN_DEVICE_TREE_DEFS_H__ > > -- > Anthony PERARD > >
Linaro approves the license change Acked-by: Grant Likely <grant.likely@linaro.org <mailto:grant.likely@linaro.org>> > On 11 Nov 2022, at 13:51, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote: > > Hi, > > +Grant Likely from Linaro. > > In the following change, we need to change the license to MIT (from GPL) of one of Xen public headers which has a Linaro copyright. > > @Grant Likely: could you confirm that Linaro is agreeing for Xen Project to do such a change ? > > Kind regards > Bertrand Marquis > >> On 2 Nov 2022, at 11:28, Anthony PERARD <anthony.perard@citrix.com> wrote: >> >> This header have been created by moving code from other part of the >> project and miss a licence header. The original source code was some >> version of GPL or LGPL but we intend to have the public header to be >> MIT so they can be included easily in other projects. >> >> Part of device_tree_defs.h were moved from libxl_arm.c which is >> LGPL-2.1-only. And part were moved from device_tree.h that is >> GPL-2.0-only. >> >> Part of the original code were added by Julien Grall @ Citrix with a >> Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and >> 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with >> commit 0c64527e7fc9. >> >> Resolves: xen-project/xen#35 >> Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") >> Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com> >> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> >> --- >> >> Notes: >> Julian was working @citrix until 2015. >> >> xen/include/public/device_tree_defs.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h >> index 228daafe81..9e80d0499d 100644 >> --- a/xen/include/public/device_tree_defs.h >> +++ b/xen/include/public/device_tree_defs.h >> @@ -1,3 +1,9 @@ >> +/* SPDX-License-Identifier: MIT */ >> +/* >> + * Copyright (c) 2013 Linaro Limited >> + * Copyright (c) 2015 Citrix Systems, Inc >> + */ >> + >> #ifndef __XEN_DEVICE_TREE_DEFS_H__ >> #define __XEN_DEVICE_TREE_DEFS_H__ >> >> -- >> Anthony PERARD >> >> >
Hi Grant, Great thanks for the confirmation! This would timely resolve one of the release blocker for the Xen 4.17 release :) Kind regards, Henry From: Grant Likely <grant.likely@linaro.org> Sent: Wednesday, November 16, 2022 12:08 AM To: Bertrand Marquis <Bertrand.Marquis@arm.com> Cc: Anthony PERARD <anthony.perard@citrix.com>; Xen developer discussion <xen-devel@lists.xenproject.org>; Henry Wang <Henry.Wang@arm.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>; Jan Beulich <jbeulich@suse.com>; Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; Andrew Wafaa <Andrew.Wafaa@arm.com>; Robert Booth <rob.booth@linaro.org> Subject: Re: [XEN PATCH for-4.17 3/4] xen: Add licence header to device_tree_defs.h Linaro approves the license change Acked-by: Grant Likely <grant.likely@linaro.org<mailto:grant.likely@linaro.org>> On 11 Nov 2022, at 13:51, Bertrand Marquis <Bertrand.Marquis@arm.com<mailto:Bertrand.Marquis@arm.com>> wrote: Hi, +Grant Likely from Linaro. In the following change, we need to change the license to MIT (from GPL) of one of Xen public headers which has a Linaro copyright. @Grant Likely: could you confirm that Linaro is agreeing for Xen Project to do such a change ? Kind regards Bertrand Marquis On 2 Nov 2022, at 11:28, Anthony PERARD <anthony.perard@citrix.com<mailto:anthony.perard@citrix.com>> wrote: This header have been created by moving code from other part of the project and miss a licence header. The original source code was some version of GPL or LGPL but we intend to have the public header to be MIT so they can be included easily in other projects. Part of device_tree_defs.h were moved from libxl_arm.c which is LGPL-2.1-only. And part were moved from device_tree.h that is GPL-2.0-only. Part of the original code were added by Julien Grall @ Citrix with a Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with commit 0c64527e7fc9. Resolves: xen-project/xen#35 Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com<mailto:Andrew.Cooper3@citrix.com>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com<mailto:anthony.perard@citrix.com>> --- Notes: Julian was working @citrix until 2015. xen/include/public/device_tree_defs.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 228daafe81..9e80d0499d 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -1,3 +1,9 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright (c) 2013 Linaro Limited + * Copyright (c) 2015 Citrix Systems, Inc + */ + #ifndef __XEN_DEVICE_TREE_DEFS_H__ #define __XEN_DEVICE_TREE_DEFS_H__ -- Anthony PERARD
diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 228daafe81..9e80d0499d 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -1,3 +1,9 @@ +/* SPDX-License-Identifier: MIT */ +/* + * Copyright (c) 2013 Linaro Limited + * Copyright (c) 2015 Citrix Systems, Inc + */ + #ifndef __XEN_DEVICE_TREE_DEFS_H__ #define __XEN_DEVICE_TREE_DEFS_H__
This header have been created by moving code from other part of the project and miss a licence header. The original source code was some version of GPL or LGPL but we intend to have the public header to be MIT so they can be included easily in other projects. Part of device_tree_defs.h were moved from libxl_arm.c which is LGPL-2.1-only. And part were moved from device_tree.h that is GPL-2.0-only. Part of the original code were added by Julien Grall @ Citrix with a Linaro "hat" in commits c3ba52a84dd8 and 405c167f0ec9 and 886f34045bf0. The other part were added by Ian Campbell @ Citrix, with commit 0c64527e7fc9. Resolves: xen-project/xen#35 Fixes: 1c898a9fec7e ("xen/arm: move a few DT related defines to public/device_tree_defs.h") Reported-by: Andrew Cooper <Andrew.Cooper3@citrix.com> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Notes: Julian was working @citrix until 2015. xen/include/public/device_tree_defs.h | 6 ++++++ 1 file changed, 6 insertions(+)