[bpf-next,v3,0/3] A couple of small refactorings of BPF program call sites

Message

Toke Høiland-Jørgensen Nov. 8, 2022, 2:05 p.m. UTC

Stanislav suggested[0] that these small refactorings could be split out from the
XDP queueing RFC series and merged separately. The first change is a small
repacking of struct softnet_data, the others change the BPF call sites to
support full 64-bit values as arguments to bpf_redirect_map() and as the return
value of a BPF program, relying on the fact that BPF registers are always 64-bit
wide to maintain backwards compatibility.

Please see the individual patches for details.

v3:
- In patch 3, don't change types of return values that are copied to
  userspace (which should fix selftest errors on big-endian archs like s390)
- Rebase on bpf-next
- Collect Song's ACKs

v2:
- Rebase on bpf-next (CI failure seems to be unrelated to this series)
- Collect Stanislav's Reviewed-by

[0] https://lore.kernel.org/r/CAKH8qBtdnku7StcQ-SamadvAF==DRuLLZO94yOR1WJ9Bg=[e-mail]

Kumar Kartikeya Dwivedi (1):
  bpf: Use 64-bit return value for bpf_prog_run

Toke Høiland-Jørgensen (2):
  dev: Move received_rps counter next to RPS members in softnet data
  bpf: Expand map key argument of bpf_redirect_map to u64

 include/linux/bpf-cgroup.h | 12 +++++------
 include/linux/bpf.h        | 24 +++++++++++-----------
 include/linux/filter.h     | 42 +++++++++++++++++++-------------------
 include/linux/netdevice.h  |  2 +-
 include/uapi/linux/bpf.h   |  2 +-
 kernel/bpf/cgroup.c        | 12 +++++------
 kernel/bpf/core.c          | 14 ++++++-------
 kernel/bpf/cpumap.c        |  4 ++--
 kernel/bpf/devmap.c        |  4 ++--
 kernel/bpf/offload.c       |  4 ++--
 kernel/bpf/verifier.c      |  2 +-
 net/core/filter.c          |  4 ++--
 net/packet/af_packet.c     |  7 +++++--
 net/xdp/xskmap.c           |  4 ++--
 14 files changed, 70 insertions(+), 67 deletions(-)

Comments

[e-mail] Nov. 15, 2022, 5:10 p.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[e-mail]>:

On Tue,  8 Nov 2022 15:05:58 +0100 you wrote:
> Stanislav suggested[0] that these small refactorings could be split out from the
> XDP queueing RFC series and merged separately. The first change is a small
> repacking of struct softnet_data, the others change the BPF call sites to
> support full 64-bit values as arguments to bpf_redirect_map() and as the return
> value of a BPF program, relying on the fact that BPF registers are always 64-bit
> wide to maintain backwards compatibility.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/3] dev: Move received_rps counter next to RPS members in softnet data
    https://git.kernel.org/bpf/bpf-next/c/14d898f3c1b3
  - [bpf-next,v3,2/3] bpf: Expand map key argument of bpf_redirect_map to u64
    https://git.kernel.org/bpf/bpf-next/c/32637e33003f
  - [bpf-next,v3,3/3] bpf: Use 64-bit return value for bpf_prog_run
    (no matching commit)

You are awesome, thank you!