| Message ID | 20221116143334.4990-1-abhay.maheshbhai.maheta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hci_event: handling CIS QoS | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/subjectprefix | fail | "Bluetooth: " is not specified in the subject |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/buildkernel32 | success | Build Kernel32 PASS |
| tedd_an/incremental_build | success | Pass |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneriso-tester | fail | Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 11, Passed: 11 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerioctl-tester | success | Total: 28, Passed: 28 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermesh-tester | success | Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | fail | TestRunner_iso-tester: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 1.33 seconds GitLint PASS 0.95 seconds SubjectPrefix FAIL 0.59 seconds BuildKernel PASS 33.54 seconds BuildKernel32 PASS 31.34 seconds Incremental Build with patchesPASS 45.63 seconds TestRunner: Setup PASS 513.97 seconds TestRunner: l2cap-tester PASS 16.64 seconds TestRunner: iso-tester FAIL 16.78 seconds TestRunner: bnep-tester PASS 6.58 seconds TestRunner: mgmt-tester PASS 101.31 seconds TestRunner: rfcomm-tester PASS 10.44 seconds TestRunner: sco-tester PASS 9.29 seconds TestRunner: ioctl-tester PASS 11.12 seconds TestRunner: mesh-tester PASS 7.99 seconds TestRunner: smp-tester PASS 9.90 seconds TestRunner: userchan-tester PASS 6.81 seconds Details ############################## Test: SubjectPrefix - FAIL - 0.59 seconds Check subject contains "Bluetooth" prefix "Bluetooth: " is not specified in the subject ############################## Test: TestRunner: iso-tester - FAIL - 16.78 seconds Run test-runner with iso-tester Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 1.977 seconds ISO QoS 8_2_1 - Success Failed 0.152 seconds ISO QoS 16_1_1 - Success Failed 0.151 seconds ISO QoS 16_2_1 - Success Failed 0.150 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.150 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.150 seconds ISO QoS 24_1_1 - Success Failed 0.149 seconds ISO QoS 24_2_1 - Success Failed 0.152 seconds ISO QoS 32_1_1 - Success Failed 0.150 seconds ISO QoS 32_2_1 - Success Failed 0.150 seconds ISO QoS 44_1_1 - Success Failed 0.150 seconds ISO QoS 44_2_1 - Success Failed 0.156 seconds ISO QoS 48_1_1 - Success Failed 0.151 seconds ISO QoS 48_2_1 - Success Failed 0.150 seconds ISO QoS 48_3_1 - Success Failed 0.150 seconds ISO QoS 48_4_1 - Success Failed 0.149 seconds ISO QoS 48_5_1 - Success Failed 0.150 seconds ISO QoS 48_6_1 - Success Failed 0.148 seconds ISO QoS 8_1_2 - Success Failed 0.150 seconds ISO QoS 8_2_2 - Success Failed 0.149 seconds ISO QoS 16_1_2 - Success Failed 0.150 seconds ISO QoS 16_2_2 - Success Failed 0.150 seconds ISO QoS 24_1_2 - Success Failed 0.150 seconds ISO QoS 24_2_2 - Success Failed 0.150 seconds ISO QoS 32_1_2 - Success Failed 0.148 seconds ISO QoS 32_2_2 - Success Failed 0.150 seconds ISO QoS 44_1_2 - Success Failed 0.148 seconds ISO QoS 44_2_2 - Success Failed 0.150 seconds ISO QoS 48_1_2 - Success Failed 0.149 seconds ISO QoS 48_2_2 - Success Failed 0.148 seconds ISO QoS 48_3_2 - Success Failed 0.150 seconds ISO QoS 48_4_2 - Success Failed 0.149 seconds ISO QoS 48_5_2 - Success Failed 0.149 seconds ISO QoS 48_6_2 - Success Failed 0.151 seconds ISO Connect2 CIG 0x01 - Success Failed 0.191 seconds ISO Send - Success Failed 0.153 seconds ISO Receive - Success Failed 0.167 seconds ISO Defer Send - Success Failed 0.156 seconds ISO 48_2_1 Defer Send - Success Failed 0.158 seconds ISO Defer Receive - Success Failed 0.154 seconds ISO 48_2_1 Defer Receive - Success Failed 0.150 seconds ISO Send and Receive - Success Failed 0.157 seconds ISO Disconnect - Success Failed 0.162 seconds ISO Reconnect - Success Failed 0.163 seconds --- Regards, Linux Bluetooth
Please Abhav,
Thank you for the patch.
Am 16.11.22 um 15:33 schrieb Abhay Maheta:
> This sets QoS on CIS connction establishement.
Two typos: connection, establishment
Please extend the commit message with a problem description, and how you
tested the fix.
Kind regards,
Paul
Hi Abhay, On Wed, Nov 16, 2022 at 7:11 AM <bluez.test.bot@gmail.com> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 > > ---Test result--- > > Test Summary: > CheckPatch PASS 1.33 seconds > GitLint PASS 0.95 seconds > SubjectPrefix FAIL 0.59 seconds > BuildKernel PASS 33.54 seconds > BuildKernel32 PASS 31.34 seconds > Incremental Build with patchesPASS 45.63 seconds > TestRunner: Setup PASS 513.97 seconds > TestRunner: l2cap-tester PASS 16.64 seconds > TestRunner: iso-tester FAIL 16.78 seconds > TestRunner: bnep-tester PASS 6.58 seconds > TestRunner: mgmt-tester PASS 101.31 seconds > TestRunner: rfcomm-tester PASS 10.44 seconds > TestRunner: sco-tester PASS 9.29 seconds > TestRunner: ioctl-tester PASS 11.12 seconds > TestRunner: mesh-tester PASS 7.99 seconds > TestRunner: smp-tester PASS 9.90 seconds > TestRunner: userchan-tester PASS 6.81 seconds > > Details > ############################## > Test: SubjectPrefix - FAIL - 0.59 seconds > Check subject contains "Bluetooth" prefix > "Bluetooth: " is not specified in the subject > > ############################## > Test: TestRunner: iso-tester - FAIL - 16.78 seconds > Run test-runner with iso-tester > Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 > > Failed Test Cases > ISO QoS 8_1_1 - Success Failed 1.977 seconds > ISO QoS 8_2_1 - Success Failed 0.152 seconds > ISO QoS 16_1_1 - Success Failed 0.151 seconds > ISO QoS 16_2_1 - Success Failed 0.150 seconds > ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.150 seconds > ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.150 seconds > ISO QoS 24_1_1 - Success Failed 0.149 seconds > ISO QoS 24_2_1 - Success Failed 0.152 seconds > ISO QoS 32_1_1 - Success Failed 0.150 seconds > ISO QoS 32_2_1 - Success Failed 0.150 seconds > ISO QoS 44_1_1 - Success Failed 0.150 seconds > ISO QoS 44_2_1 - Success Failed 0.156 seconds > ISO QoS 48_1_1 - Success Failed 0.151 seconds > ISO QoS 48_2_1 - Success Failed 0.150 seconds > ISO QoS 48_3_1 - Success Failed 0.150 seconds > ISO QoS 48_4_1 - Success Failed 0.149 seconds > ISO QoS 48_5_1 - Success Failed 0.150 seconds > ISO QoS 48_6_1 - Success Failed 0.148 seconds > ISO QoS 8_1_2 - Success Failed 0.150 seconds > ISO QoS 8_2_2 - Success Failed 0.149 seconds > ISO QoS 16_1_2 - Success Failed 0.150 seconds > ISO QoS 16_2_2 - Success Failed 0.150 seconds > ISO QoS 24_1_2 - Success Failed 0.150 seconds > ISO QoS 24_2_2 - Success Failed 0.150 seconds > ISO QoS 32_1_2 - Success Failed 0.148 seconds > ISO QoS 32_2_2 - Success Failed 0.150 seconds > ISO QoS 44_1_2 - Success Failed 0.148 seconds > ISO QoS 44_2_2 - Success Failed 0.150 seconds > ISO QoS 48_1_2 - Success Failed 0.149 seconds > ISO QoS 48_2_2 - Success Failed 0.148 seconds > ISO QoS 48_3_2 - Success Failed 0.150 seconds > ISO QoS 48_4_2 - Success Failed 0.149 seconds > ISO QoS 48_5_2 - Success Failed 0.149 seconds > ISO QoS 48_6_2 - Success Failed 0.151 seconds > ISO Connect2 CIG 0x01 - Success Failed 0.191 seconds > ISO Send - Success Failed 0.153 seconds > ISO Receive - Success Failed 0.167 seconds > ISO Defer Send - Success Failed 0.156 seconds > ISO 48_2_1 Defer Send - Success Failed 0.158 seconds > ISO Defer Receive - Success Failed 0.154 seconds > ISO 48_2_1 Defer Receive - Success Failed 0.150 seconds > ISO Send and Receive - Success Failed 0.157 seconds > ISO Disconnect - Success Failed 0.162 seconds > ISO Reconnect - Success Failed 0.163 seconds I suspect we will need to fix the emulator to make these test pass first: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/emulator/btdev.c#n5889 > > > --- > Regards, > Linux Bluetooth >
Hi Abhay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master linus/master v6.1-rc5 next-20221116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Abhay-Maheta/hci_event-handling-CIS-QoS/20221116-223656
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link: https://lore.kernel.org/r/20221116143334.4990-1-abhay.maheshbhai.maheta%40intel.com
patch subject: [PATCH] hci_event: handling CIS QoS
config: loongarch-randconfig-s031-20221116
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/84db35d22bafe2159cb42b8a2e479123679150a6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Abhay-Maheta/hci_event-handling-CIS-QoS/20221116-223656
git checkout 84db35d22bafe2159cb42b8a2e479123679150a6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=loongarch SHELL=/bin/bash net/bluetooth/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
include/net/bluetooth/hci.h:2632:47: sparse: sparse: array of flexible structures
include/net/bluetooth/hci.h:2718:43: sparse: sparse: array of flexible structures
net/bluetooth/hci_event.c:6805:44: sparse: sparse: cast to restricted __le16
>> net/bluetooth/hci_event.c:6805:44: sparse: sparse: cast from restricted __le32
net/bluetooth/hci_event.c:6809:45: sparse: sparse: cast to restricted __le16
net/bluetooth/hci_event.c:6809:45: sparse: sparse: cast from restricted __le32
>> net/bluetooth/hci_event.c:6813:26: sparse: sparse: cast to restricted __le32
>> net/bluetooth/hci_event.c:6813:26: sparse: sparse: cast from restricted __le16
net/bluetooth/hci_event.c:6815:26: sparse: sparse: cast to restricted __le32
net/bluetooth/hci_event.c:6815:26: sparse: sparse: cast from restricted __le16
vim +6805 net/bluetooth/hci_event.c
6774
6775 static void hci_le_cis_estabilished_evt(struct hci_dev *hdev, void *data,
6776 struct sk_buff *skb)
6777 {
6778 struct hci_evt_le_cis_established *ev = data;
6779 struct hci_conn *conn;
6780 u16 handle = __le16_to_cpu(ev->handle);
6781 __le32 interval;
6782
6783 bt_dev_dbg(hdev, "status 0x%2.2x", ev->status);
6784
6785 hci_dev_lock(hdev);
6786
6787 conn = hci_conn_hash_lookup_handle(hdev, handle);
6788 if (!conn) {
6789 bt_dev_err(hdev,
6790 "Unable to find connection with handle 0x%4.4x",
6791 handle);
6792 goto unlock;
6793 }
6794
6795 if (conn->type != ISO_LINK) {
6796 bt_dev_err(hdev,
6797 "Invalid connection link type handle 0x%4.4x",
6798 handle);
6799 goto unlock;
6800 }
6801
6802 memset(&interval, 0, sizeof(interval));
6803 memcpy(&interval, ev->c_latency, sizeof(ev->c_latency));
6804 /* Converting from microseconds to milliseconds */
> 6805 conn->iso_qos.in.latency = (__u16)(le16_to_cpu(interval) / 1000);
6806
6807 memcpy(&interval, ev->p_latency, sizeof(ev->p_latency));
6808 /* Converting from microseconds to milliseconds */
6809 conn->iso_qos.out.latency = (__u16)(le16_to_cpu(interval) / 1000);
6810
6811 /* Converting interval to microseconds */
6812 conn->iso_qos.in.interval =
> 6813 (__u32)((le32_to_cpu(ev->interval) * 125 / 100) * 1000);
6814 conn->iso_qos.out.interval =
6815 (__u32)((le32_to_cpu(ev->interval) * 125 / 100) * 1000);
6816
6817 conn->iso_qos.in.sdu = le16_to_cpu(ev->c_mtu);
6818 conn->iso_qos.out.sdu = le16_to_cpu(ev->p_mtu);
6819 conn->iso_qos.in.phy = ev->c_phy;
6820 conn->iso_qos.out.phy = ev->p_phy;
6821
6822 if (!ev->status) {
6823 conn->state = BT_CONNECTED;
6824 hci_debugfs_create_conn(conn);
6825 hci_conn_add_sysfs(conn);
6826 hci_iso_setup_path(conn);
6827 goto unlock;
6828 }
6829
6830 hci_connect_cfm(conn, ev->status);
6831 hci_conn_del(conn);
6832
6833 unlock:
6834 hci_dev_unlock(hdev);
6835 }
6836
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 0.59 seconds GitLint PASS 0.28 seconds SubjectPrefix FAIL 0.35 seconds BuildKernel PASS 33.62 seconds BuildKernel32 PASS 29.94 seconds TestRunnerSetup PASS 418.08 seconds TestRunner_l2cap-tester PASS 15.64 seconds TestRunner_iso-tester FAIL 14.97 seconds TestRunner_bnep-tester PASS 5.41 seconds TestRunner_mgmt-tester PASS 103.52 seconds TestRunner_rfcomm-tester PASS 9.04 seconds TestRunner_sco-tester PASS 8.46 seconds TestRunner_ioctl-tester PASS 9.68 seconds TestRunner_mesh-tester PASS 6.62 seconds TestRunner_smp-tester PASS 8.39 seconds TestRunner_userchan-tester PASS 5.51 seconds IncrementalBuild PASS 30.91 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 2.009 seconds ISO QoS 8_2_1 - Success Failed 0.142 seconds ISO QoS 16_1_1 - Success Failed 0.143 seconds ISO QoS 16_2_1 - Success Failed 0.142 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.141 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.140 seconds ISO QoS 24_1_1 - Success Failed 0.139 seconds ISO QoS 24_2_1 - Success Failed 0.141 seconds ISO QoS 32_1_1 - Success Failed 0.139 seconds ISO QoS 32_2_1 - Success Failed 0.139 seconds ISO QoS 44_1_1 - Success Failed 0.142 seconds ISO QoS 44_2_1 - Success Failed 0.141 seconds ISO QoS 48_1_1 - Success Failed 0.140 seconds ISO QoS 48_2_1 - Success Failed 0.140 seconds ISO QoS 48_3_1 - Success Failed 0.142 seconds ISO QoS 48_4_1 - Success Failed 0.141 seconds ISO QoS 48_5_1 - Success Failed 0.139 seconds ISO QoS 48_6_1 - Success Failed 0.139 seconds ISO QoS 8_1_2 - Success Failed 0.143 seconds ISO QoS 8_2_2 - Success Failed 0.143 seconds ISO QoS 16_1_2 - Success Failed 0.141 seconds ISO QoS 16_2_2 - Success Failed 0.145 seconds ISO QoS 24_1_2 - Success Failed 0.142 seconds ISO QoS 24_2_2 - Success Failed 0.143 seconds ISO QoS 32_1_2 - Success Failed 0.141 seconds ISO QoS 32_2_2 - Success Failed 0.141 seconds ISO QoS 44_1_2 - Success Failed 0.140 seconds ISO QoS 44_2_2 - Success Failed 0.137 seconds ISO QoS 48_1_2 - Success Failed 0.140 seconds ISO QoS 48_2_2 - Success Failed 0.137 seconds ISO QoS 48_3_2 - Success Failed 0.141 seconds ISO QoS 48_4_2 - Success Failed 0.139 seconds ISO QoS 48_5_2 - Success Failed 0.137 seconds ISO QoS 48_6_2 - Success Failed 0.139 seconds ISO Connect2 CIG 0x01 - Success Failed 0.176 seconds ISO Send - Success Failed 0.140 seconds ISO Receive - Success Failed 0.145 seconds ISO Defer Send - Success Failed 0.141 seconds ISO 48_2_1 Defer Send - Success Failed 0.139 seconds ISO Defer Receive - Success Failed 0.139 seconds ISO 48_2_1 Defer Receive - Success Failed 0.135 seconds ISO Send and Receive - Success Failed 0.141 seconds ISO Disconnect - Success Failed 0.140 seconds ISO Reconnect - Success Failed 0.141 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 0.55 seconds GitLint PASS 0.23 seconds SubjectPrefix FAIL 0.50 seconds BuildKernel PASS 38.42 seconds BuildKernel32 PASS 34.97 seconds TestRunnerSetup PASS 486.31 seconds TestRunner_l2cap-tester PASS 17.60 seconds TestRunner_iso-tester FAIL 17.97 seconds TestRunner_bnep-tester PASS 6.05 seconds TestRunner_mgmt-tester PASS 116.88 seconds TestRunner_rfcomm-tester PASS 10.35 seconds TestRunner_sco-tester PASS 9.81 seconds TestRunner_ioctl-tester PASS 11.29 seconds TestRunner_mesh-tester PASS 7.82 seconds TestRunner_smp-tester PASS 9.72 seconds TestRunner_userchan-tester PASS 6.52 seconds IncrementalBuild PASS 36.32 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 2.011 seconds ISO QoS 8_2_1 - Success Failed 0.181 seconds ISO QoS 16_1_1 - Success Failed 0.177 seconds ISO QoS 16_2_1 - Success Failed 0.174 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.174 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.173 seconds ISO QoS 24_1_1 - Success Failed 0.176 seconds ISO QoS 24_2_1 - Success Failed 0.172 seconds ISO QoS 32_1_1 - Success Failed 0.167 seconds ISO QoS 32_2_1 - Success Failed 0.177 seconds ISO QoS 44_1_1 - Success Failed 0.177 seconds ISO QoS 44_2_1 - Success Failed 0.172 seconds ISO QoS 48_1_1 - Success Failed 0.169 seconds ISO QoS 48_2_1 - Success Failed 0.160 seconds ISO QoS 48_3_1 - Success Failed 0.172 seconds ISO QoS 48_4_1 - Success Failed 0.164 seconds ISO QoS 48_5_1 - Success Failed 0.167 seconds ISO QoS 48_6_1 - Success Failed 0.169 seconds ISO QoS 8_1_2 - Success Failed 0.162 seconds ISO QoS 8_2_2 - Success Failed 0.165 seconds ISO QoS 16_1_2 - Success Failed 0.163 seconds ISO QoS 16_2_2 - Success Failed 0.168 seconds ISO QoS 24_1_2 - Success Failed 0.175 seconds ISO QoS 24_2_2 - Success Failed 0.165 seconds ISO QoS 32_1_2 - Success Failed 0.167 seconds ISO QoS 32_2_2 - Success Failed 0.173 seconds ISO QoS 44_1_2 - Success Failed 0.169 seconds ISO QoS 44_2_2 - Success Failed 0.174 seconds ISO QoS 48_1_2 - Success Failed 0.175 seconds ISO QoS 48_2_2 - Success Failed 0.169 seconds ISO QoS 48_3_2 - Success Failed 0.165 seconds ISO QoS 48_4_2 - Success Failed 0.167 seconds ISO QoS 48_5_2 - Success Failed 0.164 seconds ISO QoS 48_6_2 - Success Failed 0.161 seconds ISO Connect2 CIG 0x01 - Success Failed 0.215 seconds ISO Send - Success Failed 0.167 seconds ISO Receive - Success Failed 0.167 seconds ISO Defer Send - Success Failed 0.170 seconds ISO 48_2_1 Defer Send - Success Failed 0.168 seconds ISO Defer Receive - Success Failed 0.168 seconds ISO 48_2_1 Defer Receive - Success Failed 0.163 seconds ISO Send and Receive - Success Failed 0.184 seconds ISO Disconnect - Success Failed 0.174 seconds ISO Reconnect - Success Failed 0.168 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 0.70 seconds GitLint PASS 0.35 seconds SubjectPrefix FAIL 0.36 seconds BuildKernel PASS 34.87 seconds BuildKernel32 PASS 31.40 seconds TestRunnerSetup PASS 433.85 seconds TestRunner_l2cap-tester PASS 16.40 seconds TestRunner_iso-tester FAIL 16.15 seconds TestRunner_bnep-tester PASS 5.61 seconds TestRunner_mgmt-tester PASS 108.01 seconds TestRunner_rfcomm-tester PASS 9.55 seconds TestRunner_sco-tester PASS 8.99 seconds TestRunner_ioctl-tester PASS 10.26 seconds TestRunner_mesh-tester PASS 7.12 seconds TestRunner_smp-tester PASS 8.77 seconds TestRunner_userchan-tester PASS 5.89 seconds IncrementalBuild PASS 32.55 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 2.029 seconds ISO QoS 8_2_1 - Success Failed 0.153 seconds ISO QoS 16_1_1 - Success Failed 0.153 seconds ISO QoS 16_2_1 - Success Failed 0.157 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.156 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.153 seconds ISO QoS 24_1_1 - Success Failed 0.153 seconds ISO QoS 24_2_1 - Success Failed 0.152 seconds ISO QoS 32_1_1 - Success Failed 0.156 seconds ISO QoS 32_2_1 - Success Failed 0.155 seconds ISO QoS 44_1_1 - Success Failed 0.154 seconds ISO QoS 44_2_1 - Success Failed 0.150 seconds ISO QoS 48_1_1 - Success Failed 0.152 seconds ISO QoS 48_2_1 - Success Failed 0.153 seconds ISO QoS 48_3_1 - Success Failed 0.150 seconds ISO QoS 48_4_1 - Success Failed 0.152 seconds ISO QoS 48_5_1 - Success Failed 0.152 seconds ISO QoS 48_6_1 - Success Failed 0.154 seconds ISO QoS 8_1_2 - Success Failed 0.156 seconds ISO QoS 8_2_2 - Success Failed 0.152 seconds ISO QoS 16_1_2 - Success Failed 0.152 seconds ISO QoS 16_2_2 - Success Failed 0.155 seconds ISO QoS 24_1_2 - Success Failed 0.156 seconds ISO QoS 24_2_2 - Success Failed 0.154 seconds ISO QoS 32_1_2 - Success Failed 0.156 seconds ISO QoS 32_2_2 - Success Failed 0.152 seconds ISO QoS 44_1_2 - Success Failed 0.154 seconds ISO QoS 44_2_2 - Success Failed 0.152 seconds ISO QoS 48_1_2 - Success Failed 0.157 seconds ISO QoS 48_2_2 - Success Failed 0.153 seconds ISO QoS 48_3_2 - Success Failed 0.155 seconds ISO QoS 48_4_2 - Success Failed 0.155 seconds ISO QoS 48_5_2 - Success Failed 0.154 seconds ISO QoS 48_6_2 - Success Failed 0.155 seconds ISO Connect2 CIG 0x01 - Success Failed 0.194 seconds ISO Send - Success Failed 0.154 seconds ISO Receive - Success Failed 0.159 seconds ISO Defer Send - Success Failed 0.155 seconds ISO 48_2_1 Defer Send - Success Failed 0.152 seconds ISO Defer Receive - Success Failed 0.151 seconds ISO 48_2_1 Defer Receive - Success Failed 0.149 seconds ISO Send and Receive - Success Failed 0.157 seconds ISO Disconnect - Success Failed 0.159 seconds ISO Reconnect - Success Failed 0.158 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 0.81 seconds GitLint PASS 0.37 seconds SubjectPrefix FAIL 0.41 seconds BuildKernel PASS 46.01 seconds BuildKernel32 PASS 40.41 seconds TestRunnerSetup PASS 574.85 seconds TestRunner_l2cap-tester PASS 19.84 seconds TestRunner_iso-tester FAIL 22.36 seconds TestRunner_bnep-tester PASS 7.26 seconds TestRunner_mgmt-tester PASS 137.53 seconds TestRunner_rfcomm-tester PASS 12.26 seconds TestRunner_sco-tester PASS 11.39 seconds TestRunner_ioctl-tester PASS 13.43 seconds TestRunner_mesh-tester PASS 9.43 seconds TestRunner_smp-tester PASS 10.92 seconds TestRunner_userchan-tester PASS 7.34 seconds IncrementalBuild PASS 41.80 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 2.104 seconds ISO QoS 8_2_1 - Success Failed 0.232 seconds ISO QoS 16_1_1 - Success Failed 0.236 seconds ISO QoS 16_2_1 - Success Failed 0.232 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.240 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.232 seconds ISO QoS 24_1_1 - Success Failed 0.244 seconds ISO QoS 24_2_1 - Success Failed 0.232 seconds ISO QoS 32_1_1 - Success Failed 0.236 seconds ISO QoS 32_2_1 - Success Failed 0.240 seconds ISO QoS 44_1_1 - Success Failed 0.232 seconds ISO QoS 44_2_1 - Success Failed 0.232 seconds ISO QoS 48_1_1 - Success Failed 0.224 seconds ISO QoS 48_2_1 - Success Failed 0.232 seconds ISO QoS 48_3_1 - Success Failed 0.232 seconds ISO QoS 48_4_1 - Success Failed 0.240 seconds ISO QoS 48_5_1 - Success Failed 0.232 seconds ISO QoS 48_6_1 - Success Failed 0.236 seconds ISO QoS 8_1_2 - Success Failed 0.232 seconds ISO QoS 8_2_2 - Success Failed 0.236 seconds ISO QoS 16_1_2 - Success Failed 0.232 seconds ISO QoS 16_2_2 - Success Failed 0.224 seconds ISO QoS 24_1_2 - Success Failed 0.244 seconds ISO QoS 24_2_2 - Success Failed 0.232 seconds ISO QoS 32_1_2 - Success Failed 0.240 seconds ISO QoS 32_2_2 - Success Failed 0.228 seconds ISO QoS 44_1_2 - Success Failed 0.236 seconds ISO QoS 44_2_2 - Success Failed 0.228 seconds ISO QoS 48_1_2 - Success Failed 0.228 seconds ISO QoS 48_2_2 - Success Failed 0.240 seconds ISO QoS 48_3_2 - Success Failed 0.232 seconds ISO QoS 48_4_2 - Success Failed 0.236 seconds ISO QoS 48_5_2 - Success Failed 0.240 seconds ISO QoS 48_6_2 - Success Failed 0.236 seconds ISO Connect2 CIG 0x01 - Success Failed 0.308 seconds ISO Send - Success Failed 0.244 seconds ISO Receive - Success Failed 0.244 seconds ISO Defer Send - Success Failed 0.244 seconds ISO 48_2_1 Defer Send - Success Failed 0.244 seconds ISO Defer Receive - Success Failed 0.228 seconds ISO 48_2_1 Defer Receive - Success Failed 0.236 seconds ISO Send and Receive - Success Failed 0.240 seconds ISO Disconnect - Success Failed 0.240 seconds ISO Reconnect - Success Failed 0.244 seconds --- Regards, Linux Bluetooth
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=696036 ---Test result--- Test Summary: CheckPatch PASS 0.69 seconds GitLint PASS 0.34 seconds SubjectPrefix FAIL 0.35 seconds BuildKernel PASS 34.21 seconds BuildKernel32 PASS 30.76 seconds TestRunnerSetup PASS 422.26 seconds TestRunner_l2cap-tester PASS 16.39 seconds TestRunner_iso-tester FAIL 16.21 seconds TestRunner_bnep-tester PASS 5.61 seconds TestRunner_mgmt-tester PASS 108.09 seconds TestRunner_rfcomm-tester PASS 9.52 seconds TestRunner_sco-tester PASS 8.94 seconds TestRunner_ioctl-tester PASS 10.29 seconds TestRunner_mesh-tester PASS 7.01 seconds TestRunner_smp-tester PASS 8.70 seconds TestRunner_userchan-tester PASS 5.86 seconds IncrementalBuild PASS 31.87 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 55, Passed: 11 (20.0%), Failed: 44, Not Run: 0 Failed Test Cases ISO QoS 8_1_1 - Success Failed 2.029 seconds ISO QoS 8_2_1 - Success Failed 0.157 seconds ISO QoS 16_1_1 - Success Failed 0.155 seconds ISO QoS 16_2_1 - Success Failed 0.155 seconds ISO QoS 16_2_1 CIG 0x01 - Success Failed 0.157 seconds ISO QoS 16_2_1 CIG 0x01 CIS 0x01 - Success Failed 0.157 seconds ISO QoS 24_1_1 - Success Failed 0.154 seconds ISO QoS 24_2_1 - Success Failed 0.154 seconds ISO QoS 32_1_1 - Success Failed 0.156 seconds ISO QoS 32_2_1 - Success Failed 0.154 seconds ISO QoS 44_1_1 - Success Failed 0.154 seconds ISO QoS 44_2_1 - Success Failed 0.154 seconds ISO QoS 48_1_1 - Success Failed 0.155 seconds ISO QoS 48_2_1 - Success Failed 0.157 seconds ISO QoS 48_3_1 - Success Failed 0.155 seconds ISO QoS 48_4_1 - Success Failed 0.155 seconds ISO QoS 48_5_1 - Success Failed 0.154 seconds ISO QoS 48_6_1 - Success Failed 0.154 seconds ISO QoS 8_1_2 - Success Failed 0.158 seconds ISO QoS 8_2_2 - Success Failed 0.155 seconds ISO QoS 16_1_2 - Success Failed 0.155 seconds ISO QoS 16_2_2 - Success Failed 0.157 seconds ISO QoS 24_1_2 - Success Failed 0.156 seconds ISO QoS 24_2_2 - Success Failed 0.155 seconds ISO QoS 32_1_2 - Success Failed 0.156 seconds ISO QoS 32_2_2 - Success Failed 0.154 seconds ISO QoS 44_1_2 - Success Failed 0.154 seconds ISO QoS 44_2_2 - Success Failed 0.154 seconds ISO QoS 48_1_2 - Success Failed 0.155 seconds ISO QoS 48_2_2 - Success Failed 0.158 seconds ISO QoS 48_3_2 - Success Failed 0.157 seconds ISO QoS 48_4_2 - Success Failed 0.155 seconds ISO QoS 48_5_2 - Success Failed 0.153 seconds ISO QoS 48_6_2 - Success Failed 0.155 seconds ISO Connect2 CIG 0x01 - Success Failed 0.197 seconds ISO Send - Success Failed 0.158 seconds ISO Receive - Success Failed 0.159 seconds ISO Defer Send - Success Failed 0.159 seconds ISO 48_2_1 Defer Send - Success Failed 0.155 seconds ISO Defer Receive - Success Failed 0.151 seconds ISO 48_2_1 Defer Receive - Success Failed 0.154 seconds ISO Send and Receive - Success Failed 0.164 seconds ISO Disconnect - Success Failed 0.160 seconds ISO Reconnect - Success Failed 0.156 seconds --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index faca701bce2a..d04af3ad6b73 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -6778,6 +6778,7 @@ static void hci_le_cis_estabilished_evt(struct hci_dev *hdev, void *data, struct hci_evt_le_cis_established *ev = data; struct hci_conn *conn; u16 handle = __le16_to_cpu(ev->handle); + __le32 interval; bt_dev_dbg(hdev, "status 0x%2.2x", ev->status); @@ -6798,22 +6799,25 @@ static void hci_le_cis_estabilished_evt(struct hci_dev *hdev, void *data, goto unlock; } - if (conn->role == HCI_ROLE_SLAVE) { - __le32 interval; + memset(&interval, 0, sizeof(interval)); + memcpy(&interval, ev->c_latency, sizeof(ev->c_latency)); + /* Converting from microseconds to milliseconds */ + conn->iso_qos.in.latency = (__u16)(le16_to_cpu(interval) / 1000); - memset(&interval, 0, sizeof(interval)); + memcpy(&interval, ev->p_latency, sizeof(ev->p_latency)); + /* Converting from microseconds to milliseconds */ + conn->iso_qos.out.latency = (__u16)(le16_to_cpu(interval) / 1000); - memcpy(&interval, ev->c_latency, sizeof(ev->c_latency)); - conn->iso_qos.in.interval = le32_to_cpu(interval); - memcpy(&interval, ev->p_latency, sizeof(ev->p_latency)); - conn->iso_qos.out.interval = le32_to_cpu(interval); - conn->iso_qos.in.latency = le16_to_cpu(ev->interval); - conn->iso_qos.out.latency = le16_to_cpu(ev->interval); - conn->iso_qos.in.sdu = le16_to_cpu(ev->c_mtu); - conn->iso_qos.out.sdu = le16_to_cpu(ev->p_mtu); - conn->iso_qos.in.phy = ev->c_phy; - conn->iso_qos.out.phy = ev->p_phy; - } + /* Converting interval to microseconds */ + conn->iso_qos.in.interval = + (__u32)((le32_to_cpu(ev->interval) * 125 / 100) * 1000); + conn->iso_qos.out.interval = + (__u32)((le32_to_cpu(ev->interval) * 125 / 100) * 1000); + + conn->iso_qos.in.sdu = le16_to_cpu(ev->c_mtu); + conn->iso_qos.out.sdu = le16_to_cpu(ev->p_mtu); + conn->iso_qos.in.phy = ev->c_phy; + conn->iso_qos.out.phy = ev->p_phy; if (!ev->status) { conn->state = BT_CONNECTED;
This sets QoS on CIS connction establishement. Signed-off-by: Abhay Maheta <abhay.maheshbhai.maheta@intel.com> --- net/bluetooth/hci_event.c | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-)