| Message ID | 20221116151726.129217-5-jlayton@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: fix inode->i_flctx accesses | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
2022-11-17 0:17 GMT+09:00, Jeff Layton <jlayton@kernel.org>: > ksmbd currently doesn't access i_flctx safely. This requires a > smp_load_acquire, as the pointer is set via cmpxchg (a release > operation). > > Cc: Namjae Jeon <linkinjeon@kernel.org> > Cc: Steve French <sfrench@samba.org> > Signed-off-by: Jeff Layton <jlayton@kernel.org> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Thanks for your patch!
diff --git a/fs/ksmbd/vfs.c b/fs/ksmbd/vfs.c index 8de970d6146f..f9e85d6a160e 100644 --- a/fs/ksmbd/vfs.c +++ b/fs/ksmbd/vfs.c @@ -321,7 +321,7 @@ static int check_lock_range(struct file *filp, loff_t start, loff_t end, unsigned char type) { struct file_lock *flock; - struct file_lock_context *ctx = file_inode(filp)->i_flctx; + struct file_lock_context *ctx = locks_inode_context(file_inode(filp)); int error = 0; if (!ctx || list_empty_careful(&ctx->flc_posix))
ksmbd currently doesn't access i_flctx safely. This requires a smp_load_acquire, as the pointer is set via cmpxchg (a release operation). Cc: Namjae Jeon <linkinjeon@kernel.org> Cc: Steve French <sfrench@samba.org> Signed-off-by: Jeff Layton <jlayton@kernel.org> --- fs/ksmbd/vfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)