| Message ID | Y2o0TKZ5WRYnQXna@kili (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/hdmi: remove unnecessary NULL check | expand |
On 11/15/2022 5:03 AM, Dan Carpenter wrote: > This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move > resource allocation to probe function") and now the "hdmi" pointer can't > be NULL. Checking causes a Smatch warning: > > drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() > warn: variable dereferenced before check 'hdmi' (see line 119) > > Signed-off-by: Dan Carpenter <error27@gmail.com> Can you please add the fixes tag to point to the commit you have referenced in the commit message? LTGM, Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c > index 7001fabd0977..4d3fdc806bef 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c > @@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi) > return 0; > > fail: > - if (hdmi) > - msm_hdmi_destroy(hdmi); > + msm_hdmi_destroy(hdmi); > > return ret; > }
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 7001fabd0977..4d3fdc806bef 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -138,8 +138,7 @@ static int msm_hdmi_init(struct hdmi *hdmi) return 0; fail: - if (hdmi) - msm_hdmi_destroy(hdmi); + msm_hdmi_destroy(hdmi); return ret; }
This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") and now the "hdmi" pointer can't be NULL. Checking causes a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init() warn: variable dereferenced before check 'hdmi' (see line 119) Signed-off-by: Dan Carpenter <error27@gmail.com> --- drivers/gpu/drm/msm/hdmi/hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)