diff mbox series

[v2] scsi: lpfc: remove redundant pointer lp

Message ID 20221108183620.93978-1-jsmart2021@gmail.com (mailing list archive)
State Accepted
Headers show
Series [v2] scsi: lpfc: remove redundant pointer lp | expand

Commit Message

James Smart Nov. 8, 2022, 6:36 p.m. UTC 
From:   Colin Ian King <colin.i.king@gmail.com>

Pointer lp is being initialized and incremented but the result
is never read. The pointer is redundant and can be removed.

Once lp is removed, pcmd is not longer used. So removed pcmd as well

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>

---
lp removal by Colin left as is.
I added the pcmd mod on top of it.
---
 drivers/scsi/lpfc/lpfc_els.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Martin K. Petersen Nov. 17, 2022, 6:07 p.m. UTC | #1 
James,

> Pointer lp is being initialized and incremented but the result is
> never read. The pointer is redundant and can be removed.
>
> Once lp is removed, pcmd is not longer used. So removed pcmd as well

Applied to 6.2/scsi-staging, thanks!
Martin K. Petersen Nov. 26, 2022, 3:27 a.m. UTC | #2 
On Tue, 8 Nov 2022 10:36:20 -0800, James Smart wrote:

> From:   Colin Ian King <colin.i.king@gmail.com>
> 
> Pointer lp is being initialized and incremented but the result
> is never read. The pointer is redundant and can be removed.
> 
> Once lp is removed, pcmd is not longer used. So removed pcmd as well
> 
> [...]

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: lpfc: remove redundant pointer lp
      https://git.kernel.org/mkp/scsi/c/729c287e9f74
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 2b03210264bb..9326340d4226 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -9172,15 +9172,10 @@  static int
 lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
 		   struct lpfc_nodelist  *ndlp)
 {
-	struct lpfc_dmabuf *pcmd;
-	uint32_t *lp;
 	uint32_t did;
 
 	did = get_job_els_rsp64_did(vport->phba, cmdiocb);
-	pcmd = cmdiocb->cmd_dmabuf;
-	lp = (uint32_t *)pcmd->virt;
 
-	lp++;
 	/* FARP-RSP received from DID <did> */
 	lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS,
 			 "0600 FARP-RSP received from DID x%x\n", did);