mbox series

[0/4] Endianess and coding style fixes for SVQ event idx support

Message ID 20221028160251.268607-1-eperezma@redhat.com (mailing list archive)
Headers show
Series Endianess and coding style fixes for SVQ event idx support | expand

Message

Eugenio Perez Martin Oct. 28, 2022, 4:02 p.m. UTC 
Some fixes that did not get in time for the last net pull request.

Eugenio Pérez (4):
  vhost: Delete useless casting
  vhost: convert byte order on SVQ used event write
  vhost: Fix lines over 80 characters
  vhost: convert byte order on avail_event read

 hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Michael S. Tsirkin Oct. 29, 2022, 8:24 a.m. UTC | #1 
On Fri, Oct 28, 2022 at 06:02:47PM +0200, Eugenio Pérez wrote:
> Some fixes that did not get in time for the last net pull request.


Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Jason's tree since he has some bits this depends on.

> Eugenio Pérez (4):
>   vhost: Delete useless casting
>   vhost: convert byte order on SVQ used event write
>   vhost: Fix lines over 80 characters
>   vhost: convert byte order on avail_event read
> 
>  hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> -- 
> 2.31.1
>
Philippe Mathieu-Daudé Oct. 31, 2022, 8:14 a.m. UTC | #2 
On 29/10/22 10:24, Michael S. Tsirkin wrote:
> On Fri, Oct 28, 2022 at 06:02:47PM +0200, Eugenio Pérez wrote:
>> Some fixes that did not get in time for the last net pull request.
> 
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Jason's tree since he has some bits this depends on.
FYI I made 2 comments/questions whether using the virtio LD/ST API
isn't more appropriate here.
Jason Wang Nov. 1, 2022, 2:41 a.m. UTC | #3 
On Sat, Oct 29, 2022 at 12:02 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Some fixes that did not get in time for the last net pull request.
>
> Eugenio Pérez (4):
>   vhost: Delete useless casting
>   vhost: convert byte order on SVQ used event write
>   vhost: Fix lines over 80 characters
>   vhost: convert byte order on avail_event read

I've queued this for rc1.

Thanks

>
>  hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.31.1
>
>
Lei Yang Nov. 18, 2022, 2:49 a.m. UTC | #4 
QE tries to test the parameter "event_idx=on". In both environments
"virtio-vdpa + vp_vdpa" and "vhost_vdpa + vp_vdpa", there is no
network connectivity issue after the guest boot up.

Tested-by: Lei Yang <leiyang@redhat.com>


> From: Jason Wang <jasowang@redhat.com>
> Date: Tue, Nov 1, 2022 at 10:42 AM
> Subject: Re: [PATCH 0/4] Endianess and coding style fixes for SVQ
> event idx support
> To: Eugenio Pérez <eperezma@redhat.com>
> Cc: <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>,
> Michael S. Tsirkin <mst@redhat.com>
>
>
> On Sat, Oct 29, 2022 at 12:02 AM Eugenio Pérez <eperezma@redhat.com> wrote:
> >
> > Some fixes that did not get in time for the last net pull request.
> >
> > Eugenio Pérez (4):
> >   vhost: Delete useless casting
> >   vhost: convert byte order on SVQ used event write
> >   vhost: Fix lines over 80 characters
> >   vhost: convert byte order on avail_event read
>
> I've queued this for rc1.
>
> Thanks
>
> >
> >  hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > --
> > 2.31.1
> >
> >
>